Escape all arguments passed to the xcrun simctl

yyosifov · web-flow · commit ee1a6a6dd26f · 2017-05-04T11:24:17.000+03:00
diff --git a/lib/simctl.ts b/lib/simctl.ts
@@ -117,7 +117,9 @@ export class Simctl implements ISimctl {
 	}
 
 	private simctlExec(command: string, args: string[], opts?: any): any {
-		let fullCommand = (["xcrun", "simctl", command].concat(args)).join(" ");
+		let escapedArgs = args.map((arg) => `"${arg}"`);
+		let fullCommand = (["xcrun", "simctl", command].concat(escapedArgs)).join(" ");
+
 		return childProcess.execSync(fullCommand, opts).toString().trim();
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,9 @@ export class Simctl implements ISimctl {`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`private simctlExec(command: string, args: string[], opts?: any): any {`
`120`		`- let fullCommand = (["xcrun", "simctl", command].concat(args)).join(" ");`
	`120`	+ let escapedArgs = args.map((arg) => `"${arg}"`);
	`121`	`+ let fullCommand = (["xcrun", "simctl", command].concat(escapedArgs)).join(" ");`
	`122`	`+`
`121`	`123`	`return childProcess.execSync(fullCommand, opts).toString().trim();`
`122`	`124`	`}`
`123`	`125`	`}`