fix: don't suppress timer exceptions

edusperoni · edusperoni · commit 0c4b819941b0 · 2023-08-04T17:32:21.000-03:00
diff --git a/NativeScript/runtime/Timers.cpp b/NativeScript/runtime/Timers.cpp
@@ -161,7 +161,6 @@ void TimerCallback(CFRunLoopTimerRef timer, void *info) {
     v8::Local<v8::Function> cb = task->callback_.Get(isolate);
     v8::Local<v8::Context> context = cb->GetCreationContextChecked();
     Context::Scope context_scope(context);
-    TryCatch tc(isolate);
     auto argc = task->args_.get() == nullptr ? 0 : task->args_->size();
     if (argc > 0) {
         Local<Value> argv[argc];
@@ -172,11 +171,11 @@ void TimerCallback(CFRunLoopTimerRef timer, void *info) {
     } else {
         (void)cb->Call(context, context->Global(), 0, nullptr);
     }
-    tc.ReThrow();
     
     if (!task->repeats_) {
         data->state->removeTask(task);
     }
+    
 }
 
 void Timers::SetTimer(const v8::FunctionCallbackInfo<v8::Value>& args, bool repeatable) {

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,6 @@ void TimerCallback(CFRunLoopTimerRef timer, void *info) {`
`161`	`161`	`v8::Local<v8::Function> cb = task->callback_.Get(isolate);`
`162`	`162`	`v8::Local<v8::Context> context = cb->GetCreationContextChecked();`
`163`	`163`	`Context::Scope context_scope(context);`
`164`		`- TryCatch tc(isolate);`
`165`	`164`	`auto argc = task->args_.get() == nullptr ? 0 : task->args_->size();`
`166`	`165`	`if (argc > 0) {`
`167`	`166`	`Local<Value> argv[argc];`
`@@ -172,11 +171,11 @@ void TimerCallback(CFRunLoopTimerRef timer, void *info) {`
`172`	`171`	`} else {`
`173`	`172`	`(void)cb->Call(context, context->Global(), 0, nullptr);`
`174`	`173`	`}`
`175`		`- tc.ReThrow();`
`176`	`174`
`177`	`175`	`if (!task->repeats_) {`
`178`	`176`	`data->state->removeTask(task);`
`179`	`177`	`}`
	`178`	`+`
`180`	`179`	`}`
`181`	`180`
`182`	`181`	`void Timers::SetTimer(const v8::FunctionCallbackInfo<v8::Value>& args, bool repeatable) {`