Skip to content

Commit 36e3dd3

Browse files
authored
chore: remove defunct V8 external startup data stuff (#210)
1 parent c100f72 commit 36e3dd3

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

NativeScript/v8runtime/V8Runtime.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,6 @@ class V8Runtime : public facebook::jsi::Runtime {
205205

206206
private:
207207
std::unique_ptr<v8::ArrayBuffer::Allocator> arrayBufferAllocator_;
208-
std::unique_ptr<v8::StartupData> snapshotBlob_;
209208
v8::Isolate *isolate_;
210209
v8::Global<v8::Context> context_;
211210
bool isSharedRuntime_ = false;

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ git submodule update --init
1919
# Ensure that you have the required llvm binaries for building the metadata generator
2020
./download_llvm.sh
2121

22+
sudo gem install xcodeproj
23+
sudo gem install cocoapods
24+
2225
# Open the runtime in Xcode
2326
open v8ios.xcodeproj
2427
```

v8ios.xcodeproj/project.pbxproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
/* Begin PBXBuildFile section */
1010
2B7EA6AF2353477000E5184E /* NativeScriptException.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2B7EA6AD2353476F00E5184E /* NativeScriptException.mm */; };
1111
2B7EA6B02353477000E5184E /* NativeScriptException.h in Headers */ = {isa = PBXBuildFile; fileRef = 2B7EA6AE2353477000E5184E /* NativeScriptException.h */; };
12-
2C998AC1290FB501002BBFA9 /* SnapshotBlob.h in Headers */ = {isa = PBXBuildFile; fileRef = 2C998AC0290FB500002BBFA9 /* SnapshotBlob.h */; };
1312
3CA6E53529A78C6000D30F8B /* IsolateWrapper.h in Headers */ = {isa = PBXBuildFile; fileRef = 3CA6E53429A78C6000D30F8B /* IsolateWrapper.h */; };
1413
3CBFF7442971C1C200C5DE36 /* ArcMacro.h in Headers */ = {isa = PBXBuildFile; fileRef = 3CBFF7432971C1C200C5DE36 /* ArcMacro.h */; };
1514
3CD1D9C129AA2C14004C1C21 /* DisposerPHV.mm in Sources */ = {isa = PBXBuildFile; fileRef = 3CD1D9BF29AA2C14004C1C21 /* DisposerPHV.mm */; };
@@ -419,7 +418,6 @@
419418
/* Begin PBXFileReference section */
420419
2B7EA6AD2353476F00E5184E /* NativeScriptException.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = NativeScriptException.mm; sourceTree = "<group>"; };
421420
2B7EA6AE2353477000E5184E /* NativeScriptException.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NativeScriptException.h; sourceTree = "<group>"; };
422-
2C998AC0290FB500002BBFA9 /* SnapshotBlob.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = SnapshotBlob.h; sourceTree = "<group>"; };
423421
3CA6E53429A78C6000D30F8B /* IsolateWrapper.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = IsolateWrapper.h; sourceTree = "<group>"; };
424422
3CBFF7432971C1C200C5DE36 /* ArcMacro.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = ArcMacro.h; sourceTree = "<group>"; };
425423
3CD1D9BF29AA2C14004C1C21 /* DisposerPHV.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = DisposerPHV.mm; sourceTree = "<group>"; };
@@ -1409,7 +1407,6 @@
14091407
C275F475253B37AB00A997D5 /* UnmanagedType.mm */,
14101408
3CEF9CCC28F896B70056BA45 /* SpinLock.h */,
14111409
3CA6E53429A78C6000D30F8B /* IsolateWrapper.h */,
1412-
2C998AC0290FB500002BBFA9 /* SnapshotBlob.h */,
14131410
);
14141411
path = runtime;
14151412
sourceTree = "<group>";
@@ -1501,7 +1498,6 @@
15011498
C2D7E9D523F42C1100DB289C /* PromiseProxy.h in Headers */,
15021499
C2A5F86B2359AEB600074AFA /* ExtVector.h in Headers */,
15031500
C2DDEBB0229EAC8300345BFE /* StringHasher.h in Headers */,
1504-
2C998AC1290FB501002BBFA9 /* SnapshotBlob.h in Headers */,
15051501
C247C16A22F82842001D2CA2 /* v8-profiler.h in Headers */,
15061502
C2DDEB8E229EAC8300345BFE /* Interop.h in Headers */,
15071503
C2DDEBA2229EAC8300345BFE /* Console.h in Headers */,

0 commit comments

Comments
 (0)