Skip to content

Commit 8329e87

Browse files
authored
chore: readme updates
1 parent 75cf79f commit 8329e87

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

README.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ brew install cmake
1010
sudo ln -s /usr/local/bin/cmake $(which cmake)
1111

1212
# Clone repo
13-
git clone https://github.com/NativeScript/ns-v8ios-runtime.git
13+
git clone https://github.com/NativeScript/ios.git
1414

1515
# Initialize and clone the submodules
16-
cd ns-v8ios-runtime
16+
cd ios
1717
git submodule update --init
1818

1919
# Ensure that you have the required llvm binaries for building the metadata generator
@@ -73,7 +73,7 @@ Add the `Nativescript.framework` from the v8ios workspace:
7373
If you encounter vague errors like this when building your app with the runtime included (This has been observed sometimes while Profiling apps in Xcode):
7474

7575
```
76-
/path/to/ns-v8ios-runtime/NativeScript/inspector/src/base/atomicops.h:311:11: No matching function for call to 'Relaxed_Load'
76+
/path/to/ios/NativeScript/inspector/src/base/atomicops.h:311:11: No matching function for call to 'Relaxed_Load'
7777
```
7878

7979
This is most likely related to `Build Active Architecture Only` setting in Xcode for various targets (your app and the included v8ios runtime). You should check to make sure your app `Build Settings` and the v8ios targets `NativeScript` and `TKLiveSync` Build Settings are set to YES for both Debug and Release. See this reference:
@@ -101,8 +101,8 @@ In order to build the V8 engine for iOS and produce the static libraries used in
101101
**Prerequisites:**
102102

103103
```
104-
git clone https://github.com/NativeScript/ns-v8ios-runtime.git
105-
cd ns-v8ios-runtime
104+
git clone https://github.com/NativeScript/ios.git
105+
cd ios
106106
```
107107

108108
You will need Google [depot_tools](https://www.chromium.org/developers/how-tos/install-depot-tools)
@@ -122,7 +122,7 @@ export PATH=`pwd`/depot_tools:"$PATH"
122122
123123
```
124124
// IMPORTANT: Make sure you are inside the clone of this repo...
125-
cd ns-v8ios-runtime
125+
cd ios
126126
127127
// Fetch v8 source:
128128
fetch v8
@@ -158,7 +158,7 @@ error: patch failed: BUILD.gn:538
158158
error: BUILD.gn: patch does not apply
159159
error: patch failed: src/inspector/inspector_protocol_config.json:21
160160
error: src/inspector/inspector_protocol_config.json: patch does not apply
161-
~/Documents/ns-v8ios-runtime/v8/build ~/Documents/ns-v8ios-runtime/v8 ~/Documents/ns-v8ios-runtime
161+
~/Documents/ios/v8/build ~/Documents/ios/v8 ~/Documents/ios
162162
error: patch failed: config/ios/ios_sdk.gni:32
163163
error: config/ios/ios_sdk.gni: patch does not apply
164164
```
@@ -176,12 +176,12 @@ npm run build-v8-source
176176
* Example failure 1:
177177

178178
```
179-
@Mac ns-v8ios-runtime % npm run build-v8-source
179+
@Mac ios % npm run build-v8-source
180180
181181
> @nativescript/[email protected] build-v8-source
182182
> ./build_v8_source.sh
183183
184-
~/Documents/ns-v8ios-runtime/v8 ~/Documents/ns-v8ios-runtime
184+
~/Documents/ios/v8 ~/Documents/ios
185185
Building for out.gn/x64-release (simulator)
186186
Done. Made 212 targets from 92 files in 4004ms
187187
ninja: Entering directory `out.gn/x64-release'

0 commit comments

Comments
 (0)