fix(ios16-beta5): errors and crash (#179)

Author: rigor789

NativeScript/NativeScript-Prefix.pch

@@ -1,7 +1,7 @@
 #ifndef NativeScript_Prefix_pch
 #define NativeScript_Prefix_pch
 
-#define NATIVESCRIPT_VERSION "8.3.2"
+#define NATIVESCRIPT_VERSION "8.3.3-alpha.0"
 
 #ifdef DEBUG
 #define SIZEOF_OFF_T 8

NativeScript/runtime/ExtVector.cpp

@@ -80,7 +80,7 @@ void ExtVector::RegisterToStringMethod(Isolate* isolate, Local<ObjectTemplate> p
         void* value = wrapper->Data();
 
         char buffer[100];
-        sprintf(buffer, "<Vector: %p>", value);
+        snprintf(buffer, 100, "<Vector: %p>", value);
 
         Local<v8::String> result = tns::ToV8String(isolate, buffer);
         info.GetReturnValue().Set(result);

NativeScript/runtime/Metadata.mm

@@ -76,7 +76,12 @@ static UInt8 getSystemVersion() {
 
         auto it = sampleInstances.find(klass);
         if (it == sampleInstances.end()) {
-            it = sampleInstances.emplace(klass, [klass alloc]).first;
+            @try {
+                it = sampleInstances.emplace(klass, [klass alloc]).first;
+            }
+            @catch(id err) {
+                return false;
+            }
         }
         id sampleInstance = it->second;
         return [sampleInstance respondsToSelector:this->selector()];

NativeScript/runtime/Pointer.cpp

@@ -179,7 +179,7 @@ void Pointer::RegisterToStringMethod(Local<Context> context, Local<Object> proto
         void* value = wrapper->Data();
 
         char buffer[100];
-        sprintf(buffer, "<Pointer: %p>", value);
+        snprintf(buffer, 100, "<Pointer: %p>", value);
 
         Local<v8::String> result = tns::ToV8String(isolate, buffer);
         info.GetReturnValue().Set(result);
@@ -200,7 +200,7 @@ void Pointer::RegisterToHexStringMethod(Local<Context> context, Local<Object> pr
         const void* value = wrapper->Data();
 
         char buffer[100];
-        sprintf(buffer, "%p", value);
+        snprintf(buffer, 100, "%p", value);
 
         Local<v8::String> result = tns::ToV8String(isolate, buffer);
         info.GetReturnValue().Set(result);
@@ -222,7 +222,7 @@ void Pointer::RegisterToDecimalStringMethod(Local<Context> context, Local<Object
         intptr_t ptr = static_cast<intptr_t>(reinterpret_cast<size_t>(value));
 
         char buffer[100];
-        sprintf(buffer, "%ld", ptr);
+        snprintf(buffer, 100, "%ld", ptr);
 
         Local<v8::String> result = tns::ToV8String(isolate, buffer);
         info.GetReturnValue().Set(result);

NativeScript/runtime/Reference.cpp

@@ -295,9 +295,9 @@ void Reference::RegisterToStringMethod(Local<Context> context, Local<Object> pro
 
         char buffer[100];
         if (value == nullptr) {
-            sprintf(buffer, "<Reference: %p>", reinterpret_cast<void*>(0));
+            snprintf(buffer, 100, "<Reference: %p>", reinterpret_cast<void*>(0));
         } else {
-            sprintf(buffer, "<Reference: %p>", value);
+            snprintf(buffer, 100, "<Reference: %p>", value);
         }
 
         Local<v8::String> result = tns::ToV8String(isolate, buffer);

package.json

@@ -1,7 +1,7 @@
 {
   "name": "@nativescript/ios",
   "description": "NativeScript Runtime for iOS",
-  "version": "8.3.2",
+  "version": "8.3.3-alpha.0",
   "keywords": [
     "NativeScript",
     "iOS",