chore: log disable part 1 - still get TNS.Java logs though

Author: NathanWalker

test-app/app/src/main/java/com/tns/LogcatLogger.java

@@ -33,14 +33,14 @@ public final void write(String tag, String msg) {
     }
 
     private void initLogging(Context context) {
-        setEnabled(true);
-//        boolean isDebuggableApp = Util.isDebuggableApp(context);
-//        if (isDebuggableApp) {
-//            String verboseLoggingProp = Util.readSystemProperty("nativescript.verbose.logging");
-//
-//            if (Util.isPositive(verboseLoggingProp)) {
-//                setEnabled(true);
-//            }
-//        }
+        // setEnabled(true);
+       boolean isDebuggableApp = Util.isDebuggableApp(context);
+       if (isDebuggableApp) {
+           String verboseLoggingProp = Util.readSystemProperty("nativescript.verbose.logging");
+
+           if (Util.isPositive(verboseLoggingProp)) {
+               setEnabled(true);
+           }
+       }
     }
 }

test-app/runtime/build.gradle

@@ -1,5 +1,6 @@
 apply plugin: 'com.android.library'
 
+// can be: "V8", "JSC", "HERMES", "QUICKJS"
 def jsEngine = "V8"
 if (project.hasProperty("engine")) {
     jsEngine = engine;

test-app/runtime/src/main/cpp/runtime/Runtime.cpp

@@ -38,7 +38,7 @@
 using namespace tns;
 using namespace std;
 
-bool tns::LogEnabled = true;
+bool tns::LogEnabled = false;
 
 void Runtime::Init(JavaVM *vm) {
     __android_log_print(ANDROID_LOG_INFO, "TNS.Runtime",

test-app/runtime/src/main/cpp/runtime/exceptions/NativeScriptAssert.h

@@ -15,10 +15,10 @@ bool enabled = false;
 namespace tns {
 extern bool LogEnabled;
 
-// #define DEBUG_WRITE(fmt, args...) if (enabled) __android_log_print(ANDROID_LOG_DEBUG, "TNS.Native", fmt, ##args)
-#define DEBUG_WRITE(fmt, args...) __android_log_print(ANDROID_LOG_DEBUG, "TNS.Native", fmt, ##args)
-#define DEBUG_WRITE_FORCE(fmt, args...) __android_log_print(ANDROID_LOG_DEBUG, "TNS.Native", fmt, ##args)
-#define DEBUG_WRITE_FATAL(fmt, args...) __android_log_print(ANDROID_LOG_FATAL, "TNS.Native", fmt, ##args)
+#define DEBUG_WRITE(fmt, args...) if (enabled) __android_log_print(ANDROID_LOG_DEBUG, "TNS.Native", fmt, ##args)
+// #define DEBUG_WRITE(fmt, args...) __android_log_print(ANDROID_LOG_DEBUG, "TNS.Native", fmt, ##args)
+#define DEBUG_WRITE_FORCE(fmt, args...) if (enabled) __android_log_print(ANDROID_LOG_DEBUG, "TNS.Native", fmt, ##args)
+#define DEBUG_WRITE_FATAL(fmt, args...) if (enabled) __android_log_print(ANDROID_LOG_FATAL, "TNS.Native", fmt, ##args)
 }
 
 #endif /* NATIVESCRIPTASSERT_H_ */