Merge pull request #32 from NativeScript/v8-update

Update V8 to 13.8.9

Author: ammarahm-ed

README.md

@@ -68,34 +68,18 @@ Clone the repo:
 git clone https://github.com/NativeScript/napi-android.git
 ```
 
-Install the jsparser dependencies:
-
-```Shell
-cd test-app/build-tools/jsparser
-npm install
-```
-
 Set the following environment variables:
 
 - `JAVA_HOME` such that `$JAVA_HOME/bin/java` points to your Java executable
 - `ANDROID_HOME` pointing to where you have installed the Android SDK
 - `ANDROID_NDK_HOME` pointing to the version of the Android NDK needed for this version of NativeScript
 
-Run command
-
-Windows:
+Run the following command to build the runtime:
 
-```Shell
-gradlew -Pengine=V8
 ```
-
-Mac/Linux:
-
-```Shell
-./gradlew -Pengine=V8
+npm run build
 ```
-
-You can pass in `QUICKJS`, `HERMES`, `JSC` or `V8` to compile the runtime with the respective JS engine.
+The command will let you interactively choose the JS engine you want to build with. i.e V8, QuickJS, Hermes or JSC, PrimJS, Static Hermes.
 
 - The build process includes building of the runtime package (both optimized and with unstripped v8 symbol table), as well as all supplementary tools used for the android builds: metadata-generator, binding-generator, metadata-generator, static-binding-generator
 - The result of the build will be in the dist\_[engine] folder. For example if you are building with V8, the result will be in the dist_v8 folder.

build.gradle

@@ -33,7 +33,7 @@ def pVersion = "no package version was provided by build.gradle build"
 def arVersion = "no commit sha was provided by build.gradle build"
 def generateRegularRuntimePackage = !project.hasProperty("skipUnoptimized")
 
-def jsEngine = engine ?: 'v8'
+def jsEngine = engine ?: 'V8-10'
 
 def DIST_PATH = "$rootDir/dist_${jsEngine.toLowerCase()}"
 def TEST_APP_PATH = "$rootDir/test-app"
@@ -409,6 +409,7 @@ task createNpmPackage(type: Exec) {
 generateSbgJar.dependsOn(generateDtsgJar)
 generateSbgJar.dependsOn(jsParserNPMInstall)
 generateMdgJar.dependsOn(generateSbgJar)
+buildJsParser.dependsOn(jsParserNPMInstall)
 createDistDir.dependsOn(generateMdgJar)
 
 getPackageVersion.dependsOn(createDistDir)

package.json

@@ -26,7 +26,8 @@
   },
   "scripts": {
     "changelog": "conventional-changelog -p angular -i CHANGELOG.md -s",
-    "version": "npm run changelog && git add CHANGELOG.md"
+    "version": "npm run changelog && git add CHANGELOG.md",
+    "build": "node ./scripts/build.js"
   },
   "devDependencies": {
     "conventional-changelog-cli": "^2.1.1",

scripts/build.js

@@ -0,0 +1,156 @@
+#!/usr/bin/env node
+// Simple build helper for NativeScript Android runtime.
+// Supports interactive prompts or direct CLI flags.
+// See README in the repo for Gradle usage.
+
+const { spawn } = require('child_process');
+const path = require('path');
+const readline = require('readline');
+
+const VALID_ENGINES = ['V8-10',"V8-11","V8-13", 'QUICKJS', 'HERMES', 'JSC', 'SHERMES', 'PRIMJS'];
+const HOST_OBJECTS_SUPPORTED = new Set(['V8-10','V8-11',"V8-13", 'QUICKJS', 'PRIMJS']);
+
+function parseArgs(argv) {
+  const opts = {};
+  argv.forEach(arg => {
+    if (!arg.startsWith('--')) return;
+    const eq = arg.indexOf('=');
+    if (eq !== -1) {
+      const k = arg.slice(2, eq);
+      const v = arg.slice(eq + 1);
+      opts[k] = v;
+    } else {
+      const k = arg.slice(2);
+      // flag -> boolean true
+      opts[k] = true;
+    }
+  });
+  return opts;
+}
+
+async function prompt(question, rl, defaultVal) {
+  return new Promise(resolve => {
+    const q = defaultVal ? `${question} (${defaultVal}) ` : `${question} `;
+    rl.question(q, ans => {
+      if (!ans && typeof defaultVal !== 'undefined') return resolve(defaultVal);
+      resolve(ans);
+    });
+  });
+}
+
+async function interactiveFill(opts) {
+  const rl = readline.createInterface({ input: process.stdin, output: process.stdout });
+  try {
+    // If skip-all-args is given, only ask for engine and host-objects (when supported).
+    if (opts['skip-all-args']) {
+      if (!opts.engine) {
+        console.log('Select JS engine:');
+        VALID_ENGINES.forEach((e, i) => console.log(`  ${i + 1}) ${e}`));
+        const ans = await prompt('Choose number or name', rl, 'V8-10');
+        const pick = /^\d+$/.test(ans) ? VALID_ENGINES[Number(ans) - 1] : ans;
+        opts.engine = VALID_ENGINES.includes(pick) ? pick : 'V8-10';
+      }
+
+      // Only prompt for host objects if the chosen engine supports it
+      if (HOST_OBJECTS_SUPPORTED.has(opts.engine)) {
+        if (typeof opts['use-host-objects'] === 'undefined') {
+          const ans = await prompt('Use host objects? [y/N]', rl, 'N');
+          if (/^y(es)?$/i.test(ans)) opts['use-host-objects'] = true;
+        }
+      } else {
+        // ensure the flag is not set for unsupported engines
+        if (opts['use-host-objects']) {
+          console.log(`Warning: host objects not supported for engine ${opts.engine}; ignoring --use-host-objects`);
+          delete opts['use-host-objects'];
+        }
+      }
+
+      return opts;
+    }
+
+    // original interactive flow (unchanged) when not skipping all args
+    if (!opts.engine) {
+      console.log('Select JS engine:');
+      VALID_ENGINES.forEach((e, i) => console.log(`  ${i + 1}) ${e}`));
+      const ans = await prompt('Choose number or name', rl, 'V8');
+      const pick = /^\d+$/.test(ans) ? VALID_ENGINES[Number(ans) - 1] : ans;
+      opts.engine = VALID_ENGINES.includes(pick) ? pick : 'V8';
+    }
+
+    const booleanPrompts = [
+      { key: 'use-host-objects', prop: 'useHostObjects', desc: 'Use host objects (useHostObjects)' },
+    ];
+
+    for (const p of booleanPrompts) {
+      // skip host-objects prompt if the selected engine does not support it
+      if (p.key === 'use-host-objects' && !HOST_OBJECTS_SUPPORTED.has(opts.engine)) {
+        if (opts['use-host-objects']) {
+          console.log(`Warning: host objects not supported for engine ${opts.engine}; ignoring --use-host-objects`);
+          delete opts['use-host-objects'];
+        }
+        continue;
+      }
+
+      if (typeof opts[p.key] === 'undefined') {
+        const ans = await prompt(`${p.desc}? [y/N]`, rl, 'N');
+        if (/^y(es)?$/i.test(ans)) opts[p.key] = true;
+      }
+    }
+
+  } finally {
+    rl.close();
+  }
+
+  return opts;
+}
+
+function buildGradleArgs(opts) {
+  const props = [];
+  if (opts.engine) props.push(`-Pengine=${opts.engine}`);
+  if (opts['use-host-objects']) props.push('-PuseHostObjects');
+  if (opts['as-napi-module']) props.push('-PasNapiModule');
+
+  return props;
+}
+
+async function main() {
+  const initial = parseArgs(process.argv.slice(2));
+  const opts = await interactiveFill(initial);
+
+  const gradleProps = buildGradleArgs(opts);
+  const gradlew = process.platform === 'win32' ? 'gradlew' : './gradlew';
+  const gradleCmd = [gradlew].concat(gradleProps, []);
+
+  console.log('\nGradle command:');
+  console.log(gradleCmd.join(' '), '\n');
+
+  if (opts['dry-run']) {
+    console.log('Dry run requested. Exiting without executing gradle.');
+    return;
+  }
+
+  const proc = spawn(gradleCmd[0], gradleCmd.slice(1), { stdio: 'inherit', cwd: process.cwd(), shell: false });
+
+  proc.on('exit', code => {
+    if (code === 0) {
+      console.log('\nBuild finished successfully.');
+    } else {
+      console.error(`\nBuild failed with exit code ${code}.`);
+    }
+    process.exit(code);
+  });
+
+  proc.on("message", (message) => {
+    console.log(message);
+  })
+
+  proc.on('error', err => {
+    console.error('Failed to start gradle:', err.message || err);
+    process.exit(1);
+  });
+}
+
+main().catch(err => {
+  console.error('Error:', err && err.message ? err.message : err);
+  process.exit(1);
+});

test-app/app/src/main/assets/app/MyActivity.js

@@ -29,10 +29,8 @@ var MyActivity = (function (_super) {
   MyActivity.prototype.onCreate = function (bundle) {
     _super.prototype.onCreate.call(this, bundle);
     require('./tests/testsWithContext').run(this);
-
     //run jasmine
     execute();
-
     var layout = new android.widget.LinearLayout(this);
     layout.setOrientation(1);
     this.setContentView(layout);

test-app/app/src/main/assets/app/mainpage.js

@@ -71,7 +71,7 @@ require("./tests/kotlin/properties/testPropertiesSupport.js");
 require('./tests/testNativeTimers');
 require("./tests/testPostFrameCallback");
 require("./tests/console/logTests.js");
-//require('./tests/testURLImpl.js');
-//require('./tests/testURLSearchParamsImpl.js');
+require('./tests/testURLImpl.js');
+require('./tests/testURLSearchParamsImpl.js');
 
 

test-app/app/src/main/assets/internal/ts_helpers.js

@@ -63,7 +63,7 @@
     if (Parent.__isPrototypeImplementationObject) {
       throw new Error("Can not extend an already extended native object.");
     }
-    
+
     function extend(thiz) {
       var child = thiz.__proto__.__child;
       if (!child.__extended) {
@@ -204,7 +204,7 @@
   }
 
   global.setNativeArrayProp = (target, prop, value, receiver) => {
-     if (typeof prop !== "symbol" && !isNaN(prop)) {
+    if (typeof prop !== "symbol" && !isNaN(prop)) {
       receiver.setValueAtIndex(parseInt(prop), value);
       return true;
     }
@@ -218,7 +218,7 @@
     }
 
     if (prop === Symbol.iterator) {
-      let index = 0;
+      var index = 0;
       const l = target.length;
       return function () {
         return {
@@ -240,7 +240,7 @@
         const values = receiver.getAllValues();
         const result = [];
         const l = target.length;
-        for (let i = 0; i < l; i++) {
+        for (var i = 0; i < l; i++) {
           result.push(callback(values[i], i, target));
         }
         return result;
@@ -258,7 +258,7 @@
       return function (callback) {
         const values = receiver.getAllValues();
         const l = values.length;
-        for (let i = 0; i < l; i++) {
+        for (var i = 0; i < l; i++) {
           callback(values[i], i, target);
         }
       };
@@ -351,7 +351,7 @@
     URL.revokeObjectURL = function (url) {
       BLOB_STORE.delete(url);
     };
-    const InternalAccessor = class {};
+    function InternalAccessor() {}
     InternalAccessor.getData = function (url) {
       return BLOB_STORE.get(url);
     };

test-app/gradle.properties

@@ -1,4 +1,5 @@
-#Thu, 30 Oct 2025 19:35:13 +0500
+#Thu, 30 Oct 2025 18:27:02 +0500
+
 # Project-wide Gradle settings.
 
 # IDE (e.g. Android Studio) users: