fix: call JSEnter before invoking timer callbacks

Author: ammarahm-ed

test-app/runtime/src/main/cpp/runtime/exceptions/NativeScriptException.cpp

@@ -62,6 +62,8 @@ void NativeScriptException::ReThrowToNapi(napi_env env) {
     }
 
     napi_throw(env, errObj);
+
+//    JSLeave
 }
 
 void NativeScriptException::ReThrowToJava(napi_env env) {
@@ -198,7 +200,8 @@ napi_value NativeScriptException::GetJavaExceptionFromEnv(napi_env env, const Jn
 
     napi_value msg = ArgConverter::convertToJsString(env, errMsg);
     napi_value errObj;
-    napi_create_error(env, nullptr, msg, &errObj);
+    napi_value code = ArgConverter::convertToJsString(env, "0", 1);
+    napi_create_error(env, code, msg, &errObj);
 
     jint javaObjectID = objectManager->GetOrCreateObjectId((jobject)exc);
     auto nativeExceptionObject = objectManager->GetJsObjectByJavaObject(javaObjectID);

test-app/runtime/src/main/cpp/runtime/timers/Timers.cpp

@@ -279,6 +279,7 @@ int Timers::PumpTimerLoopCallback(int fd, int events, void *data) {
 
     auto it = thiz->timerMap_.find(timerId);
     if (it != thiz->timerMap_.end()) {
+        JSEnter
         auto task = it->second;
         // task is no longer in queue to be executed
         task->queued_ = false;
@@ -292,6 +293,7 @@ int Timers::PumpTimerLoopCallback(int fd, int events, void *data) {
             thiz->addTask(task);
         }
 
+
         napi_value cb = napi_util::get_ref_value(env, task->callback_);
         size_t argc = task->args_ == nullptr ? 0 : task->args_->size();
         if (argc > 0) {
@@ -318,6 +320,8 @@ int Timers::PumpTimerLoopCallback(int fd, int events, void *data) {
             napi_delete_reference(env, task->thisArg);
         }
 
+        JSLeave
+
         thiz->nesting = 0;
     }
     thiz->bufferFull.notify_one();