feat: handling pointer types wip

Author: NathanWalker

NativeScript/ffi/ClassMember.mm

@@ -318,7 +318,7 @@ inline id assertSelf(napi_env env, napi_value jsThis) {
     }
   }
 
-  // NSLog(@"objcNativeCall: %p, %@", self, NSStringFromSelector(method->methodOrGetter.selector));
+   NSLog(@"objcNativeCall: %p, %@", self, NSStringFromSelector(method->methodOrGetter.selector));
 
   if (!objcNativeCall(env, cif, self, avalues, rvalue)) {
     return nullptr;

NativeScript/ffi/Interop.mm

@@ -540,12 +540,17 @@ napi_value interop_bufferFromData(napi_env env, napi_callback_info info) {
 }
 
 napi_value Pointer::create(napi_env env, void* data) {
+  if (data == nullptr) {
+    printf("Pointer::create called with null data\n");
+    return nullptr;
+  }
   ObjCBridgeState* bridgeState = ObjCBridgeState::InstanceData(env);
   bool isInstance = false;
   napi_value jsPointer = get_ref_value(env, bridgeState->pointerClass);
   napi_value result;
   napi_new_instance(env, jsPointer, 0, nullptr, &result);
   Pointer* ptr = Pointer::unwrap(env, result);
+  
   ptr->data = data;
   return result;
 }

NativeScript/ffi/TypeConv.mm

@@ -13,6 +13,7 @@
 #include "node_api_util.h"
 
 #import <Foundation/Foundation.h>
+#import <CoreFoundation/CoreFoundation.h>
 #include <objc/runtime.h>
 #include <stdbool.h>
 #include <memory>
@@ -531,6 +532,40 @@ void toNative(napi_env env, napi_value value, void* result, bool* shouldFree,
         return;
       }
 
+      case napi_string: {
+        size_t len = 0;
+        NAPI_GUARD(napi_get_value_string_utf8(env, value, nullptr, len, &len)) {
+          NAPI_THROW_LAST_ERROR
+          return;
+        }
+
+        char* str = (char*)malloc(len + 1);
+
+        NAPI_GUARD(napi_get_value_string_utf8(env, value, str, len + 1, &len)) {
+          NAPI_THROW_LAST_ERROR
+          ::free(str);
+          return;
+        }
+
+        str[len] = '\0';
+
+        // Check if we need to create a CFStringRef instead of a C string
+        // if (pointeeType && pointeeType->kind == mdTypeNSStringObject) {
+          // Create CFStringRef for CF/NS string pointers
+          CFStringRef cfStr = CFStringCreateWithCString(kCFAllocatorDefault, str, kCFStringEncodingUTF8);
+          ::free(str);  // Free the temporary C string
+          *res = (void*)cfStr;
+          *shouldFree = false;  // CFStringRef is reference counted, don't use free()
+          *shouldFreeAny = false;
+        // } else {
+        //   // Default behavior: return C string
+        //   *res = (void*)str;
+        //   *shouldFree = true;
+        //   *shouldFreeAny = true;
+        // }
+        return;
+      }
+
       case napi_external: {
         NAPI_GUARD(napi_get_value_external(env, value, res)) {
           NAPI_THROW_LAST_ERROR
@@ -590,12 +625,26 @@ void toNative(napi_env env, napi_value value, void* result, bool* shouldFree,
       }
 
       default:
+            NSLog(@"value %d", type);
         napi_throw_error(env, nullptr, "Invalid pointer type");
         *res = nullptr;
         return;
     }
   }
 
+  void free(napi_env env, void* value) override {
+    if (pointeeType && pointeeType->kind == mdTypeNSStringObject) {
+      // CFStringRef needs CFRelease, not free()
+      CFStringRef cfStr = (CFStringRef)value;
+      if (cfStr != nullptr) {
+        CFRelease(cfStr);
+      }
+    } else {
+      // Default behavior for C strings
+      ::free(value);
+    }
+  }
+
   void encode(std::string* encoding) override { *encoding += "^v"; }
 };
 
@@ -941,6 +990,20 @@ void toNative(napi_env env, napi_value value, void* result, bool* shouldFree,
         status = napi_unwrap(env, value, (void**)res);
 
         if (status != napi_ok) {
+          // Check if this is a Pointer instance and use its underlying data
+          if (Pointer::isInstance(env, value)) {
+            Pointer* ptr = Pointer::unwrap(env, value);
+            *res = (id)ptr->data;
+            return;
+          }
+
+          // Check if this is a Reference instance and use its underlying data
+          if (Reference::isInstance(env, value)) {
+            Reference* ref = Reference::unwrap(env, value);
+            *res = (id)ref->data;
+            return;
+          }
+
           bool isArray = false;
           napi_is_array(env, value, &isArray);
           if (isArray) {

README.md

@@ -1,5 +1,9 @@
 # Getting Started
 
+**Prerequisites**:
+- Download v8 static libraries from here:
+  - Create a `Frameworks` folder at the root. Unzip and move the `v8_ios` folder inside so they are at `Frameworks/v8_ios`.
+
 To start diving into the v8 iOS runtime make sure you have Xcode and [Homebrew](https://brew.sh/) installed, and then run the following
 ```bash
 # Install CMake