getting closer to a foolproof build_all_react_native.sh

Author: shirakaba

build_all_ios.sh

@@ -1,14 +1,26 @@
 #!/bin/bash
 set -e
+source "$(dirname "$0")/build_utils.sh"
 
 TARGET_ENGINE=${TARGET_ENGINE:=some}
+BUILD_IPHONE=$(to_bool ${BUILD_IPHONE:=true})
+BUILD_SIMULATOR=$(to_bool ${BUILD_SIMULATOR:=true})
+BUILD_MACOS=$(to_bool ${BUILD_MACOS:=false})
+EMBED_METADATA=$(to_bool ${EMBED_METADATA:=false})
 
 # See build_nativescript.sh for all supported flags. This parent script is only
 # interested in intercepting --no-engine.
 for arg in $@; do
   case $arg in
     --v8|--quickjs|--jsc|--hermes) TARGET_ENGINE=some ;;
+    --sim|--simulator) BUILD_SIMULATOR=true ;;
+    --no-sim|--no-simulator) BUILD_SIMULATOR=false ;;
+    --iphone|--device) BUILD_IPHONE=true ;;
+    --no-iphone|--no-device) BUILD_IPHONE=false ;;
+    --macos) BUILD_MACOS=true ;;
+    --no-macos) BUILD_MACOS=false ;;
     --no-engine) TARGET_ENGINE=none ;;
+    --embed-metadata) EMBED_METADATA=true ;;
     *) ;;
   esac
 done
@@ -20,6 +32,26 @@ rm -rf ./dist
   # ./update_version.sh
 # fi
 ./build_metadata_generator.sh
+
+if $EMBED_METADATA; then
+  checkpoint "Generating metadata, as --embed-metadata was passed..."
+
+  if $BUILD_IPHONE; then
+    checkpoint "Generating metadata for iOS (physical device)..."
+    npm run metagen ios
+  fi
+  if $BUILD_SIMULATOR; then
+    checkpoint "Generating metadata for iOS (simulator)..."
+    npm run metagen ios-sim
+  fi
+  if $BUILD_MACOS; then
+    checkpoint "Generating metadata for macOS..."
+    npm run metagen macos
+  fi
+
+  checkpoint "... All metadata generated!"
+fi
+
 ./build_nativescript.sh --no-vision $1 $2 $3 $4 $5 $6 $7 $8 $9
 
 if [[ "$TARGET_ENGINE" == "none" ]]; then

build_all_react_native.sh

@@ -1,3 +1,21 @@
 #!/bin/bash
 
+# Remember to run:
+#
+# $ npm run metagen ios-sim
+# metadata-generator/metadata/metadata.ios-sim.arm64.h
+# metadata-generator/metadata/metadata.ios-sim.arm64.nsmd
+# metadata-generator/metadata/metadata.ios-sim.x86_64.h
+# metadata-generator/metadata/metadata.ios-sim.x86_64.nsmd
+#
+# $ npm run metagen ios
+# metadata-generator/metadata/metadata.ios.arm64.h
+# metadata-generator/metadata/metadata.ios.arm64.nsmd
+#
+# $ npm run metagen macos
+# metadata-generator/metadata/metadata.macos.arm64.h
+# metadata-generator/metadata/metadata.macos.arm64.nsmd
+# metadata-generator/metadata/metadata.macos.x86_64.h
+# metadata-generator/metadata/metadata.macos.x86_64.nsmd
+
 ./build_all_ios.sh --no-engine --embed-metadata --macos

build_nativescript.sh

@@ -157,32 +157,36 @@ if $BUILD_VISION; then
 fi
 
 if [[ -n "${XCFRAMEWORKS[@]}" ]]; then
-
-
-if [[ "$TARGET_ENGINE" == "none" ]]; then
-  checkpoint "Creating the XCFramework (NativeScript.apple.node)"
-
-  # We adhere to the prebuilds standard as described here:
-  # https://github.com/callstackincubator/react-native-node-api/blob/9b231c14459b62d7df33360f930a00343d8c46e6/docs/PREBUILDS.md
-  OUTPUT_DIR="packages/ios/build/$CONFIG_BUILD/NativeScript.apple.node"
-  rm -rf $OUTPUT_DIR
-  deno run -A ./scripts/build_xcframework.mts --output "$OUTPUT_DIR" ${XCFRAMEWORKS[@]}
-else
-  checkpoint "Creating NativeScript.xcframework"
-
-  OUTPUT_DIR="$DIST/NativeScript.xcframework"
-  rm -rf $OUTPUT_DIR
-  xcodebuild -create-xcframework ${XCFRAMEWORKS[@]} -output "$OUTPUT_DIR"
-fi
-
+  if [[ "$TARGET_ENGINE" == "none" ]]; then
+    checkpoint "Creating the XCFramework for iOS (NativeScript.apple.node)"
+
+    # We adhere to the prebuilds standard as described here:
+    # https://github.com/callstackincubator/react-native-node-api/blob/9b231c14459b62d7df33360f930a00343d8c46e6/docs/PREBUILDS.md
+    OUTPUT_DIR="packages/ios/build/$CONFIG_BUILD/NativeScript.apple.node"
+    rm -rf $OUTPUT_DIR
+    deno run -A ./scripts/build_xcframework.mts --output "$OUTPUT_DIR" ${XCFRAMEWORKS[@]}
+  else
+    checkpoint "Creating NativeScript.xcframework"
+
+    OUTPUT_DIR="$DIST/NativeScript.xcframework"
+    rm -rf $OUTPUT_DIR
+    xcodebuild -create-xcframework ${XCFRAMEWORKS[@]} -output "$OUTPUT_DIR"
+  fi
 fi
 
 if $BUILD_MACOS; then
-
-checkpoint "Creating NativeScript.node"
-
-cp -r "$DIST/intermediates/macos/$CONFIG_BUILD/libNativeScript.dylib" "$DIST/NativeScript.node"
-
+  if [[ "$TARGET_ENGINE" == "none" ]]; then
+    checkpoint "Creating the XCFramework for macOS (NativeScript.apple.node)"
+
+    # We adhere to the prebuilds standard as described here:
+    # https://github.com/callstackincubator/react-native-node-api/blob/9b231c14459b62d7df33360f930a00343d8c46e6/docs/PREBUILDS.md
+    OUTPUT_DIR="packages/macos/build/$CONFIG_BUILD/NativeScript.apple.node"
+    rm -rf $OUTPUT_DIR
+    deno run -A ./scripts/build_xcframework.mts --output "$OUTPUT_DIR" ${XCFRAMEWORKS[@]}
+  else
+    checkpoint "Creating NativeScript.node for macOS"
+    cp -r "$DIST/intermediates/macos/$CONFIG_BUILD/libNativeScript.dylib" "$DIST/NativeScript.node"
+  fi
 fi
 
 if $BUILD_MACOS_CLI; then

scripts/build_xcframework.mts

@@ -39,6 +39,8 @@ async function main() {
 Typical usage:
 
 $ deno run -A ./scripts/build_xcframework.mts --output packages/ios/build/Release/NativeScript.apple.node -framework dist/intermediates/ios/RelWithDebInfo-iphoneos/NativeScript.framework -debug-symbols dist/intermediates/ios/RelWithDebInfo-iphoneos/NativeScript.framework.dSYM
+
+$ deno run -A ./scripts/build_xcframework.mts --output packages/macos/build/Release/NativeScript.apple.node -framework dist/intermediates/macos/RelWithDebInfo/NativeScript.framework -debug-symbols dist/intermediates/macos/RelWithDebInfo/NativeScript.framework.dSYM
 `.trim();
 
   if (help) {