Skip to content

Commit 34f5f99

Browse files
authored
release: cut the 8.20.3 release (#2071)
* fix: add router-extensions export to compat dep * fix: export file name casing * fix: add appium tests fix * fix: replace tests images * release: cut the 8.20.3 release
1 parent 1de481c commit 34f5f99

33 files changed

+152
-81
lines changed

CHANGELOG.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
1+
<a name="8.20.3"></a>
2+
## [8.20.3](https://github.com/NativeScript/nativescript-angular/compare/8.20.2...8.20.3) (2019-11-13)
3+
4+
5+
### Bug Fixes
6+
7+
* add exports for backwards compatibility ([fbd46c1](https://github.com/NativeScript/nativescript-angular/commit/fbd46c1))
8+
19
<a name="8.20.2"></a>
2-
## [8.20.2](https://github.com/NativeScript/nativescript-angular/compare/8.20.0...8.20.2) (2019-11-12)
10+
## [8.20.2](https://github.com/NativeScript/nativescript-angular/compare/8.20.1...8.20.2) (2019-11-12)
311

412

513
### Bug Fixes
-712 Bytes
Loading
-1.09 KB
Loading
-712 Bytes
Loading
-789 Bytes
Loading

e2e/animation-examples/e2e/smoke.e2e-spec.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import { AnimationsWithDefaultOptionsPage } from "./pages/animations-with-defaul
1010
import { AnimateChildPage } from "./pages/animate-child-page";
1111
import { HeroPage } from "./pages/hero-page";
1212
import { isSauceLab } from "nativescript-dev-appium/lib/parser";
13+
import { ImageOptions } from "nativescript-dev-appium/lib/image-options";
1314

1415
const QUEUE_WAIT_TIME: number = 600000; // Sometimes SauceLabs threads are not available and the tests wait in a queue to start. Wait 10 min before timeout.
1516
const isSauceRun = isSauceLab;
@@ -21,6 +22,8 @@ describe("smoke-tests", async function () {
2122
this.timeout(QUEUE_WAIT_TIME);
2223
nsCapabilities.testReporter.context = this;
2324
driver = await createDriver();
25+
driver.imageHelper.defaultTolerance = 50;
26+
driver.imageHelper.defaultToleranceType = ImageOptions.pixel;
2427
});
2528

2629
after(async function () {
@@ -145,16 +148,16 @@ describe("smoke-tests", async function () {
145148
const heroPage = new HeroPage(driver);
146149
await heroPage.enterExample();
147150
await heroPage.addActive();
148-
let result = await driver.compareScreen("add_active_items", 5, 0.01);
151+
let result = await driver.compareScreen("add_active_items", 5);
149152

150153
await heroPage.addInactive();
151-
result = await driver.compareScreen("add_inactive_items", 5, 0.01) && result;
154+
result = await driver.compareScreen("add_inactive_items", 5) && result;
152155

153156
await heroPage.remove();
154-
result = await driver.compareScreen("add_remove_items", 5, 0.01) && result;
157+
result = await driver.compareScreen("add_remove_items", 5) && result;
155158

156159
await heroPage.reset();
157-
result = await driver.compareScreen("add_reset_items", 5, 0.01) && result;
160+
result = await driver.compareScreen("add_reset_items", 5) && result;
158161

159162
assert.isTrue(result, "Image verification failed!");
160163

e2e/modal-navigation-ng/e2e/modal-frame.e2e-spec.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
testDialogBackground
1111
} from "./screens/shared-screen";
1212
import { isSauceLab } from "nativescript-dev-appium/lib/parser";
13+
import { ImageOptions } from "nativescript-dev-appium/lib/image-options";
1314

1415
const QUEUE_WAIT_TIME: number = 600000; // Sometimes SauceLabs threads are not available and the tests wait in a queue to start. Wait 10 min before timeout.
1516
const isSauceRun = isSauceLab;
@@ -23,6 +24,8 @@ describe("modal-frame:", async function () {
2324
this.timeout(QUEUE_WAIT_TIME);
2425
nsCapabilities.testReporter.context = this;
2526
driver = await createDriver();
27+
driver.imageHelper.defaultTolerance = 50;
28+
driver.imageHelper.defaultToleranceType = ImageOptions.pixel;
2629
screen = new Screen(driver);
2730
});
2831

e2e/modal-navigation-ng/e2e/modal-layout.e2e-spec.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import {
66
testDialogBackground,
77
} from "./screens/shared-screen";
88
import { isSauceLab } from "nativescript-dev-appium/lib/parser";
9+
import { ImageOptions } from "nativescript-dev-appium/lib/image-options";
910

1011
const QUEUE_WAIT_TIME: number = 600000; // Sometimes SauceLabs threads are not available and the tests wait in a queue to start. Wait 10 min before timeout.
1112
const isSauceRun = isSauceLab;
@@ -18,6 +19,8 @@ describe("modal-layout:", async function () {
1819
this.timeout(QUEUE_WAIT_TIME);
1920
nsCapabilities.testReporter.context = this;
2021
driver = await createDriver();
22+
driver.imageHelper.defaultTolerance = 50;
23+
driver.imageHelper.defaultToleranceType = ImageOptions.pixel;
2124
screen = new Screen(driver);
2225
});
2326

e2e/modal-navigation-ng/e2e/modal-on-init.e2e-spec.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import {
66
navigateToSecondComponent
77
} from "./screens/shared-screen";
88
import { isSauceLab } from "nativescript-dev-appium/lib/parser";
9+
import { ImageOptions } from "nativescript-dev-appium/lib/image-options";
910

1011
const roots = [
1112
"setTabRootViewModal",
@@ -24,6 +25,8 @@ describe("modal-on-init:", async function () {
2425
nsCapabilities.testReporter.context = this;
2526

2627
driver = await createDriver();
28+
driver.imageHelper.defaultTolerance = 50;
29+
driver.imageHelper.defaultToleranceType = ImageOptions.pixel;
2730
screen = new Screen(driver);
2831
});
2932

e2e/modal-navigation-ng/e2e/modal.shared.e2e-spec.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { AppiumDriver, createDriver, nsCapabilities } from "nativescript-dev-app
22
import { Screen } from "./screens/screen";
33
import { assertComponent, goBack, navigateToSecondComponent } from "./screens/shared-screen";
44
import { isSauceLab } from "nativescript-dev-appium/lib/parser";
5+
import { ImageOptions } from "nativescript-dev-appium/lib/image-options";
56

67
const homeComponent = "Home Component";
78
const roots = ["setFrameRootView", "setTabRootView"];
@@ -16,6 +17,8 @@ describe("modal-shared:", async function () {
1617
this.timeout(QUEUE_WAIT_TIME);
1718
nsCapabilities.testReporter.context = this;
1819
driver = await createDriver();
20+
driver.imageHelper.defaultTolerance = 50;
21+
driver.imageHelper.defaultToleranceType = ImageOptions.pixel;
1922
screen = new Screen(driver);
2023
});
2124

0 commit comments

Comments
 (0)