Skip to content

Commit 72e8baa

Browse files
Zdravko BranzovZdravko Branzov
authored andcommitted
chore: fix renderer tests and images for api22 api27
1 parent 4eacbf1 commit 72e8baa

13 files changed

+29
-22
lines changed

e2e/renderer/.vscode/launch.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,11 @@
1212
"--timeout",
1313
"999999",
1414
"--colors",
15-
"--reuseDevice",
16-
"--runType",
17-
"sim.iPhone7.iOS110",
18-
"${workspaceRoot}/e2e"
15+
"${workspaceRoot}/e2e",
16+
"-a",
17+
"--grep",
18+
"actionBarVisibility 'auto' shows action bars based on page"
19+
1920
],
2021
"internalConsoleOptions": "openOnSessionStart"
2122
}

e2e/renderer/e2e/page-router-outlet.e2e-spec.ts

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,15 @@ describe("page-router-outlet-scenario", async function () {
3838

3939
it("should not hide action bar when hidden by page", async function () {
4040
const hideActionBarButton = await driver.findElementByAutomationText("HideActionBar");
41-
hideActionBarButton.click();
41+
await hideActionBarButton.click();
4242

4343
const screenMatches = await driver.compareScreen("actionBarVisibility-always-hidden", 5);
4444
assert(screenMatches);
4545
});
4646

4747
it("should not do anything when shown action bar by page", async function () {
4848
const showActionBarButton = await driver.findElementByAutomationText("ShowActionBar");
49-
showActionBarButton.click();
49+
await showActionBarButton.click();
5050

5151
const screenMatches = await driver.compareScreen("actionBarVisibility-always-shown", 5);
5252
assert(screenMatches);
@@ -81,15 +81,15 @@ describe("page-router-outlet-scenario", async function () {
8181

8282
it("should not show action bar when shown by page", async function () {
8383
const showActionBarButton = await driver.findElementByAutomationText("ShowActionBar");
84-
showActionBarButton.click();
84+
await showActionBarButton.click();
8585

8686
const screenMatches = await driver.compareScreen("actionBarVisibility-never-shown", 5);
8787
assert(screenMatches);
8888
});
8989

9090
it("should not do anything when hidden action bar by page", async function () {
9191
const hideActionBarButton = await driver.findElementByAutomationText("HideActionBar");
92-
hideActionBarButton.click();
92+
await hideActionBarButton.click();
9393

9494
const screenMatches = await driver.compareScreen("actionBarVisibility-never-hidden", 5);
9595
assert(screenMatches);
@@ -128,15 +128,15 @@ describe("page-router-outlet-scenario", async function () {
128128

129129
it("should not show action bar when shown by page", async function () {
130130
const showActionBarButton = await driver.findElementByAutomationText("ShowActionBar");
131-
showActionBarButton.click();
131+
await showActionBarButton.click();
132132

133133
const screenMatches = await driver.compareScreen(`actionBarVisibility-never-shown${imagePostFix}`, 5);
134134
assert(screenMatches);
135135
});
136136

137137
it("should not do anything when hidden action bar by page", async function () {
138138
const hideActionBarButton = await driver.findElementByAutomationText("HideActionBar");
139-
hideActionBarButton.click();
139+
await hideActionBarButton.click();
140140

141141
const screenMatches = await driver.compareScreen(`actionBarVisibility-never-hidden${imagePostFix}`, 5);
142142
assert(screenMatches);
@@ -171,16 +171,14 @@ describe("page-router-outlet-scenario", async function () {
171171

172172
it("should hide action bar when hidden by page", async function () {
173173
const hideActionBarButton = await driver.findElementByAutomationText("HideActionBar");
174-
hideActionBarButton.click();
175-
174+
await hideActionBarButton.click();
176175
const screenMatches = await driver.compareScreen("actionBarVisibility-auto-hidden", 5);
177176
assert(screenMatches);
178177
});
179178

180179
it("should show action bar when shown by page", async function () {
181180
const showActionBarButton = await driver.findElementByAutomationText("ShowActionBar");
182-
showActionBarButton.click();
183-
181+
await showActionBarButton.click();
184182
const screenMatches = await driver.compareScreen("actionBarVisibility-auto-shown", 5);
185183
assert(screenMatches);
186184
});
320 Bytes
Loading
320 Bytes
Loading
374 Bytes
Loading
823 Bytes
Loading
-4.08 KB
Loading
5.68 KB
Loading
2.87 KB
Loading
-865 Bytes
Loading

0 commit comments

Comments
 (0)