Skip to content

Commit bc03be4

Browse files
author
Vladimir Amiorkov
authored
Merge pull request #1962 from NativeScript/release-8.2.1
Release 8.2.1
2 parents 5a7dc12 + 8d896af commit bc03be4

File tree

89 files changed

+157
-60
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

89 files changed

+157
-60
lines changed

CHANGELOG.md

Lines changed: 10 additions & 0 deletions

e2e/animation-examples/e2e/pages/animation-with-options-page.ts

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,30 +12,33 @@ export class AnimationWithOptionsPage extends BasePage {
1212
async enterExample() {
1313
const exampleBtn = await this._driver.findElementByAccessibilityId("options");
1414
await exampleBtn.click();
15-
this.initialPositionOfAnimatedBtn = await (await this.animatedBtn).location();
15+
const animatedBtn = await this.animatedBtn();
16+
this.initialPositionOfAnimatedBtn = await animatedBtn.location();
1617
}
1718

18-
get btnToggleAnimation() {
19-
return this._driver.findElementByAccessibilityId("toggleAnimation");
19+
async btnToggleAnimation() {
20+
return await this._driver.findElementByAccessibilityId("toggleAnimation");
2021
}
2122

22-
get animatedBtn() {
23-
this._driver.findElementsByAccessibilityId("animatedBtn", 10000);
24-
return this._driver.findElementByAccessibilityIdIfExists("animatedBtn");
23+
async animatedBtn() {
24+
await this._driver.wait(2000);
25+
const btn = await this._driver.findElementByAccessibilityIdIfExists("animatedBtn");
26+
return btn;
2527
}
2628

2729
async toggleAnimation() {
28-
const btnTapToDisappear = await this.btnToggleAnimation;
30+
const btnTapToDisappear = await this.btnToggleAnimation();
2931
await btnTapToDisappear.click();
3032
}
3133

3234
async waitElementToHide() {
33-
return this.waitElementTo(() => this.animatedBtn, false, 10000);
35+
await this._driver.wait(2000);
36+
return await this._driver.findElementByAccessibilityIdIfExists("animatedBtn");
3437
}
3538

3639
async assertPositionOfToggleAnimationBtn() {
37-
this.waitElementTo(() => this.btnToggleAnimation, true, 5000);
38-
const point: Point = await (await this.btnToggleAnimation).location();
40+
await this.waitElementTo(() => this.btnToggleAnimation(), true, 5000);
41+
const point: Point = await (await this.btnToggleAnimation()).location();
3942
assert.isTrue(point.y === this.initialPositionOfAnimatedBtn.y);
4043
}
4144
}
95.3 KB
114 KB
95.7 KB
57.1 KB

0 commit comments

Comments
 (0)