Merge pull request #4600 from NativeScript/tachev/fix-debug-brk-hmr

Dimitar Tachev · web-flow · commit 296dbe9ca83e · 2019-05-08T18:55:03.000+03:00
fix: do not use HMR when debugBrk is set as we will restart the app on each LiveSync
diff --git a/lib/options.ts b/lib/options.ts
@@ -48,6 +48,12 @@ export class Options {
 			this.argv.bundle = undefined;
 			this.argv.hmr = false;
 		}
+
+		if (this.argv.debugBrk) {
+			// we cannot use HMR along with debug-brk because we have to restart the app
+			// on each livesync in order to stop and allow debugging on app start
+			this.argv.hmr = false;
+		}
 	}
 
 	constructor(private $errors: IErrors,

Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,12 @@ export class Options {`
`48`	`48`	`this.argv.bundle = undefined;`
`49`	`49`	`this.argv.hmr = false;`
`50`	`50`	`}`
	`51`	`+`
	`52`	`+ if (this.argv.debugBrk) {`
	`53`	`+ // we cannot use HMR along with debug-brk because we have to restart the app`
	`54`	`+ // on each livesync in order to stop and allow debugging on app start`
	`55`	`+ this.argv.hmr = false;`
	`56`	`+ }`
`51`	`57`	`}`
`52`	`58`
`53`	`59`	`constructor(private $errors: IErrors,`