fix: validate current bundle version from package.json when tns preview --bundle command is executed

Author: Fatme

lib/commands/preview.ts

@@ -1,5 +1,6 @@
 export class PreviewCommand implements ICommand {
 	public allowedParameters: ICommandParameter[] = [];
+	private static MIN_SUPPORTED_WEBPACK_VERSION = "0.17.0";
 
 	constructor(private $bundleValidatorHelper: IBundleValidatorHelper,
 		private $liveSyncService: ILiveSyncService,
@@ -30,7 +31,7 @@ export class PreviewCommand implements ICommand {
 
 	public async canExecute(args: string[]): Promise<boolean> {
 		await this.$networkConnectivityValidator.validate();
-		this.$bundleValidatorHelper.validate();
+		this.$bundleValidatorHelper.validate(PreviewCommand.MIN_SUPPORTED_WEBPACK_VERSION);
 		return true;
 	}
 }

lib/constants.ts

@@ -227,3 +227,8 @@ export class IosProjectConstants {
 	public static XcodeProjExtName = ".xcodeproj";
 	public static XcodeSchemeExtName = ".xcscheme";
 }
+
+export class BundleValidatorMessages {
+	public static MissingBundlePlugin = "Passing --bundle requires a bundling plugin. No bundling plugin found or the specified bundling plugin is invalid.";
+	public static NotSupportedVersion = `The NativeScript CLI requires nativescript-dev-webpack %s or later to work properly.`;
+}

lib/declarations.d.ts

@@ -841,9 +841,11 @@ interface IDeployCommandHelper {
 interface IBundleValidatorHelper {
 	/**
 	 * Validates bundling options.
+	 * In case when minSupportedVersion is provided, gets the current version of nativescript-dev-webpack from package json and compares with the provided version.
+	 * @param {string} minSupportedVersion the minimum supported version of nativescript-dev-webpack
 	 * @return {void}
 	 */
-	validate(): void;
+	validate(minSupportedVersion?: string): void;
 }
 
 interface INativeScriptCloudExtensionService {

lib/helpers/bundle-validator-helper.ts

@@ -1,3 +1,7 @@
+import * as semver from "semver";
+import * as util from "util";
+import { BundleValidatorMessages } from "../constants";
+
 export class BundleValidatorHelper implements IBundleValidatorHelper {
 	private bundlersMap: IStringDictionary = {
 		webpack: "nativescript-dev-webpack"
@@ -9,13 +13,21 @@ export class BundleValidatorHelper implements IBundleValidatorHelper {
 		this.$projectData.initializeProjectData();
 	}
 
-	public validate(): void {
+	public validate(minSupportedVersion?: string): void {
 		if (this.$options.bundle) {
 			const bundlePluginName = this.bundlersMap[this.$options.bundle];
 			const hasBundlerPluginAsDependency = this.$projectData.dependencies && this.$projectData.dependencies[bundlePluginName];
 			const hasBundlerPluginAsDevDependency = this.$projectData.devDependencies && this.$projectData.devDependencies[bundlePluginName];
 			if (!bundlePluginName || (!hasBundlerPluginAsDependency && !hasBundlerPluginAsDevDependency)) {
-				this.$errors.fail("Passing --bundle requires a bundling plugin. No bundling plugin found or the specified bundling plugin is invalid.");
+				this.$errors.fail(BundleValidatorMessages.MissingBundlePlugin);
+			}
+
+			if (minSupportedVersion) {
+				const currentVersion = hasBundlerPluginAsDependency || hasBundlerPluginAsDevDependency;
+				const isBundleSupported = semver.gte(semver.coerce(currentVersion), semver.coerce(minSupportedVersion));
+				if (!isBundleSupported) {
+					this.$errors.fail(util.format(BundleValidatorMessages.NotSupportedVersion, minSupportedVersion));
+				}
 			}
 		}
 	}