Skip to content

Commit 35e27bd

Browse files
committed
Merge pull request #802 from NativeScript/totev/app
Warn users when creating applications named 'app'.
2 parents 01e45ff + e07b8e2 commit 35e27bd

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

lib/commands/create-project.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
export class ProjectCommandParameter implements ICommandParameter {
55
constructor(private $errors: IErrors,
6+
private $logger: ILogger,
67
private $projectNameValidator: IProjectNameValidator) { }
78

89
mandatory = true;
@@ -12,6 +13,10 @@ export class ProjectCommandParameter implements ICommandParameter {
1213
this.$errors.fail("You must specify <App name> when creating a new project.");
1314
}
1415

16+
if (value.toUpperCase() === "APP") {
17+
this.$logger.warn("You cannot build aplications named 'app' in Xcode. Consider creating a project with different name.");
18+
}
19+
1520
return this.$projectNameValidator.validate(value);
1621
}).future<boolean>()();
1722
}
@@ -20,6 +25,7 @@ export class ProjectCommandParameter implements ICommandParameter {
2025
export class CreateProjectCommand implements ICommand {
2126
constructor(private $projectService: IProjectService,
2227
private $errors: IErrors,
28+
private $logger: ILogger,
2329
private $projectNameValidator: IProjectNameValidator) { }
2430

2531
public enableHooks = false;
@@ -30,6 +36,6 @@ export class CreateProjectCommand implements ICommand {
3036
}).future<void>()();
3137
}
3238

33-
allowedParameters = [new ProjectCommandParameter(this.$errors, this.$projectNameValidator) ]
39+
allowedParameters = [new ProjectCommandParameter(this.$errors, this.$logger, this.$projectNameValidator) ]
3440
}
3541
$injector.registerCommand("create", CreateProjectCommand);

0 commit comments

Comments
 (0)