Merge pull request #1981 from NativeScript/KristinaKoeva/ProcessEventHandlers

Use the new processService for destroying the live sync socket

Author: KristinaKoeva

lib/services/livesync/ios-device-livesync-service.ts

@@ -19,7 +19,8 @@ class IOSLiveSyncService implements IDeviceLiveSyncService {
 		private $iOSDebugService: IDebugService,
 		private $childProcess: IChildProcess,
 		private $fs: IFileSystem,
-		private $liveSyncProvider: ILiveSyncProvider) {
+		private $liveSyncProvider: ILiveSyncProvider,
+		private $processService: IProcessService) {
 		this.device = <Mobile.IiOSDevice>(_device);
 	}
 
@@ -137,7 +138,7 @@ class IOSLiveSyncService implements IDeviceLiveSyncService {
 	}
 
 	private attachEventHandlers(): void {
-		this.attachProcessExitHandlers();
+		this.$processService.attachToProcessExitSignals(this, this.destroySocket);
 
 		this.socket.on("close", (hadError: boolean) => {
 			this.$logger.trace(`Socket closed, hadError is ${hadError}.`);
@@ -184,21 +185,6 @@ class IOSLiveSyncService implements IDeviceLiveSyncService {
 		}).future<void>()();
 	}
 
-	private attachProcessExitHandlers(): void {
-		process.on("exit", (exitCode: number) => {
-			this.destroySocket();
-		});
-
-		process.on("SIGTERM", () => {
-			this.destroySocket();
-		});
-
-		process.on("SIGINT", () => {
-			this.destroySocket();
-			return process.exit();
-		});
-	}
-
 	private destroySocket(): void {
 		if(this.socket) {
 			this.socket.destroy();

lib/services/livesync/livesync-service.ts

@@ -24,7 +24,8 @@ class LiveSyncService implements ILiveSyncService {
 		private $options: IOptions,
 		private $logger: ILogger,
 		private $dispatcher: IFutureDispatcher,
-		private $hooksService: IHooksService) { }
+		private $hooksService: IHooksService,
+		private $processService: IProcessService) { }
 
 	private ensureAndroidFrameworkVersion(platformData: IPlatformData): IFuture<void> { // TODO: this can be moved inside command or canExecute function
 		return (() => {
@@ -130,7 +131,7 @@ class LiveSyncService implements ILiveSyncService {
 	private partialSync(syncWorkingDirectory: string, onChangedActions: ((event: string, filePath: string, dispatcher: IFutureDispatcher) => void )[]): void {
 		let that = this;
 
-		gaze("**/*", { cwd: syncWorkingDirectory }, function (err: any, watcher: any) {
+		let gazeWatcher = gaze("**/*", { cwd: syncWorkingDirectory }, function (err: any, watcher: any) {
 			this.on('all', (event: string, filePath: string) => {
 				fiberBootstrap.run(() => {
 					that.$dispatcher.dispatch(() => (() => {
@@ -147,6 +148,7 @@ class LiveSyncService implements ILiveSyncService {
 			});
 		});
 
+		this.$processService.attachToProcessExitSignals(this, gazeWatcher.close);
 		this.$dispatcher.run();
 	}
 }