Skip to content

Commit 4bb0330

Browse files
author
Dimitar Kerezov
committed
Minor bugfixes
1 parent 4eb8d7f commit 4bb0330

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

lib/declarations.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -487,7 +487,7 @@ interface IiOSNotification {
487487

488488
interface IiOSNotificationService {
489489
awaitNotification(deviceIdentifier: string, socket: number, timeout: number): Promise<string>;
490-
postNotification(deviceIdentifier: string, notification: string, commandType?: string): Promise<string>;
490+
postNotification(deviceIdentifier: string, notification: string, commandType?: string): Promise<number>;
491491
}
492492

493493
interface IiOSSocketRequestExecutor {

lib/services/ios-notification-service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ export class IOSNotificationService implements IiOSNotificationService {
1515
return _.first(notificationResponse[deviceIdentifier]).response;
1616
}
1717

18-
public async postNotification(deviceIdentifier: string, notification: string, commandType?: string): Promise<string> {
18+
public async postNotification(deviceIdentifier: string, notification: string, commandType?: string): Promise<number> {
1919
commandType = commandType || constants.IOS_POST_NOTIFICATION_COMMAND_TYPE;
2020
const response = await this.$iosDeviceOperations.postNotification([{ deviceId: deviceIdentifier, commandType: commandType, notificationName: notification }]);
21-
return _.first(response[deviceIdentifier]).response;
21+
return +_.first(response[deviceIdentifier]).response;
2222
}
2323
}
2424

lib/services/livesync/livesync-service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ export class LiveSyncService extends EventEmitter implements ILiveSyncService {
106106
// TODO: Assure we are able to self-restart iOS apps on Windows.
107107
await platformLiveSyncService.refreshApplication(projectData, liveSyncResultInfo);
108108
} catch (err) {
109-
this.$logger.info(`Error while trying to start application ${projectData.projectId} on device ${liveSyncResultInfo.deviceAppData.device.deviceInfo.identifier}. Error is: ${err}`);
109+
this.$logger.info(`Error while trying to start application ${projectData.projectId} on device ${liveSyncResultInfo.deviceAppData.device.deviceInfo.identifier}. Error is: ${err.message || err}`);
110110
const msg = `Unable to start application ${projectData.projectId} on device ${liveSyncResultInfo.deviceAppData.device.deviceInfo.identifier}. Try starting it manually.`;
111111
this.$logger.warn(msg);
112112
this.emit(LiveSyncEvents.liveSyncNotification, {

lib/services/platform-service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -473,9 +473,9 @@ export class PlatformService extends EventEmitter implements IPlatformService {
473473
let platformData = this.$platformsData.getPlatformData(device.deviceInfo.platform, projectData);
474474
if (!packageFile) {
475475
if (this.$devicesService.isiOSSimulator(device)) {
476-
packageFile = this.getLatestApplicationPackageForEmulator(platformData, buildConfig).packageName;
476+
packageFile = this.getLatestApplicationPackageForEmulator(platformData, buildConfig, outputFilePath).packageName;
477477
} else {
478-
packageFile = this.getLatestApplicationPackageForDevice(platformData, buildConfig).packageName;
478+
packageFile = this.getLatestApplicationPackageForDevice(platformData, buildConfig, outputFilePath).packageName;
479479
}
480480
}
481481

0 commit comments

Comments
 (0)