Merge pull request #814 from NativeScript/tslint

tslint related changes

Author: teobugslayer

.idea/misc.xml

@@ -55,9 +55,20 @@ module.exports = function(grunt) {
 					sourceMap: false,
 					removeComments: true
 				}
-			}
+			},
 		},
-
+		
+		tslint: {
+            build: {
+                files: {
+                    src: ["lib/**/*.ts", "test/**/*.ts", "!lib/common/node_modules/**/*.ts", "lib/common/test/unit-tests/**/*.ts", "definitions/**/*.ts", "!**/*.d.ts"]
+                },
+                options: {
+                    configuration: grunt.file.readJSON("./tslint.json")
+                }
+            }
+        },
+		
 		watch: {
 			devall: {
 				files: ["lib/**/*.ts", 'test/**/*.ts', "!lib/common/node_modules/**/*.ts"],
@@ -119,9 +130,9 @@ module.exports = function(grunt) {
 	grunt.loadNpmTasks("grunt-contrib-watch");
 	grunt.loadNpmTasks("grunt-shell");
 	grunt.loadNpmTasks("grunt-ts");
+	grunt.loadNpmTasks("grunt-tslint");
 
 	grunt.registerTask("set_package_version", function(version) {
-		var fs = require("fs");
 		var buildVersion = version !== undefined ? version : buildNumber;
 		if (process.env["BUILD_CAUSE_GHPRBCAUSE"]) {
 			buildVersion = "PR" + buildVersion;
@@ -150,7 +161,6 @@ module.exports = function(grunt) {
 		grunt.file.write("package.json", JSON.stringify(packageJson, null, "  "));
 	});
 
-
 	grunt.registerTask("test", ["ts:devall", "shell:npm_test"]);
 	grunt.registerTask("pack", [
 		"clean",
@@ -162,6 +172,7 @@ module.exports = function(grunt) {
 		"copy:package_to_drop_folder",
 		"copy:package_to_qa_drop_folder"
 	]);
+	grunt.registerTask("lint", ["tslint:build"]);
 
 	grunt.registerTask("default", "ts:devlib");
 };

Gruntfile.js

@@ -1,8 +1,7 @@
 ///<reference path="../.d.ts"/>
 "use strict";
 
-import path = require("path");
-import Future = require("fibers/future");
+import * as path from "path";
 
 export class AddLibraryCommand implements ICommand {
     constructor(private $platformService: IPlatformService,
@@ -14,8 +13,8 @@ export class AddLibraryCommand implements ICommand {
 
     execute(args: string[]): IFuture<void> {
         return (() => {
-            var platform = args[0];
-            var libraryPath = path.resolve(args[1]);
+            let platform = args[0];
+            let libraryPath = path.resolve(args[1]);
             this.$platformService.addLibrary(platform, libraryPath).wait();
             this.$logger.info(`Library ${libraryPath} was successfully added for ${platform} platform.`);
         }).future<void>()();
@@ -48,4 +47,4 @@ export class AddLibraryCommand implements ICommand {
         }).future<boolean>()();
     }
 }
-$injector.registerCommand("library|add", AddLibraryCommand);
+$injector.registerCommand("library|add", AddLibraryCommand);

lib/commands/add-library.ts

@@ -25,4 +25,4 @@ export class AddPlatformCommand implements ICommand {
 		}).future<boolean>()();
 	}
 }
-$injector.registerCommand("platform|add", AddPlatformCommand);
+$injector.registerCommand("platform|add", AddPlatformCommand);

lib/commands/add-platform.ts

@@ -23,7 +23,6 @@ export class BuildIosCommand extends BuildCommandBase implements  ICommand {
 }
 $injector.registerCommand("build|ios", BuildIosCommand);
 
-
 export class BuildAndroidCommand extends BuildCommandBase implements  ICommand {
 	constructor($platformService: IPlatformService,
 				private $platformsData: IPlatformsData) {

lib/commands/build.ts

@@ -36,6 +36,6 @@ export class CreateProjectCommand implements ICommand {
 		}).future<void>()();
 	}
 
-	allowedParameters = [new ProjectCommandParameter(this.$errors, this.$logger, this.$projectNameValidator) ]
+	allowedParameters = [new ProjectCommandParameter(this.$errors, this.$logger, this.$projectNameValidator) ];
 }
 $injector.registerCommand("create", CreateProjectCommand);

lib/commands/create-project.ts

@@ -1,8 +1,6 @@
 ///<reference path="../.d.ts"/>
 "use strict";
 
-import Future = require("fibers/future");
-
 export class InitCommand implements ICommand {
 	constructor(private $initService: IInitService) { }
 
@@ -13,4 +11,4 @@ export class InitCommand implements ICommand {
 		return this.$initService.initialize();
 	}
 }
-$injector.registerCommand("init", InitCommand);
+$injector.registerCommand("init", InitCommand);

lib/commands/init.ts

@@ -2,8 +2,6 @@
 "use strict";
 
 export class InstallCommand implements ICommand {
-	private _projectData: any;
-	
 	constructor(private $platformsData: IPlatformsData,
 		private $platformService: IPlatformService,
 		private $projectData: IProjectData,
@@ -41,4 +39,4 @@ export class InstallCommand implements ICommand {
 		}).future<void>()();
 	}
 }
-$injector.registerCommand("install", InstallCommand);
+$injector.registerCommand("install", InstallCommand);

lib/commands/install.ts

@@ -2,18 +2,17 @@
 "use strict";
 
 import helpers = require("./../common/helpers");
-import util = require("util")
 
 export class ListPlatformsCommand implements ICommand {
 	constructor(private $platformService: IPlatformService,
 		private $logger: ILogger) { }
 
 	execute(args: string[]): IFuture<void> {
 		return (() => {
-			var installedPlatforms = this.$platformService.getInstalledPlatforms().wait();
+			let installedPlatforms = this.$platformService.getInstalledPlatforms().wait();
 
 			if(installedPlatforms.length > 0) {
-				var preparedPlatforms = this.$platformService.getPreparedPlatforms().wait();
+				let preparedPlatforms = this.$platformService.getPreparedPlatforms().wait();
 				if(preparedPlatforms.length > 0) {
 					this.$logger.out("The project is prepared for: ", helpers.formatListOfNames(preparedPlatforms, "and"));
 				} else {

lib/commands/list-platforms.ts

@@ -30,4 +30,4 @@ export class LivesyncCommand implements ICommand {
 
 	allowedParameters: ICommandParameter[] = [];
 }
-$injector.registerCommand("livesync", LivesyncCommand);
+$injector.registerCommand("livesync", LivesyncCommand);