fix: add clearInterval in timers API

Add clearInterval in timers API, so we can safely remove the cached timers from our internal cache. Without this, we end up calling many clearIntervals for timers that have already been cleared.

Author: rosen-vladimirov

lib/common/definitions/timers.d.ts

@@ -1,3 +1,4 @@
 interface ITimers {
 	setInterval(callback: (...args: any[]) => void, ms: number, ...args: any[]): NodeJS.Timer;
+	clearInterval(intervalId: NodeJS.Timer): void;
 }

lib/common/mobile/mobile-core/devices-service.ts

@@ -10,7 +10,6 @@ import { CONNECTED_STATUS } from "../../constants";
 import { isInteractive } from "../../helpers";
 import { DebugCommandErrors } from "../../../constants";
 import { performanceLog } from "../../decorators";
-import { Timers } from "../../timers";
 
 export class DevicesService extends EventEmitter implements Mobile.IDevicesService {
 	private static DEVICE_LOOKING_INTERVAL = 200;
@@ -44,7 +43,7 @@ export class DevicesService extends EventEmitter implements Mobile.IDevicesServi
 		private $androidEmulatorDiscovery: Mobile.IDeviceDiscovery,
 		private $emulatorHelper: Mobile.IEmulatorHelper,
 		private $prompter: IPrompter,
-		private $timers: Timers) {
+		private $timers: ITimers) {
 		super();
 		this.attachToKnownDeviceDiscoveryEvents();
 		this.attachToKnownEmulatorDiscoveryEvents();
@@ -337,14 +336,14 @@ export class DevicesService extends EventEmitter implements Mobile.IDevicesServi
 	@exported("devicesService")
 	public stopDeviceDetectionInterval(): void {
 		if (this.deviceDetectionInterval) {
-			clearInterval(this.deviceDetectionInterval);
+			this.$timers.clearInterval(this.deviceDetectionInterval);
 		}
 	}
 
 	@exported("devicesService")
 	public stopEmulatorDetectionInterval(): void {
 		if (this.emulatorDetectionInterval) {
-			clearInterval(this.emulatorDetectionInterval);
+			this.$timers.clearInterval(this.emulatorDetectionInterval);
 		}
 	}
 

lib/common/timers.ts

@@ -1,12 +1,25 @@
 export class Timers implements ITimers {
+	private pendingIntervalIds: NodeJS.Timer[] = [];
+
 	constructor(private $processService: IProcessService) {
+		this.$processService.attachToProcessExitSignals(this, () => {
+			_.each(this.pendingIntervalIds, clearInterval);
+		});
 	}
 
 	public setInterval(callback: (...args: any[]) => void, ms: number, ...args: any[]): NodeJS.Timer {
 		const timer = setInterval(callback, ms, args);
-		this.$processService.attachToProcessExitSignals(this, () => clearInterval(timer));
+
+		this.pendingIntervalIds.push(timer);
+
 		return timer;
 	}
+
+	public clearInterval(intervalId: NodeJS.Timer): void {
+		clearInterval(intervalId);
+
+		_.remove(this.pendingIntervalIds, id => id === intervalId);
+	}
 }
 
 $injector.register("timers", Timers);