fix(plugin-build): strip npm scope names from android plugin names

petekanev · Plamen5kov · commit 657f6f405ce3 · 2018-03-13T11:07:57.000+02:00
diff --git a/lib/services/android-plugin-build-service.ts b/lib/services/android-plugin-build-service.ts
@@ -38,7 +38,12 @@ export class AndroidPluginBuildService implements IAndroidPluginBuildService {
 	}
 
 	private getShortPluginName(pluginName: string): string {
-		return pluginName.replace(/[\-]/g, "_");
+		return this.sanitizePluginName(pluginName).replace(/[\-]/g, "_");
+	}
+
+	private sanitizePluginName(pluginName: string): string {
+		// avoid long plugin names, exclude the npm module scope (@scope/nativescript-plugin) from the android plugin name
+		return pluginName.split("/").pop();
 	}
 
 	private async updateManifestContent(oldManifestContent: string, defaultPackageName: string): Promise<string> {

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,12 @@ export class AndroidPluginBuildService implements IAndroidPluginBuildService {`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`private getShortPluginName(pluginName: string): string {`
`41`		`- return pluginName.replace(/[\-]/g, "_");`
	`41`	`+ return this.sanitizePluginName(pluginName).replace(/[\-]/g, "_");`
	`42`	`+ }`
	`43`	`+`
	`44`	`+ private sanitizePluginName(pluginName: string): string {`
	`45`	`+ // avoid long plugin names, exclude the npm module scope (@scope/nativescript-plugin) from the android plugin name`
	`46`	`+ return pluginName.split("/").pop();`
`42`	`47`	`}`
`43`	`48`
`44`	`49`	`private async updateManifestContent(oldManifestContent: string, defaultPackageName: string): Promise<string> {`