Skip to content

Commit 6b3662d

Browse files
rosen-vladimirovDimitar Kerezov
authored andcommitted
Fix unit tests
1 parent 4aafecc commit 6b3662d

9 files changed

+22
-7
lines changed

lib/definitions/livesync.d.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,3 +204,14 @@ interface IAndroidNativeScriptDeviceLiveSyncService {
204204
*/
205205
getDeviceHashService(appIdentifier: string): Mobile.IAndroidDeviceHashService;
206206
}
207+
208+
interface IDeviceProjectRootOptions {
209+
appIdentifier: string;
210+
syncAllFiles?: boolean;
211+
watch?: boolean;
212+
}
213+
214+
interface IDevicePathProvider {
215+
getDeviceBuildInfoDirname(device: Mobile.IDevice, appIdentifier: string): Promise<string>;
216+
getDeviceProjectRootPath(device: Mobile.IDevice, options: IDeviceProjectRootOptions): Promise<string>;
217+
}

lib/device-path-provider.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { IOS_DEVICE_PROJECT_ROOT_PATH, SYNC_DIR_NAME, FULLSYNC_DIR_NAME } from "
33
import { AndroidDeviceLiveSyncService } from "./services/livesync/android-device-livesync-service";
44
import * as path from "path";
55

6-
export class DevicePathProvider implements Mobile.IDevicePathProvider {
6+
export class DevicePathProvider implements IDevicePathProvider {
77
constructor(private $mobileHelper: Mobile.IMobileHelper,
88
private $injector: IInjector,
99
private $iOSSimResolver: Mobile.IiOSSimResolver) {
@@ -20,7 +20,7 @@ export class DevicePathProvider implements Mobile.IDevicePathProvider {
2020
return result;
2121
}
2222

23-
public async getDeviceProjectRootPath(device: Mobile.IDevice, options: Mobile.IDeviceProjectRootOptions): Promise<string> {
23+
public async getDeviceProjectRootPath(device: Mobile.IDevice, options: IDeviceProjectRootOptions): Promise<string> {
2424
let projectRoot = "";
2525
if (this.$mobileHelper.isiOSPlatform(device.deviceInfo.platform)) {
2626
if (device.isEmulator) {

lib/services/livesync/android-livesync-service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export class AndroidLiveSyncService extends PlatformLiveSyncServiceBase implemen
1010
private $projectFilesProvider: IProjectFilesProvider,
1111
private $fs: IFileSystem,
1212
private $injector: IInjector,
13-
$devicePathProvider: Mobile.IDevicePathProvider) {
13+
$devicePathProvider: IDevicePathProvider) {
1414
super($devicePathProvider);
1515
}
1616

lib/services/livesync/ios-livesync-service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export class IOSLiveSyncService extends PlatformLiveSyncServiceBase implements I
1212
private $projectFilesProvider: IProjectFilesProvider,
1313
private $fs: IFileSystem,
1414
private $injector: IInjector,
15-
$devicePathProvider: Mobile.IDevicePathProvider) {
15+
$devicePathProvider: IDevicePathProvider) {
1616
super($devicePathProvider);
1717
}
1818

lib/services/livesync/platform-livesync-service-base.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
export class PlatformLiveSyncServiceBase {
22
constructor(
3-
private $devicePathProvider: Mobile.IDevicePathProvider,
3+
private $devicePathProvider: IDevicePathProvider,
44
) {
55
}
66

77
protected async getAppData(syncInfo: IFullSyncInfo): Promise<Mobile.IDeviceAppData> {
8-
const deviceProjectRootOptions: Mobile.IDeviceProjectRootOptions = _.assign({ appIdentifier: syncInfo.projectData.projectId }, syncInfo);
8+
const deviceProjectRootOptions: IDeviceProjectRootOptions = _.assign({ appIdentifier: syncInfo.projectData.projectId }, syncInfo);
99
return {
1010
appIdentifier: syncInfo.projectData.projectId,
1111
device: syncInfo.device,

lib/services/platform-service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export class PlatformService extends EventEmitter implements IPlatformService {
3434
private $projectFilesManager: IProjectFilesManager,
3535
private $mobileHelper: Mobile.IMobileHelper,
3636
private $hostInfo: IHostInfo,
37-
private $devicePathProvider: Mobile.IDevicePathProvider,
37+
private $devicePathProvider: IDevicePathProvider,
3838
private $xmlValidator: IXmlValidator,
3939
private $npm: INodePackageManager,
4040
private $devicePlatformsConstants: Mobile.IDevicePlatformsConstants,

test/npm-support.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ function createTestInjector(): IInjector {
8585
testInjector.register("messages", Messages);
8686
testInjector.register("nodeModulesDependenciesBuilder", NodeModulesDependenciesBuilder);
8787

88+
testInjector.register("devicePathProvider", {});
89+
8890
return testInjector;
8991
}
9092

test/platform-commands.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ function createTestInjector() {
141141
track: async () => undefined
142142
});
143143
testInjector.register("messages", Messages);
144+
testInjector.register("devicePathProvider", {});
144145

145146
return testInjector;
146147
}

test/platform-service.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ function createTestInjector() {
8383
track: async () => undefined
8484
});
8585
testInjector.register("messages", Messages);
86+
testInjector.register("devicePathProvider", {});
8687

8788
return testInjector;
8889
}

0 commit comments

Comments
 (0)