Skip to content

Commit 72f1dd8

Browse files
committed
fixed warnings
1 parent 4468733 commit 72f1dd8

File tree

1 file changed

+0
-23
lines changed

1 file changed

+0
-23
lines changed

lib/services/android-project-service.ts

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import * as projectServiceBaseLib from "./platform-project-service-base";
77
import {DeviceAndroidDebugBridge} from "../common/mobile/android/device-android-debug-bridge";
88
import {AndroidDeviceHashService} from "../common/mobile/android/android-device-hash-service";
99
import {EOL} from "os";
10-
import { createGUID } from "../common/helpers";
1110

1211
export class AndroidProjectService extends projectServiceBaseLib.PlatformProjectServiceBase implements IPlatformProjectService {
1312
private static VALUES_DIRNAME = "values";
@@ -507,27 +506,5 @@ export class AndroidProjectService extends projectServiceBaseLib.PlatformProject
507506

508507
}).future<void>()();
509508
}
510-
511-
private isAndroidManifestFileCorrect(pathToAndroidManifest: string): IFuture<boolean> {
512-
return ((): boolean => {
513-
try {
514-
// Check if the AndroidManifest in app/App_Resouces is the correct one
515-
// Use a real magic to detect if this is the correct file, by checking some mandatory strings.
516-
let fileContent = this.$fs.readText(pathToAndroidManifest).wait(),
517-
isFileCorrect = !!(~fileContent.indexOf("android:minSdkVersion") && ~fileContent.indexOf("android:targetSdkVersion")
518-
&& ~fileContent.indexOf("uses-permission") && ~fileContent.indexOf("<application")
519-
&& ~fileContent.indexOf("<activity") && ~fileContent.indexOf("<intent-filter>")
520-
&& ~fileContent.indexOf("android.intent.action.MAIN")
521-
&& ~fileContent.indexOf("android:versionCode")
522-
&& !this.$xmlValidator.getXmlFileErrors(pathToAndroidManifest).wait());
523-
524-
this.$logger.trace(`Existing ${this.platformData.configurationFileName} is ${isFileCorrect ? "" : "NOT "}correct.`);
525-
return isFileCorrect;
526-
} catch (err) {
527-
this.$logger.trace(`Error while checking ${pathToAndroidManifest}: `, err);
528-
return false;
529-
}
530-
}).future<boolean>()();
531-
}
532509
}
533510
$injector.register("androidProjectService", AndroidProjectService);

0 commit comments

Comments
 (0)