fix: validate webpack version on tns run android --hmr

Fatme · Fatme · commit 8c113350e488 · 2018-10-04T11:17:10.000+03:00
diff --git a/lib/helpers/livesync-command-helper.ts b/lib/helpers/livesync-command-helper.ts
@@ -1,4 +1,5 @@
 export class LiveSyncCommandHelper implements ILiveSyncCommandHelper {
+	private static MIN_SUPPORTED_WEBPACK_VERSION_WITH_HMR = "0.17.0";
 
 	constructor(private $platformService: IPlatformService,
 		private $projectData: IProjectData,
@@ -133,7 +134,8 @@ export class LiveSyncCommandHelper implements ILiveSyncCommandHelper {
 			result[availablePlatform.toLowerCase()] = validateOutput;
 		}
 
-		this.$bundleValidatorHelper.validate();
+		const minSupportedWebpackVersion = this.$options.hmr ? LiveSyncCommandHelper.MIN_SUPPORTED_WEBPACK_VERSION_WITH_HMR : null;
+		this.$bundleValidatorHelper.validate(minSupportedWebpackVersion);
 
 		return result;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`export class LiveSyncCommandHelper implements ILiveSyncCommandHelper {`
	`2`	`+ private static MIN_SUPPORTED_WEBPACK_VERSION_WITH_HMR = "0.17.0";`
`2`	`3`
`3`	`4`	`constructor(private $platformService: IPlatformService,`
`4`	`5`	`private $projectData: IProjectData,`
`@@ -133,7 +134,8 @@ export class LiveSyncCommandHelper implements ILiveSyncCommandHelper {`
`133`	`134`	`result[availablePlatform.toLowerCase()] = validateOutput;`
`134`	`135`	`}`
`135`	`136`
`136`		`- this.$bundleValidatorHelper.validate();`
	`137`	`+ const minSupportedWebpackVersion = this.$options.hmr ? LiveSyncCommandHelper.MIN_SUPPORTED_WEBPACK_VERSION_WITH_HMR : null;`
	`138`	`+ this.$bundleValidatorHelper.validate(minSupportedWebpackVersion);`
`137`	`139`
`138`	`140`	`return result;`
`139`	`141`	`}`