Skip to content

Commit 924645b

Browse files
feat: allow using Android SDK 28 for compilation
Allow using the SDK 28 for compileSdk of applications by adding it in the verified versions.
1 parent a51122b commit 924645b

File tree

3 files changed

+25
-13
lines changed

3 files changed

+25
-13
lines changed

lib/android-tools-info.ts

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,19 @@ import { androidToolsInfo } from "nativescript-doctor";
55

66
export class AndroidToolsInfo implements IAndroidToolsInfo {
77
private static ANDROID_TARGET_PREFIX = "android";
8-
private static SUPPORTED_TARGETS = ["android-17", "android-18", "android-19", "android-21", "android-22", "android-23", "android-24", "android-25", "android-26", "android-27"];
8+
private static SUPPORTED_TARGETS = [
9+
"android-17",
10+
"android-18",
11+
"android-19",
12+
"android-21",
13+
"android-22",
14+
"android-23",
15+
"android-24",
16+
"android-25",
17+
"android-26",
18+
"android-27",
19+
"android-28",
20+
];
921
private static MIN_REQUIRED_COMPILE_TARGET = 22;
1022
private static REQUIRED_BUILD_TOOLS_RANGE_PREFIX = ">=23";
1123
private static VERSION_REGEX = /((\d+\.){2}\d+)/;

npm-shrinkwrap.json

Lines changed: 11 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"minimatch": "3.0.2",
5656
"mkdirp": "0.5.1",
5757
"mute-stream": "0.0.5",
58-
"nativescript-doctor": "1.3.0",
58+
"nativescript-doctor": "1.4.0",
5959
"nativescript-preview-sdk": "0.2.11",
6060
"open": "0.0.5",
6161
"ora": "2.0.0",

0 commit comments

Comments
 (0)