Skip to content

Commit cfc4c33

Browse files
committed
Merge pull request #801 from NativeScript/totev/release-master
Merge {N} 1.2.3 release into Master
2 parents ec6a523 + 934667b commit cfc4c33

File tree

5 files changed

+24
-6
lines changed

5 files changed

+24
-6
lines changed

lib/services/android-project-service.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,7 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
199199

200200
private parseProjectProperties(projDir: string, destDir: string): IFuture<void> { // projDir is libraryPath, targetPath is the path to lib folder
201201
return (() => {
202+
projDir = projDir.trim();
202203
let projProp = path.join(projDir, "project.properties");
203204
if (!this.$fs.exists(projProp).wait()) {
204205
this.$logger.warn("Warning: File %s does not exist", projProp);

lib/services/ios-project-service.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
189189
var umbrellaHeader = this.getUmbrellaHeaderFromDynamicFramework(libraryPath).wait();
190190

191191
let frameworkName = path.basename(libraryPath, path.extname(libraryPath));
192-
let targetPath = path.join("lib", this.platformData.normalizedPlatformName, frameworkName);
192+
let targetPath = path.join("lib", this.platformData.normalizedPlatformName);
193193
let fullTargetPath = path.join(this.$projectData.projectDir, targetPath);
194194
this.$fs.ensureDirectoryExists(fullTargetPath).wait();
195195
shell.cp("-R", libraryPath, fullTargetPath);
@@ -280,7 +280,7 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
280280

281281
private getFrameworkRelativePath(libraryPath: string): string {
282282
let frameworkName = path.basename(libraryPath, path.extname(libraryPath));
283-
let targetPath = path.join("lib", this.platformData.normalizedPlatformName, frameworkName);
283+
let targetPath = path.join("lib", this.platformData.normalizedPlatformName);
284284
let frameworkPath = path.relative("platforms/ios", path.join(targetPath, frameworkName + ".framework"));
285285
return frameworkPath;
286286
}
@@ -380,4 +380,4 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
380380
}).future<void>()();
381381
}
382382
}
383-
$injector.register("iOSProjectService", IOSProjectService);
383+
$injector.register("iOSProjectService", IOSProjectService);

lib/services/usb-livesync-service.ts

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,10 @@ export class UsbLiveSyncService extends usbLivesyncServiceBaseLib.UsbLiveSyncSer
8787
}).future<string>()();
8888
}
8989

90+
let iOSSimulatorRelativeToProjectBasePathAction = (projectFile: string): string => {
91+
return path.join(constants.APP_FOLDER_NAME, path.dirname(projectFile.split(`/${constants.APP_FOLDER_NAME}/`)[1]));
92+
}
93+
9094
let watchGlob = path.join(this.$projectData.projectDir, constants.APP_FOLDER_NAME);
9195

9296
let platformSpecificLiveSyncServices: IDictionary<any> = {
@@ -96,7 +100,20 @@ export class UsbLiveSyncService extends usbLivesyncServiceBaseLib.UsbLiveSyncSer
96100

97101
let localProjectRootPath = platform.toLowerCase() === "ios" ? platformData.appDestinationDirectoryPath : null;
98102

99-
this.sync(platform, this.$projectData.projectId, projectFilesPath, this.excludedProjectDirsAndFiles, watchGlob, platformSpecificLiveSyncServices, restartAppOnDeviceAction, notInstalledAppOnDeviceAction, notRunningiOSSimulatorAction, localProjectRootPath, beforeLiveSyncAction, beforeBatchLiveSyncAction).wait();
103+
this.sync(platform,
104+
this.$projectData.projectId,
105+
projectFilesPath,
106+
this.excludedProjectDirsAndFiles,
107+
watchGlob,
108+
platformSpecificLiveSyncServices,
109+
restartAppOnDeviceAction,
110+
notInstalledAppOnDeviceAction,
111+
notRunningiOSSimulatorAction,
112+
localProjectRootPath,
113+
beforeLiveSyncAction,
114+
beforeBatchLiveSyncAction,
115+
iOSSimulatorRelativeToProjectBasePathAction
116+
).wait();
100117
}).future<void>()();
101118
}
102119

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "nativescript",
33
"preferGlobal": true,
4-
"version": "1.2.2",
4+
"version": "1.2.3",
55
"author": "Telerik <[email protected]>",
66
"description": "Command-line interface for building NativeScript projects",
77
"bin": {

0 commit comments

Comments
 (0)