Skip to content

Commit ddf89d8

Browse files
committed
chore: fix PR comments
1 parent 7e79e0b commit ddf89d8

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

lib/controllers/prepare-controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ export class PrepareController extends EventEmitter {
132132
const watcher = choki.watch(patterns, watcherOptions)
133133
.on("all", async (event: string, filePath: string) => {
134134
filePath = path.join(projectData.projectDir, filePath);
135-
this.$logger.info(`Chokidar raised event ${event} for ${filePath}.`);
135+
this.$logger.trace(`Chokidar raised event ${event} for ${filePath}.`);
136136
this.emitPrepareEvent({ files: [], hmrData: null, hasNativeChanges: true, platform: platformData.platformNameLowerCase });
137137
});
138138

lib/services/project-changes-service.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,16 +60,15 @@ export class ProjectChangesService implements IProjectChangesService {
6060

6161
this.$nodeModulesDependenciesBuilder.getProductionDependencies(projectData.projectDir)
6262
.filter(dep => dep.nativescript && this.$fs.exists(path.join(dep.directory, PLATFORMS_DIR_NAME, platformData.platformNameLowerCase)))
63-
.map(dep => {
63+
.forEach(dep => {
6464
this._changesInfo.nativeChanged = this._changesInfo.nativeChanged ||
6565
this.containsNewerFiles(path.join(dep.directory, PLATFORMS_DIR_NAME, platformData.platformNameLowerCase), projectData) ||
6666
this.isFileModified(path.join(dep.directory, PACKAGE_JSON_FILE_NAME));
6767
});
6868

6969
if (!this._changesInfo.nativeChanged) {
70-
const packageJsonChanged = this.isProjectFileChanged(projectData.projectDir, platformData);
7170
this._prepareInfo.projectFileHash = this.getProjectFileStrippedHash(projectData.projectDir, platformData);
72-
this._changesInfo.nativeChanged = packageJsonChanged;
71+
this._changesInfo.nativeChanged = this.isProjectFileChanged(projectData.projectDir, platformData);
7372
}
7473

7574
this.$logger.trace(`Set nativeChanged to ${this._changesInfo.nativeChanged}.`);

0 commit comments

Comments
 (0)