File tree Expand file tree Collapse file tree 3 files changed +12
-2
lines changed Expand file tree Collapse file tree 3 files changed +12
-2
lines changed Original file line number Diff line number Diff line change @@ -19,6 +19,7 @@ export class PrepareController extends EventEmitter {
19
19
private $platformController : IPlatformController ,
20
20
public $hooksService : IHooksService ,
21
21
private $logger : ILogger ,
22
+ private $mobileHelper : Mobile . IMobileHelper ,
22
23
private $nodeModulesDependenciesBuilder : INodeModulesDependenciesBuilder ,
23
24
private $platformsDataService : IPlatformsDataService ,
24
25
private $pluginsService : IPluginsService ,
@@ -33,7 +34,9 @@ export class PrepareController extends EventEmitter {
33
34
34
35
public async prepare ( prepareData : IPrepareData ) : Promise < IPrepareResultData > {
35
36
const projectData = this . $projectDataService . getProjectData ( prepareData . projectDir ) ;
36
- await this . $markingModeService . handleMarkingModeFullDeprecation ( { projectDir : projectData . projectDir } ) ;
37
+ if ( this . $mobileHelper . isAndroidPlatform ( prepareData . platform ) ) {
38
+ await this . $markingModeService . handleMarkingModeFullDeprecation ( { projectDir : projectData . projectDir } ) ;
39
+ }
37
40
38
41
await this . trackRuntimeVersion ( prepareData . platform , projectData ) ;
39
42
await this . $pluginsService . ensureAllDependenciesAreInstalled ( projectData ) ;
Original file line number Diff line number Diff line change @@ -20,6 +20,7 @@ export class PreviewAppController extends EventEmitter implements IPreviewAppCon
20
20
private $hmrStatusService : IHmrStatusService ,
21
21
private $logger : ILogger ,
22
22
public $hooksService : IHooksService ,
23
+ private $mobileHelper : Mobile . IMobileHelper ,
23
24
private $pluginsService : IPluginsService ,
24
25
private $prepareController : PrepareController ,
25
26
private $previewAppFilesService : IPreviewAppFilesService ,
@@ -58,7 +59,10 @@ export class PreviewAppController extends EventEmitter implements IPreviewAppCon
58
59
const projectData = this . $projectDataService . getProjectData ( data . projectDir ) ;
59
60
await this . $pluginsService . ensureAllDependenciesAreInstalled ( projectData ) ;
60
61
await this . $previewSdkService . initialize ( data . projectDir , async ( device : Device ) => {
61
- await this . $markingModeService . handleMarkingModeFullDeprecation ( { projectDir : projectData . projectDir } ) ;
62
+ if ( this . $mobileHelper . isAndroidPlatform ( device . platform ) ) {
63
+ await this . $markingModeService . handleMarkingModeFullDeprecation ( { projectDir : projectData . projectDir } ) ;
64
+ }
65
+
62
66
try {
63
67
if ( ! device ) {
64
68
this . $errors . fail ( "Sending initial preview files without a specified device is not supported." ) ;
Original file line number Diff line number Diff line change 1
1
import { assert } from "chai" ;
2
2
import { PrepareController } from "../../lib/controllers/prepare-controller" ;
3
+ import { MobileHelper } from "../../lib/common/mobile/mobile-helper" ;
3
4
import { InjectorStub } from "../stubs" ;
4
5
import { PREPARE_READY_EVENT_NAME } from "../../lib/constants" ;
5
6
@@ -44,6 +45,8 @@ function createTestInjector(data: { hasNativeChanges: boolean }): IInjector {
44
45
}
45
46
} ) ) ;
46
47
48
+ injector . register ( "mobileHelper" , MobileHelper ) ;
49
+
47
50
injector . register ( "prepareController" , PrepareController ) ;
48
51
49
52
injector . register ( "nodeModulesDependenciesBuilder" , {
You can’t perform that action at this time.
0 commit comments