Skip to content

Commit e958766

Browse files
authored
feat(doctor): add api 33 as supported (#5684)
2 parents 4abe2c9 + 893989b commit e958766

File tree

7 files changed

+22
-16
lines changed

7 files changed

+22
-16
lines changed

lib/common/mobile/emulator-helper.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import { injector } from "../yok";
55
export class EmulatorHelper implements Mobile.IEmulatorHelper {
66
// https://developer.android.com/guide/topics/manifest/uses-sdk-element
77
public mapAndroidApiLevelToVersion = {
8+
"android-33": "13.0.0",
9+
"android-32": "12.0.0",
810
"android-31": "12.0.0",
911
"android-30": "11.0.0",
1012
"android-29": "10.0.0",

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
"mobile"
5858
],
5959
"dependencies": {
60-
"@nativescript/doctor": "2.0.8",
60+
"@nativescript/doctor": "2.0.9",
6161
"@nativescript/schematics-executor": "0.0.2",
6262
"@rigor789/resolve-package-path": "^1.0.5",
6363
"axios": "^0.21.1",

packages/doctor/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/doctor",
3-
"version": "2.0.8",
3+
"version": "2.0.9",
44
"description": "Library that helps identifying if the environment can be used for development of {N} apps.",
55
"main": "src/index.js",
66
"types": "./typings/nativescript-doctor.d.ts",

packages/doctor/src/android-tools-info.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ export class AndroidToolsInfo implements NativeScriptDoctor.IAndroidToolsInfo {
2929
"android-30",
3030
"android-31",
3131
"android-32",
32+
"android-33",
3233
];
3334

3435
const isRuntimeVersionLessThan = (targetVersion: string) => {

packages/doctor/test/android-tools-info.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ describe("androidToolsInfo", () => {
5555
"30.0.0",
5656
"31.0.0",
5757
"32.0.0",
58+
"33.0.0",
5859
];
5960
} else {
6061
return [
@@ -65,6 +66,7 @@ describe("androidToolsInfo", () => {
6566
"android-30",
6667
"android-31",
6768
"android-32",
69+
"android-33",
6870
];
6971
}
7072
},
@@ -100,7 +102,7 @@ describe("androidToolsInfo", () => {
100102
const androidToolsInfo = getAndroidToolsInfo("8.2.0");
101103
const toolsInfo = androidToolsInfo.getToolsInfo({ projectDir: "test" });
102104

103-
assert.equal(toolsInfo.compileSdkVersion, 32);
105+
assert.equal(toolsInfo.compileSdkVersion, 33);
104106
});
105107
});
106108

@@ -132,10 +134,11 @@ describe("androidToolsInfo", () => {
132134
assertSupportedRange("8.1.0", min, max);
133135
});
134136

135-
it("runtime 8.2.0 should support android-17 - android-32", () => {
137+
it("runtime 8.2.0 should support android-17 - android-33", () => {
136138
const min = 17;
137-
const max = 32;
139+
const max = 33;
138140
assertSupportedRange("8.2.0", min, max);
141+
assertSupportedRange("8.3.0", min, max);
139142
});
140143
});
141144

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -340,10 +340,10 @@
340340
"resolved" "https://registry.npmjs.org/@kwsites/promise-deferred/-/promise-deferred-1.1.1.tgz"
341341
"version" "1.1.1"
342342

343-
"@nativescript/[email protected].8":
344-
"integrity" "sha512-/jVGBBBBY2BX1IwriDyXHNi0ZNAkSuzdDQuGY3nUl3BDLu5AM+FFg4qCG3D9IW664WLbA1KbJQd+HUSjRHM/ZQ=="
345-
"resolved" "https://registry.npmjs.org/@nativescript/doctor/-/doctor-2.0.8.tgz"
346-
"version" "2.0.8"
343+
"@nativescript/[email protected].9":
344+
"integrity" "sha512-/4Y3wkB5fQHr7oZVl15uQz1vwZPeL5dxVdts/djakJczIFKHozTL4k31rH1/82fExB5HvzzfJZhEvocwkS+/lw=="
345+
"resolved" "https://registry.npmjs.org/@nativescript/doctor/-/doctor-2.0.9.tgz"
346+
"version" "2.0.9"
347347
dependencies:
348348
"lodash" "4.17.21"
349349
"osenv" "0.1.5"

0 commit comments

Comments
 (0)