fix: unify path according to platform

Author: KristianDD

lib/services/log-source-map-service.ts

@@ -3,6 +3,7 @@ import * as path from "path";
 const sourceMapConverter = require("convert-source-map");
 import { ANDROID_DEVICE_APP_ROOT_TEMPLATE, APP_FOLDER_NAME, NODE_MODULES_FOLDER_NAME } from "../constants";
 import * as util from "util";
+import { stringReplaceAll } from "../common/helpers";
 
 interface IParsedMessage {
 	filePath?: string;
@@ -71,7 +72,7 @@ export class LogSourceMapService implements Mobile.ILogSourceMapService {
 						if (!_.startsWith(sourceFile, NODE_MODULES_FOLDER_NAME)) {
 							sourceFile = path.join(projectData.getAppDirectoryRelativePath(), sourceFile);
 						}
-
+						sourceFile = stringReplaceAll(sourceFile, "/", path.sep);
 						return { sourceFile, line: originalPosition.line, column: originalPosition.column};
 					}
 				}

test/services/log-source-map-service.ts

@@ -4,6 +4,7 @@ import * as path from "path";
 import { LogSourceMapService } from "../../lib/services/log-source-map-service";
 import { DevicePlatformsConstants } from "../../lib/common/mobile/device-platforms-constants";
 import { FileSystem } from "../../lib/common/file-system";
+import { stringReplaceAll } from "../../lib/common/helpers";
 
 function createTestInjector(): IInjector {
 	const testInjector = new Yok();
@@ -34,28 +35,32 @@ function createTestInjector(): IInjector {
 	return testInjector;
 }
 
+function toPlatformSep(filePath: string) {
+	return stringReplaceAll(filePath, "/", path.sep);
+}
+
 const testCases: IDictionary<Array<{caseName: string, message: string, expected: string}>> = {
 	"android": [{
 			caseName: "trace massage",
 			message: "JS: at module.exports.push../main-view-model.ts.HelloWorldModel.onTap (file:///data/data/org.nativescript.sourceMap/files/app/bundle.js:303:17)",
-			expected: "JS: at module.exports.push../main-view-model.ts.HelloWorldModel.onTap file:///src/main-view-model.ts:30:16\n"
+			expected: `JS: at module.exports.push../main-view-model.ts.HelloWorldModel.onTap file:///${toPlatformSep("src/main-view-model.ts")}:30:16\n`
 		}, {
 			caseName: "error massage",
 			message: "System.err: 	Frame: function:'module.exports.push../main-view-model.ts.HelloWorldModel.onTap', file:'file:///data/data/org.nativescript.sourceMap/files/app/bundle.js', line: 304, column: 15",
-			expected: "System.err: 	Frame: function:'module.exports.push../main-view-model.ts.HelloWorldModel.onTap', file:' file:///src/main-view-model.ts:31:14\n"
+			expected: `System.err: 	Frame: function:'module.exports.push../main-view-model.ts.HelloWorldModel.onTap', file:' file:///${toPlatformSep("src/main-view-model.ts")}:31:14\n`
 		}],
 	"ios": [{
 			caseName: "console massage",
 			message: "CONSOLE LOG file:///app/bundle.js:294:20: Test.",
-			expected: "CONSOLE LOG Test. file:///src/main-view-model.ts:29:20\n"
+			expected: `CONSOLE LOG Test. file:///${toPlatformSep("src/main-view-model.ts")}:29:20\n`
 		}, {
 			caseName: "trace massage",
 			message: "CONSOLE TRACE file:///app/bundle.js:295:22: Test",
-			expected: "CONSOLE TRACE Test file:///src/main-view-model.ts:30:22\n"
+			expected: `CONSOLE TRACE Test file:///${toPlatformSep("src/main-view-model.ts")}:30:22\n`
 		}, {
 			caseName: "error massage",
 			message: "file:///app/bundle.js:296:32: JS ERROR Error: Test",
-			expected: "JS ERROR Error Test file:///src/main-view-model.ts:31:31\n"
+			expected: `JS ERROR Error Test file:///${toPlatformSep("src/main-view-model.ts")}:31:31\n`
 		}]
 };