Skip to content

Commit feb517f

Browse files
Merge pull request #1660 from NativeScript/vladimirov/appbuilder-fixes
AppBuilder fixes
2 parents 9935fd6 + a598b12 commit feb517f

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

lib/config.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ export class Configuration extends ConfigBase implements IConfiguration { // Use
2222
$injector.register("config", Configuration);
2323

2424
export class StaticConfig extends StaticConfigBase implements IStaticConfig {
25+
public disableAnalytics = true;
26+
2527
public PROJECT_FILE_NAME = "package.json";
2628
public CLIENT_NAME_KEY_IN_PROJECT_FILE = "nativescript";
2729
public CLIENT_NAME = "tns";

lib/services/ios-project-service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
417417
public ensureConfigurationFileInAppResources(): IFuture<void> {
418418
return (() => {
419419
let projectDir = this.$projectData.projectDir;
420-
let infoPlistPath = path.join(projectDir, constants.APP_FOLDER_NAME, constants.APP_RESOURCES_FOLDER_NAME, this.platformData.normalizedPlatformName, this.platformData.configurationFileName);
420+
let infoPlistPath = this.$options.baseConfig || path.join(projectDir, constants.APP_FOLDER_NAME, constants.APP_RESOURCES_FOLDER_NAME, this.platformData.normalizedPlatformName, this.platformData.configurationFileName);
421421

422422
if (!this.$fs.exists(infoPlistPath).wait()) {
423423
// The project is missing Info.plist, try to populate it from the project template.
@@ -442,7 +442,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
442442
private mergeInfoPlists(): IFuture<void> {
443443
return (() => {
444444
let projectDir = this.$projectData.projectDir;
445-
let infoPlistPath = path.join(projectDir, constants.APP_FOLDER_NAME, constants.APP_RESOURCES_FOLDER_NAME, this.platformData.normalizedPlatformName, this.platformData.configurationFileName);
445+
let infoPlistPath = this.$options.baseConfig || path.join(projectDir, constants.APP_FOLDER_NAME, constants.APP_RESOURCES_FOLDER_NAME, this.platformData.normalizedPlatformName, this.platformData.configurationFileName);
446446
this.ensureConfigurationFileInAppResources().wait();
447447

448448
if (!this.$fs.exists(infoPlistPath).wait()) {

lib/services/platform-service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -296,11 +296,11 @@ export class PlatformService implements IPlatformService {
296296
let excludedDirs = [constants.APP_RESOURCES_FOLDER_NAME];
297297
this.$projectFilesManager.processPlatformSpecificFiles(directoryPath, platform, excludedDirs).wait();
298298

299+
this.applyBaseConfigOption(platformData).wait();
300+
299301
// Process configurations files from App_Resources
300302
platformData.platformProjectService.processConfigurationFilesFromAppResources().wait();
301303

302-
this.applyBaseConfigOption(platformData).wait();
303-
304304
// Replace placeholders in configuration files
305305
platformData.platformProjectService.interpolateConfigurationFile().wait();
306306

0 commit comments

Comments
 (0)