Skip to content

Commit 8751550

Browse files
feat: startDeviceOptions option (#183)
1 parent 5c40e3b commit 8751550

File tree

7 files changed

+12
-7
lines changed

7 files changed

+12
-7
lines changed

lib/device-manager.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { INsCapabilities } from "./interfaces/ns-capabilities";
22
import { IDeviceManager } from "./interfaces/device-manager";
3-
import { IDevice, Device, DeviceType } from "mobile-devices-controller";
3+
import { IDevice, DeviceType } from "mobile-devices-controller";
44
export declare class DeviceManager implements IDeviceManager {
55
private static _emulators;
66
constructor();
@@ -9,7 +9,7 @@ export declare class DeviceManager implements IDeviceManager {
99
installApp(args: INsCapabilities): Promise<any>;
1010
uninstallApp(args: INsCapabilities): Promise<any>;
1111
static kill(device: IDevice): Promise<void>;
12-
static getDefaultDevice(args: INsCapabilities, deviceName?: string, token?: string, type?: DeviceType, platformVersion?: number): Device;
12+
static getDefaultDevice(args: INsCapabilities, deviceName?: string, token?: string, type?: DeviceType, platformVersion?: number): any;
1313
static setDontKeepActivities(args: INsCapabilities, driver: any, value: any): Promise<void>;
1414
static executeShellCommand(driver: any, commandAndargs: {
1515
command: string;

lib/device-manager.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ export class DeviceManager implements IDeviceManager {
9494
delete device.process;
9595
} catch (error) { }
9696

97+
await DeviceController.startDevice(device, args.startDeviceOptions);
9798
logInfo("Started device: ", device);
9899
} else {
99100
device.type === DeviceType.DEVICE ? logInfo("Device is connected:", device) : logInfo("Device is already started", device)

lib/image-helper.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export declare class ImageHelper {
1010
blockOutAreas: IRectangle[];
1111
imageOutputLimit(): ImageOptions;
1212
thresholdType(): ImageOptions;
13-
threshold(thresholdType: any): 0.01 | 10;
13+
threshold(thresholdType: any): 10 | 0.01;
1414
delta(): number;
1515
static cropImageDefault(_args: INsCapabilities): {
1616
x: number;

lib/interfaces/ns-capabilities-args.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,5 @@ export interface INsCapabilitiesArgs {
3636
automationName?: AutomationName;
3737
deviceManager?: IDeviceManager;
3838
imagesPath?: string;
39+
startDeviceOptions?: string;
3940
}

lib/interfaces/ns-capabilities-args.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,5 @@ export interface INsCapabilitiesArgs {
3737
automationName?: AutomationName;
3838
deviceManager?: IDeviceManager;
3939
imagesPath?: string;
40+
startDeviceOptions?: string;
4041
}

lib/parser.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export declare const projectDir: string, projectBinary: string, pluginRoot: string, pluginBinary: string, port: number, verbose: boolean, appiumCapsLocation: string, testFolder: string, runType: string, isSauceLab: boolean, appPath: string, storage: string, testReports: string, devMode: boolean, ignoreDeviceController: boolean, wdaLocalPort: number, path: string, relaxedSecurity: boolean, cleanApp: boolean, attachToDebug: boolean, sessionId: string, startSession: boolean, capabilitiesName: string, imagesPath: string;
1+
export declare const projectDir: string, projectBinary: string, pluginRoot: string, pluginBinary: string, port: number, verbose: boolean, appiumCapsLocation: string, testFolder: string, runType: string, isSauceLab: boolean, appPath: string, storage: string, testReports: string, devMode: boolean, ignoreDeviceController: boolean, wdaLocalPort: number, path: string, relaxedSecurity: boolean, cleanApp: boolean, attachToDebug: boolean, sessionId: string, startSession: boolean, capabilitiesName: string, imagesPath: string, startDeviceOptions: string;

lib/parser.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,8 @@ const config = (() => {
144144
sessionId: options.sessionId || process.env.npm_sessionId,
145145
startSession: options.startSession || process.env.npm_startSession,
146146
capabilitiesName: options.capabilitiesName || process.env.npm_capabilitiesName,
147-
imagesPath: options.imagesPath || process.env.npm_config_imagesPath
147+
imagesPath: options.imagesPath || process.env.npm_config_imagesPath,
148+
startDeviceOptions: options.startDeviceOptions || process.env.npm_config_startDeviceOptions,
148149
};
149150

150151
return config;
@@ -174,5 +175,6 @@ export const {
174175
sessionId,
175176
startSession,
176177
capabilitiesName,
177-
imagesPath
178-
}: INsCapabilitiesArgs = config;
178+
imagesPath,
179+
startDeviceOptions
180+
}: INsCapabilitiesArgs = config;

0 commit comments

Comments
 (0)