Skip to content

Commit 1db4de7

Browse files
authored
fix: no-dimension listview in stacklayout warning (#228)
Fix no-dimension listview in stacklayout warning: ``` JS: Avoid using ListView or ScrollView with no explicit height set inside StackLayout. Doing so might results in poor user interface performance and a poor user experience. ```
1 parent f2fdede commit 1db4de7

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
<ActionBar title="Barcelona Players" class="action-bar">
22
</ActionBar>
33

4-
<StackLayout class="page">
4+
<GridLayout class="page">
55
<ListView [items]="players" class="list-group">
66
<ng-template let-player="item">
77
<Label [nsRouterLink]="['/player', player.id]" [text]="player.name"
88
class="list-group-item"></Label>
99
</ng-template>
1010
</ListView>
11-
</StackLayout>
11+
</GridLayout>
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
<ActionBar title="<%= masterClassName %>" class="action-bar">
22
</ActionBar>
33

4-
<StackLayout class="page">
4+
<GridLayout class="page">
55
<ListView [items]="numbers" class="list-group">
66
<ng-template let-number="item">
77
<Label [nsRouterLink]="['/<%= detail %>', number.id]" [text]="number.text"
88
class="list-group-item"></Label>
99
</ng-template>
1010
</ListView>
11-
</StackLayout>
11+
</GridLayout>
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
<ActionBar title="<%= masterClassName %>" class="action-bar">
22
</ActionBar>
33

4-
<StackLayout class="page">
4+
<GridLayout class="page">
55
<ListView [items]="numbers" class="list-group">
66
<ng-template let-number="item">
77
<Label [nsRouterLink]="['/<%= detail %>', number.id]" [text]="number.text"
88
class="list-group-item"></Label>
99
</ng-template>
1010
</ListView>
11-
</StackLayout>
11+
</GridLayout>
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
<ActionBar title="Barcelona Players" class="action-bar">
22
</ActionBar>
33

4-
<StackLayout class="page">
4+
<GridLayout class="page">
55
<ListView [items]="players" class="list-group">
66
<ng-template let-player="item">
77
<Label [nsRouterLink]="['/player', player.id]" [text]="player.name"
88
class="list-group-item"></Label>
99
</ng-template>
1010
</ListView>
11-
</StackLayout>
11+
</GridLayout>

0 commit comments

Comments
 (0)