Commit 0a66bac
committed
feat: move all the source code to app folder
Till now `nativescript-dev-webpack` plugin requires automatically all (root|page)(.css|.xml|.js|.ts) files from the unit-test-runner. However, this behavior was changed and now `nativescript-dev-webpack` plugin requires automatically all files except the files from App_Resources and .d.ts files. This led to the problem that `preuninstall.js` and `postinstall.js` scripts are automatically required. These scripts require `nativescript-hook`. On the other side `nativescript-hook` has a dynamic require here https://github.com/NativeScript/nativescript-hook/blob/master/index.js#L56. As this dynamic require is not compatible with webpack's concept for dynamic requires, the following warning is shown:
```
WARNING in ../node_modules/nativescript-hook/index.js 56:27-51
Critical dependency: the request of a dependency is an expression
@ ../node_modules/nativescript-unit-test-runner/postinstall.js
@ ../node_modules/nativescript-unit-test-runner sync (?<!App_Resources.*).(xml|css|js|(?<!d.)ts|scss)$
@ ./app.js
```
This PR moves all the app's related code to the app folder. This way `nativescript-dev-webpack` will require automatically all files from app folder and the unneeded files (as postinstall and preuninstall) will not be required.1 parent 6d5a1d7 commit 0a66bac
File tree
21 files changed
+3
-3
lines changed- app
- services
21 files changed
+3
-3
lines changedFile renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
207 | 207 | | |
208 | 208 | | |
209 | 209 | | |
210 | | - | |
| 210 | + | |
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
| |||
0 commit comments