fix: prevent extra args getting passed to clean target

NathanWalker · NathanWalker · commit 114da91265f8 · 2022-04-14T13:15:26.000-07:00
diff --git a/packages/nx/src/executors/build/executor.ts b/packages/nx/src/executors/build/executor.ts
@@ -176,7 +176,7 @@ export default async function runExecutor(options: BuildBuilderSchema, context:
         // persisted flags in configurations
         additionalArgs.push(...options.flags.split(' '));
       }
-      if (process.argv.length > projectTargetCmdIndex + 1) {
+      if (!options.clean && process.argv.length > projectTargetCmdIndex + 1) {
         // manually added flags to the execution command
         const extraFlags = process.argv.slice(projectTargetCmdIndex + 1, process.argv.length);
         for (const flag of extraFlags) {

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ export default async function runExecutor(options: BuildBuilderSchema, context:`
`176`	`176`	`// persisted flags in configurations`
`177`	`177`	`additionalArgs.push(...options.flags.split(' '));`
`178`	`178`	`}`
`179`		`- if (process.argv.length > projectTargetCmdIndex + 1) {`
	`179`	`+ if (!options.clean && process.argv.length > projectTargetCmdIndex + 1) {`
`180`	`180`	`// manually added flags to the execution command`
`181`	`181`	`const extraFlags = process.argv.slice(projectTargetCmdIndex + 1, process.argv.length);`
`182`	`182`	`for (const flag of extraFlags) {`