feat: Nx 19 and Angular 18 support (#75)

Author: NathanWalker

.eslintrc.json

@@ -24,12 +24,18 @@
     {
       "files": ["*.ts", "*.tsx"],
       "extends": ["plugin:@nx/typescript"],
-      "rules": {}
+      "rules": {
+        "@typescript-eslint/no-extra-semi": "error",
+        "no-extra-semi": "off"
+      }
     },
     {
       "files": ["*.js", "*.jsx"],
       "extends": ["plugin:@nx/javascript"],
-      "rules": {}
+      "rules": {
+        "@typescript-eslint/no-extra-semi": "error",
+        "no-extra-semi": "off"
+      }
     }
   ]
 }

migrations.json

@@ -0,0 +1,37 @@
+{
+  "migrations": [
+    {
+      "cli": "nx",
+      "version": "19.1.0-beta.6",
+      "description": "Migrate no-extra-semi rules into user config, out of nx extendable configs",
+      "implementation": "./src/migrations/update-19-1-0-migrate-no-extra-semi/migrate-no-extra-semi",
+      "package": "@nx/eslint-plugin",
+      "name": "update-19-1-0-rename-no-extra-semi"
+    },
+    {
+      "cli": "nx",
+      "version": "19.1.0-beta.2",
+      "requires": {
+        "@angular/core": ">=18.0.0"
+      },
+      "description": "Update the @angular/cli package version to ~18.0.0.",
+      "factory": "./src/migrations/update-19-1-0/update-angular-cli",
+      "package": "@nx/angular",
+      "name": "update-angular-cli-version-18-0-0"
+    },
+    {
+      "version": "18.0.0",
+      "description": "Updates two-way bindings that have an invalid expression to use the longform expression instead.",
+      "factory": "./migrations/invalid-two-way-bindings/bundle",
+      "package": "@angular/core",
+      "name": "invalid-two-way-bindings"
+    },
+    {
+      "version": "18.0.0",
+      "description": "Replace deprecated HTTP related modules with provider functions",
+      "factory": "./migrations/http-providers/bundle",
+      "package": "@angular/core",
+      "name": "migration-http-providers"
+    }
+  ]
+}

package.json

@@ -31,10 +31,8 @@
   },
   "private": true,
   "devDependencies": {
-    "@angular-devkit/schematics": "17.3.3",
-    "@angular/core": "17.3.3",
-    "@swc-node/register": "1.9.0",
-    "@swc/core": "1.4.12",
+    "@angular-devkit/schematics": "18.0.1",
+    "@angular/core": "18.0.0",
     "@types/fs-extra": "^11.0.3",
     "@types/jest": "29.5.12",
     "@types/node": "^20.0.0",
@@ -47,28 +45,28 @@
     "doctoc": "^2.0.0",
     "dotenv": "~16.4.0",
     "eslint": "8.57.0",
-    "eslint-config-prettier": "9.0.0",
+    "eslint-config-prettier": "9.1.0",
     "fs-extra": "^11.2.0",
     "jest": "29.7.0",
     "jsonc-parser": "3.2.1",
-    "nx": "18.2.3",
+    "nx": "19.1.0",
     "plist": "^3.1.0",
-    "prettier": "^2.7.0",
-    "ts-jest": "29.1.2",
+    "prettier": "^2.7.1",
+    "ts-jest": "29.1.3",
     "ts-node": "10.9.2",
     "tslib": "^2.6.2",
-    "typescript": "5.4.4",
+    "typescript": "5.4.5",
     "xml2js": "^0.6.2",
-    "nx-cloud": "18.0.0",
-    "@nx/devkit": "18.2.3",
-    "@nx/workspace": "18.2.3",
-    "@nx/plugin": "18.2.3",
-    "@nx/web": "18.2.3",
-    "@nx/js": "18.2.3",
-    "@nx/eslint-plugin": "18.2.3",
-    "@nx/jest": "18.2.3",
-    "@nx/express": "18.2.3",
-    "@nx/angular": "18.2.3",
-    "@nx/eslint": "18.2.3"
+    "nx-cloud": "19.0.0",
+    "@nx/devkit": "19.1.0",
+    "@nx/workspace": "19.1.0",
+    "@nx/plugin": "19.1.0",
+    "@nx/web": "19.1.0",
+    "@nx/js": "19.1.0",
+    "@nx/eslint-plugin": "19.1.0",
+    "@nx/jest": "19.1.0",
+    "@nx/express": "19.1.0",
+    "@nx/angular": "19.1.0",
+    "@nx/eslint": "19.1.0"
   }
 }

packages/nx/README.md

@@ -46,26 +46,27 @@
 
 ```sh
 # Using npm
-npx create-nx-workspace@18.3.4
+npx create-nx-workspace@latest
 
 # Using yarn
-yarn create-nx-workspace@18.3.4
+yarn create-nx-workspace@latest
 ```
 
 At the prompts, you can use:
 
 ```sh
 ✔ Where would you like to create your workspace? · {your-workspace-name}
 
-# Choose "None"
-
 ? Which stack do you want to use? … 
 None:          Configures a minimal structure without specific frameworks or technologies.
-
-# Choose "Integrated"
+# Choose "None"
 
 ? Package-based monorepo, integrated monorepo, or standalone project?
 Integrated Monorepo:        Nx creates a monorepo that contains multiple projects.
+# Choose "Integrated"
+
+? Do you want Nx Cloud to make your CI fast? 
+# Choice is completely up to you
 ```
 
 ### Init workspace
@@ -86,6 +87,16 @@ npm install --save-dev @nativescript/nx
 yarn add -D @nativescript/nx
 ```
 
+*Note: If you get a Warning on peer dependencies you can ignore.* For example:
+
+```bash
+npm WARN ERESOLVE overriding peer dependency
+npm WARN While resolving: @swc-node/[email protected]
+npm WARN Found: @swc/[email protected]
+npm WARN node_modules/@swc/core
+npm WARN   peer @swc/core@">= 1.3" from @swc-node/[email protected]
+```
+
 ### Create an app
 
 ```sh

packages/nx/package.json

@@ -1,15 +1,15 @@
 {
   "name": "@nativescript/nx",
-  "version": "18.0.0",
+  "version": "19.0.0",
   "description": "NativeScript Plugin for Nx",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/nativescript/nx.git"
   },
   "keywords": [
-    "Monorepo",
     "Nx",
     "NativeScript",
+    "Monorepo",
     "Mobile",
     "iOS",
     "Android"
@@ -28,15 +28,15 @@
     "migrations": "./migrations.json"
   },
   "dependencies": {
-    "@angular-devkit/architect": "^0.1700.0",
-    "@angular-devkit/core": "^17.0.0",
-    "@angular-devkit/schematics": "^17.0.0",
+    "@angular-devkit/architect": "^0.1800.0",
+    "@angular-devkit/core": "^18.0.0",
+    "@angular-devkit/schematics": "^18.0.0",
     "fs-extra": "^11.2.0",
     "ignore": "^5.3.0",
     "plist": "^3.1.0",
     "xml2js": "~0.6.0",
-    "@nx/devkit": "^18.0.0",
-    "@nx/js": "^18.0.0",
-    "@nx/jest": "^18.0.0"
+    "@nx/devkit": "^19.0.0",
+    "@nx/js": "^19.0.0",
+    "@nx/jest": "^19.0.0"
   }
 }

packages/nx/src/utils/versions.ts

@@ -1,18 +1,18 @@
-export const nxVersion = '^18.0.0';
+export const nxVersion = '^19.0.0';
 
-export const nsNxPluginVersion = '^18.0.0';
-export const nsCoreVersion = '~8.6.0';
-export const nsTypesVersion = '~8.6.0';
+export const nsNxPluginVersion = '^19.0.0';
+export const nsCoreVersion = '~8.7.0';
+export const nsTypesVersion = '~8.7.0';
 export const nsThemeVersion = '~1.0.4';
 export const nsWebpackVersion = '~5.0.0';
 export const sassVersion = '^1.32.0';
-export const nsIOSRuntimeVersion = '~8.6.0';
-export const nsAndroidRuntimeVersion = '~8.6.0';
+export const nsIOSRuntimeVersion = '~8.7.0';
+export const nsAndroidRuntimeVersion = '~8.7.0';
 
 // Frontend frameworks
-export const angularVersion = '^17.0.0';
-export const nsAngularVersion = '^17.0.0';
-export const nsNgToolsVersion = '^17.0.0';
+export const angularVersion = '^18.0.0';
+export const nsAngularVersion = '^18.0.0';
+export const nsNgToolsVersion = '^18.0.0';
 export const rxjsVersion = '~7.8.0';
 export const zonejsVersion = '^0.14.0';
 export const typescriptVersion = '~5.4.0';