ofxsProperty: workaround for a clang>=14 bug with -O2

devernay · devernay · commit caf840a65a08 · 2022-11-14T13:02:00.000-08:00
Bug observed on OSX 10.9 (causes a segfault)
diff --git a/Support/Library/ofxsProperty.cpp b/Support/Library/ofxsProperty.cpp
@@ -212,7 +212,7 @@ namespace OFX {
     for (std::size_t i = 0; i < values.size(); ++i) {
       data[i] = values[i].c_str();
     }
-    OfxStatus stat = gPropSuite->propSetStringN(_propHandle, property, (int)values.size(), &data[0]);
+    OfxStatus stat = gPropSuite->propSetStringN(_propHandle, property, (int)data.size(), &data[0]);
     OFX::Log::error(stat != kOfxStatOK, "Failed on setting string property %s[0..%d], host returned status %s;",
                     property, (int)values.size()-1, mapStatusToString(stat));
     if(throwOnFailure)

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ namespace OFX {`
`212`	`212`	`for (std::size_t i = 0; i < values.size(); ++i) {`
`213`	`213`	`data[i] = values[i].c_str();`
`214`	`214`	`}`
`215`		`- OfxStatus stat = gPropSuite->propSetStringN(_propHandle, property, (int)values.size(), &data[0]);`
	`215`	`+ OfxStatus stat = gPropSuite->propSetStringN(_propHandle, property, (int)data.size(), &data[0]);`
`216`	`216`	`OFX::Log::error(stat != kOfxStatOK, "Failed on setting string property %s[0..%d], host returned status %s;",`
`217`	`217`	`property, (int)values.size()-1, mapStatusToString(stat));`
`218`	`218`	`if(throwOnFailure)`