Fix phpGH-15923: GDB: Python Exception <class 'TypeError'>: exceptions must derive from BaseException

Triggers on release builds when printing data structures.
You can't raise a string, you must raise exceptions.

Closes phpGH-15928.

Author: ndossche

NEWS

@@ -2,6 +2,10 @@ PHP                                                                        NEWS
 |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 ?? ??? ????, PHP 8.4.0RC1
 
+- Debugging:
+  . Fixed bug GH-15923 (GDB: Python Exception <class 'TypeError'>:
+    exceptions must derive from BaseException). (nielsdos)
+
 - DOM:
   . Fix XML serializer errata: xmlns="" serialization should be allowed.
     (nielsdos)

main/debug_gdb_scripts.c

@@ -971,7 +971,7 @@ asm(
     ".ascii \"\\n\"\n"
     ".ascii \"    (symbol,_) = gdb.lookup_symbol(\\\"zend_gc_refcount\\\")\\n\"\n"
     ".ascii \"    if symbol == None:\\n\"\n"
-    ".ascii \"        raise \\\"Could not find zend_types.h: symbol zend_gc_refcount not found\\\"\\n\"\n"
+    ".ascii \"        raise Exception(\\\"Could not find zend_types.h: symbol zend_gc_refcount not found\\\")\\n\"\n"
     ".ascii \"    filename = symbol.symtab.fullname()\\n\"\n"
     ".ascii \"\\n\"\n"
     ".ascii \"    bits = {}\\n\"\n"

scripts/gdb/php_gdb.py

@@ -301,7 +301,7 @@ def load_type_bits():
 
     (symbol,_) = gdb.lookup_symbol("zend_gc_refcount")
     if symbol == None:
-        raise "Could not find zend_types.h: symbol zend_gc_refcount not found"
+        raise Exception("Could not find zend_types.h: symbol zend_gc_refcount not found")
     filename = symbol.symtab.fullname()
 
     bits = {}