Redundant "key" and "unique" constraints

[Aurige]

Following a question from Tu-Tho, I realised that we have a lot of redundant key and unique constraint. That does not harm but when there is key my understanding is that you don't need the unique .
Probably to be cleaned at some point.
Also I can’t remember why the DataSourceRef_AnyKeyRef keyref has such a complicated selector (not sure this DataSourceRef_AnyKeyRef is necessary, the DataSource_AnyKeyRef looks sufficient)

[skinkie]

@thbar starting point is to make an invalid document. And make sure that when we remove the unique it still works.

@Aurige the DataSource story is related to DataSourceRef (element) and dataSourceRef (attribute). The latter cannot have a true version attribute.

[skinkie]

I have checked out a bit more complex situation based on an example from the examples folder.

<?xml version="1.0" encoding="UTF-8"?>
<PublicationDelivery xmlns="http://www.netex.org.uk/netex" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.0" xsi:schemaLocation="http://www.netex.org.uk/netex ../../../xsd/NeTEx_publication.xsd">
        <PublicationTimestamp>2001-12-17T09:30:47.0Z</PublicationTimestamp>
        <ParticipantRef>SYS001</ParticipantRef>
        <!--- =============== RESULTS =========== -->
        <dataObjects>
                <ServiceFrame version="any" id="SVF004">
                        <!--- ======= CODESPACEs======== -->
                        <codespaces>
                                <Codespace id="mybus">
                                        <Xmlns>mybus</Xmlns>
                                        <XmlnsUrl>http://www.mybus.fr/</XmlnsUrl>
                                        <Description>My buses</Description>
                                </Codespace>
                        </codespaces>
                        <!--- =======FRAME DEFAULTS======== -->
                        <FrameDefaults>
                                <DefaultCodespaceRef ref="mybus"/>
                        </FrameDefaults>
                        <scheduledStopPoints>
                                <ScheduledStopPoint version="032" created="2000-12-17T09:30:47.0Z" changed="2002-12-17T09:30:47.0Z" id="SSP0042A">
                                        <Name>Poste, St Jean</Name>
                                        <Location>
                                                <Longitude>-0.2071397147</Longitude>
                                                <Latitude>51.4217482061</Latitude>
                                        </Location>
                                        <VehicleModes>bus</VehicleModes>
                                </ScheduledStopPoint>
                        </scheduledStopPoints>
                </ServiceFrame>
                <FareFrame id="tfc:TFC@Network@ODs" version="01" responsibilitySetRef="tfc_products:TFC">
                        <fareScheduledStopPoints>
                                <FareScheduledStopPoint version="032" created="2000-12-17T09:30:47.0Z" changed="2002-12-17T09:30:47.0Z" id="SSP0042A">
                                        <Name>Poste, St Jean</Name>
                                        <Location>
                                                <Longitude>-0.2071397147</Longitude>
                                                <Latitude>51.4217482061</Latitude>
                                        </Location>
                                        <VehicleModes>bus</VehicleModes>
                                </FareScheduledStopPoint>
                        </fareScheduledStopPoints>
                </FareFrame>
        </dataObjects>
</PublicationDelivery>

/tmp/Netex_01_StopPoints_NoFrills_1.xml:33: Schemas validity error : Element '{http://www.netex.org.uk/netex}FareScheduledStopPoint': Duplicate key-sequence ['SSP0042A', '032'] in key identity-constraint '{http://www.netex.org.uk/netex}ScheduledStopPoint_AnyVersionedKey'.
/tmp/Netex_01_StopPoints_NoFrills_1.xml:33: Schemas validity error : Element '{http://www.netex.org.uk/netex}FareScheduledStopPoint': Duplicate key-sequence ['SSP0042A', '032'] in key identity-constraint '{http://www.netex.org.uk/netex}TimingPoint_AnyVersionedKey'.
/tmp/Netex_01_StopPoints_NoFrills_1.xml:33: Schemas validity error : Element '{http://www.netex.org.uk/netex}FareScheduledStopPoint': Duplicate key-sequence ['SSP0042A', '032'] in key identity-constraint '{http://www.netex.org.uk/netex}RoutePoint_AnyVersionedKey'.
/tmp/Netex_01_StopPoints_NoFrills_1.xml:33: Schemas validity error : Element '{http://www.netex.org.uk/netex}FareScheduledStopPoint': Duplicate key-sequence ['SSP0042A', '032'] in key identity-constraint '{http://www.netex.org.uk/netex}Point_AnyVersionedKey'.

For this I have removed the unique constraints.

1. RoutePoint_UniqueBy_Id_Version
2. TimingPoint_UniqueBy_Id_Version
3. ScheduledStopPoint_UniqueBy_Id_Version

But it is obviously interesting to see that there are now 4 errors. But it is not possible just to keep Point_AnyVersionedKey, because the keyref is different, hence we do want that a ScheduledStopPointRef is only allowed towards a ScheduledStopPoint and FareScheduledStopPoint but not a TimingPoint.

                <xsd:key name="Point_AnyVersionedKey">
                        <xsd:selector xpath=".//netex:Point | .//netex:RoutePoint | .//netex:TimingPoint | .//netex:ReliefPoint | .//netex:ParkingPoint | .//netex:GaragePoint | .//netex:ScheduledStopPoint | .//netex:RoadJunction | .//netex:RailwayJunction | .//netex:WireJunction | .//netex:ActivationPoint | .//netex:BeaconPoint | .//netex:TrafficControlPoint | .//netex:PathJunction | .//netex:FareScheduledStopPoint | .//netex:BorderPoint | .//netex:VehicleMeetingPoint"/>
                        <xsd:field xpath="@id"/>
                        <xsd:field xpath="@version"/>
                </xsd:key>

                <!-- =====ScheduledStopPoint Key ========================== -->
                <xsd:keyref name="ScheduledStopPoint_KeyRef" refer="netex:ScheduledStopPoint_AnyVersionedKey">
                        <xsd:selector xpath=".//netex:ScheduledStopPointRef | .//netex:ServiceLink/netex:FromPointRef | .//netex:ServiceLink/netex:ToPointRef | .//netex:FromStopPointRef | .//netex:ToStopPointRef | .//netex:NextStopPointRef | .//netex:AtStopPointRef | .//netex:StartStopPointRef | .//netex:EndStopPointRef | .//netex:FareScheduledStopPointRef | .//netex:AccountingStopPointRef | .//netex:AdjacentStopPointRef"/>
                        <xsd:field xpath="@ref"/>
                        <xsd:field xpath="@version"/>
                </xsd:keyref>
                <xsd:key name="ScheduledStopPoint_AnyVersionedKey">
                        <xsd:selector xpath=".//netex:ScheduledStopPoint | .//netex:FareScheduledStopPoint"/>
                        <xsd:field xpath="@id"/>
                        <xsd:field xpath="@version"/>
                </xsd:key>

[skinkie]

With unique constraints:

real	4m5.527s
user	3m57.850s
sys	0m1.706s

Without unique constraints:

real	2m44.075s
user	2m39.062s
sys	0m1.093s