The Big Bang 3

Author: NeVeSpl

README.md

@@ -144,13 +144,13 @@ There is only one way, at least for now, to divide types into slices `ByNamespac
 `namespacePrefix.(sliceName).restOfNamespace`
 3) Types with the same `sliceName` part will be placed in the same slice. If `sliceName` is empty for a given type, the type will be also ignored (`BaseFeature` class from folowing image)
 
-![Slices](docs/slices.png)
+![Slices](documentation/slices/slices.png)
 
 When we already have our types divided into slices, we can apply condition: `NotHaveDependenciesBetweenSlices()`. As the name suggest it detects if any dependency exists between slices. Dependency from slice to type that is not part of any other slice is allowed.
 
 passing | failing
 --|---
-![Slices](docs/slices.ok.png)|![Slices](docs/slices.not.png)
+![Slices](documentation/slices/slices.ok.png)|![Slices](documentation/slices/slices.not.png)
 
 
 ## Custom rules

docs/slices.not.png documentation/slices/slices.not.pngdocs/slices.not.png renamed to documentation/slices/slices.not.png

@@ -4,7 +4,6 @@
 using System.Reflection;
 using Mono.Cecil;
 using NetArchTest.Dependencies.DataStructures;
-using NetArchTest.Rules.Extensions;
 
 namespace NetArchTest.Assemblies
 {

docs/slices.ok.png documentation/slices/slices.ok.pngdocs/slices.ok.png renamed to documentation/slices/slices.ok.png

@@ -20,11 +20,5 @@ public TypeWrapper CreateWrapper()
         {
             return new TypeWrapper(Definition);
         }
-
-
-        public static implicit operator TypeDefinition(TypeSpec type)
-        {
-            return type.Definition;
-        }
     }
 }

docs/slices.png documentation/slices/slices.pngdocs/slices.png renamed to documentation/slices/slices.png

@@ -2,7 +2,6 @@
 using System.Diagnostics;
 using Mono.Cecil;
 using NetArchTest.Rules;
-using NetArchTest.Rules.Extensions;
 
 namespace NetArchTest.Assemblies
 {

src/NetArchTest.Rules/Assemblies/TypeSource.cs

@@ -5,7 +5,7 @@
     using System.Diagnostics;
     using System.Text;
     using Mono.Cecil;
-    using NetArchTest.Rules.Extensions;
+   
 
     /// <summary>
     /// Holds tree structure of full names; child nodes of each parent are indexed for optimal time of search.

src/NetArchTest.Rules/Assemblies/TypeSpec.cs

@@ -6,7 +6,7 @@
     using System.Linq;
     using System.Text;
     using Mono.Cecil;
-    using NetArchTest.Rules.Extensions;
+    
 
     /// <summary>
     /// Similar tree to <see cref="NamespaceTree"/>, but this is aware of the structure of type full name,

src/NetArchTest.Rules/Assemblies/TypeWrapper.cs

@@ -1,13 +1,9 @@
-namespace NetArchTest.Dependencies
-{
-    using System;
-    using System.Collections.Generic;
-    using System.Linq;
-    using Mono.Cecil;
-    using NetArchTest.Assemblies;
-    using NetArchTest.Dependencies.DataStructures;
-
+using System.Collections.Generic;
+using NetArchTest.Assemblies;
+using NetArchTest.Dependencies.DataStructures;
 
+namespace NetArchTest.Dependencies
+{
     /// <summary>
     /// Finds dependencies within a given set of types.
     /// </summary>
@@ -19,7 +15,7 @@ internal class DependencySearch
         /// <param name="input">The set of type definitions to search.</param>
         /// <param name="dependencies">The set of dependencies to look for.</param>
         /// <returns>A list of found types.</returns>
-        public IReadOnlyList<TypeSpec> FindTypesThatHaveDependencyOnAny(IEnumerable<TypeSpec> input, IEnumerable<string> dependencies)
+        public IEnumerable<TypeSpec> FindTypesThatHaveDependencyOnAny(IEnumerable<TypeSpec> input, IEnumerable<string> dependencies)
         {  
             return FindTypes(input, TypeDefinitionCheckingResult.SearchType.HaveDependencyOnAny, dependencies, true);           
         }
@@ -30,7 +26,7 @@ public IReadOnlyList<TypeSpec> FindTypesThatHaveDependencyOnAny(IEnumerable<Type
         /// <param name="input">The set of type definitions to search.</param>
         /// <param name="dependencies">The set of dependencies to look for.</param>
         /// <returns>A list of found types.</returns>
-        public IReadOnlyList<TypeSpec> FindTypesThatHaveDependencyOnAll(IEnumerable<TypeSpec> input, IEnumerable<string> dependencies)
+        public IEnumerable<TypeSpec> FindTypesThatHaveDependencyOnAll(IEnumerable<TypeSpec> input, IEnumerable<string> dependencies)
         {  
             return FindTypes(input, TypeDefinitionCheckingResult.SearchType.HaveDependencyOnAll, dependencies, true);         
         }
@@ -41,7 +37,7 @@ public IReadOnlyList<TypeSpec> FindTypesThatHaveDependencyOnAll(IEnumerable<Type
         /// <param name="input">The set of type definitions to search.</param>
         /// <param name="dependencies">The set of dependencies to look for.</param>
         /// <returns>A list of found types.</returns>
-        public IReadOnlyList<TypeSpec> FindTypesThatOnlyHaveDependenciesOnAnyOrNone(IEnumerable<TypeSpec> input, IEnumerable<string> dependencies)
+        public IEnumerable<TypeSpec> FindTypesThatOnlyHaveDependenciesOnAnyOrNone(IEnumerable<TypeSpec> input, IEnumerable<string> dependencies)
         {           
             return FindTypes(input, TypeDefinitionCheckingResult.SearchType.OnlyHaveDependenciesOnAnyOrNone, dependencies, false);
         }
@@ -52,7 +48,7 @@ public IReadOnlyList<TypeSpec> FindTypesThatOnlyHaveDependenciesOnAnyOrNone(IEnu
         /// <param name="input">The set of type definitions to search.</param>
         /// <param name="dependencies">The set of dependencies to look for.</param>
         /// <returns>A list of found types.</returns>
-        public IReadOnlyList<TypeSpec> FindTypesThatOnlyHaveDependenciesOnAny(IEnumerable<TypeSpec> input, IEnumerable<string> dependencies)
+        public IEnumerable<TypeSpec> FindTypesThatOnlyHaveDependenciesOnAny(IEnumerable<TypeSpec> input, IEnumerable<string> dependencies)
         {
             return FindTypes(input, TypeDefinitionCheckingResult.SearchType.OnlyHaveDependenciesOnAny, dependencies, false);
         }
@@ -63,12 +59,12 @@ public IReadOnlyList<TypeSpec> FindTypesThatOnlyHaveDependenciesOnAny(IEnumerabl
         /// <param name="input">The set of type definitions to search.</param>
         /// <param name="dependencies">The set of dependencies to look for.</param>
         /// <returns>A list of found types.</returns>
-        public IReadOnlyList<TypeSpec> FindTypesThatOnlyOnlyHaveDependenciesOnAll(IEnumerable<TypeSpec> input, IEnumerable<string> dependencies)
+        public IEnumerable<TypeSpec> FindTypesThatOnlyOnlyHaveDependenciesOnAll(IEnumerable<TypeSpec> input, IEnumerable<string> dependencies)
         {
             return FindTypes(input, TypeDefinitionCheckingResult.SearchType.OnlyHaveDependenciesOnAll, dependencies, false);
         }
 
-        private List<TypeSpec> FindTypes(IEnumerable<TypeSpec> input, TypeDefinitionCheckingResult.SearchType searchType, IEnumerable<string> dependencies, bool serachForDependencyInFieldConstant)
+        private IEnumerable<TypeSpec> FindTypes(IEnumerable<TypeSpec> input, TypeDefinitionCheckingResult.SearchType searchType, IEnumerable<string> dependencies, bool serachForDependencyInFieldConstant)
         {
             var output = new List<TypeSpec>();
             var searchTree = new CachedNamespaceTree(dependencies);