Skip to content

Commit 013981e

Browse files
committed
add default implementation for TypeHandler.CanBeVisualized
1 parent ad4550f commit 013981e

File tree

14 files changed

+19
-67
lines changed

14 files changed

+19
-67
lines changed

sources/RevitDBExplorer/Domain/DataModel/ValueContainers/Base/TypeHandler.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,10 @@ IEnumerable<SnoopableObject> ISnoop<T>.Snoop(SnoopableContext context, T value)
4747
{
4848
return Snooop(context, value) ?? Enumerable.Empty<SnoopableObject>();
4949
}
50-
protected virtual IEnumerable<SnoopableObject> Snooop(SnoopableContext context, T value) => null;
50+
protected virtual IEnumerable<SnoopableObject> Snooop(SnoopableContext context, T value)
51+
{
52+
yield return new SnoopableObject(context.Document, value);
53+
}
5154

5255

5356

sources/RevitDBExplorer/Domain/DataModel/ValueContainers/BoundarySegmentHandler.cs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,6 @@ internal class BoundarySegmentHandler : TypeHandler<BoundarySegment>
1313
protected override string ToLabel(SnoopableContext context, BoundarySegment boundarySegment)
1414
{
1515
return $"ID: {boundarySegment.ElementId}, {boundarySegment.GetCurve()?.Length} ft"; ;
16-
}
17-
18-
[CodeToString]
19-
protected override IEnumerable<SnoopableObject> Snooop(SnoopableContext context, BoundarySegment boundarySegment)
20-
{
21-
yield return new SnoopableObject(context.Document, boundarySegment);
22-
}
16+
}
2317
}
2418
}

sources/RevitDBExplorer/Domain/DataModel/ValueContainers/BoundingBoxXYZHandler.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@ protected override string ToLabel(SnoopableContext context, BoundingBoxXYZ box)
1717
return $"Min({box.Min.X:0.##}, {box.Min.Y:0.##}, {box.Min.Z:0.##}), Max({box.Max.X:0.##}, {box.Max.Y:0.##}, {box.Max.Z:0.##})";
1818
}
1919

20-
[CodeToString]
21-
protected override IEnumerable<SnoopableObject> Snooop(SnoopableContext context, BoundingBoxXYZ box)
22-
{
23-
yield return new SnoopableObject(context.Document, box);
24-
}
2520

2621
public string GetToolTip(SnoopableContext context, BoundingBoxXYZ value)
2722
{

sources/RevitDBExplorer/Domain/DataModel/ValueContainers/CategoryHandler.cs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,6 @@ internal sealed class CategoryHandler : TypeHandler<Category>
1313
protected override string ToLabel(SnoopableContext context, Category category)
1414
{
1515
return Labeler.GetLabelForObjectWithId(category.Name, category.Id.Value());
16-
}
17-
18-
[CodeToString]
19-
protected override IEnumerable<SnoopableObject> Snooop(SnoopableContext context, Category category)
20-
{
21-
yield return new SnoopableObject(context.Document, category);
22-
}
16+
}
2317
}
2418
}

sources/RevitDBExplorer/Domain/DataModel/ValueContainers/CurveHandler.cs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,7 @@ internal sealed class CurveHandler : TypeHandler<Curve>
1414
protected override bool CanBeSnoooped(SnoopableContext context, Curve curve) => true;
1515
protected override string ToLabel(SnoopableContext context, Curve curve) => curve.GetType()?.GetCSharpName();
1616

17-
[CodeToString]
18-
protected override IEnumerable<SnoopableObject> Snooop(SnoopableContext context, Curve curve)
19-
{
20-
yield return new SnoopableObject(context.Document, curve);
21-
}
17+
2218

2319
private readonly static Color StartColor = new Color(0, 255, 0);
2420
private readonly static Color EndColor = new Color(255, 0, 0);

sources/RevitDBExplorer/Domain/DataModel/ValueContainers/EdgeHandler.cs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,7 @@ internal sealed class EdgeHandler : TypeHandler<Edge>
1414
protected override bool CanBeSnoooped(SnoopableContext context, Edge edge) => true;
1515
protected override string ToLabel(SnoopableContext context, Edge edge) => edge.GetType()?.GetCSharpName();
1616

17-
[CodeToString]
18-
protected override IEnumerable<SnoopableObject> Snooop(SnoopableContext context, Edge edge)
19-
{
20-
yield return new SnoopableObject(context.Document, edge);
21-
}
22-
17+
2318

2419
private readonly static Color StartColor = new Color(0, 255, 0);
2520
private readonly static Color EndColor = new Color(255, 0, 0);

sources/RevitDBExplorer/Domain/DataModel/ValueContainers/FaceHandler.cs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,7 @@ internal sealed class FaceHandler : TypeHandler<Face>
1414
protected override bool CanBeSnoooped(SnoopableContext context, Face face) => true;
1515
protected override string ToLabel(SnoopableContext context, Face face) => face.GetType()?.GetCSharpName();
1616

17-
protected override IEnumerable<SnoopableObject> Snooop(SnoopableContext context, Face face)
18-
{
19-
yield return new SnoopableObject(context.Document, face);
20-
}
21-
17+
2218

2319
private readonly static Color FaceColor = new Color(80, 175, 228);
2420

sources/RevitDBExplorer/Domain/DataModel/ValueContainers/LocationHandler.cs

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace RevitDBExplorer.Domain.DataModel.ValueContainers
99
{
1010
internal class LocationHandler : TypeHandler<Location>
1111
{
12-
protected override bool CanBeSnoooped(SnoopableContext context, Location location) => location is not null;
12+
protected override bool CanBeSnoooped(SnoopableContext context, Location location) => true;
1313

1414
protected override string ToLabel(SnoopableContext context, Location location)
1515
{
@@ -34,11 +34,6 @@ protected override string ToLabel(SnoopableContext context, Location location)
3434

3535

3636
return $"{typeName} : {details}";
37-
}
38-
39-
protected override IEnumerable<SnoopableObject> Snooop(SnoopableContext context, Location location)
40-
{
41-
yield return new SnoopableObject(context.Document, location);
42-
}
37+
}
4338
}
4439
}

sources/RevitDBExplorer/Domain/DataModel/ValueContainers/ObjectHandler.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ namespace RevitDBExplorer.Domain.DataModel.ValueContainers
88
{
99
internal sealed class ObjectHandler : TypeHandler<object>
1010
{
11-
protected override bool CanBeSnoooped(SnoopableContext context, object @object) => @object is not null;
11+
protected override bool CanBeSnoooped(SnoopableContext context, object @object) => true;
1212
protected override string ToLabel(SnoopableContext context, object @object)
1313
{
1414
string name = @object.TryGetPropertyValue(propertyThatContainsName);
@@ -20,10 +20,7 @@ protected override string ToLabel(SnoopableContext context, object @object)
2020
}
2121
return $"{typeName}";
2222
}
23-
protected override IEnumerable<SnoopableObject> Snooop(SnoopableContext context, object @object)
24-
{
25-
yield return new SnoopableObject(context.Document, @object);
26-
}
23+
2724

2825

2926
private static readonly string[] propertyThatContainsName = new[] { "Name", "Title", "SchemaName", "FieldName" };

sources/RevitDBExplorer/Domain/DataModel/ValueContainers/PointHandler.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,9 @@ namespace RevitDBExplorer.Domain.DataModel.ValueContainers
1010
{
1111
class PointHandler : TypeHandler<Point>
1212
{
13-
protected override bool CanBeSnoooped(SnoopableContext context, Point point) => point is not null;
13+
protected override bool CanBeSnoooped(SnoopableContext context, Point point) => true;
1414
protected override string ToLabel(SnoopableContext context, Point point) => point.GetType()?.GetCSharpName();
15-
protected override IEnumerable<SnoopableObject> Snooop(SnoopableContext context, Point point)
16-
{
17-
yield return new SnoopableObject(context.Document, point);
18-
}
15+
1916

2017

2118

0 commit comments

Comments
 (0)