refactor: introduce more compact syntax for MembersOverrides and MembersTemplates

Author: NeVeSpl

sources/RevitDBExplorer/Domain/DataModel/Members/Base/DeclaringType.cs

@@ -16,10 +16,10 @@ internal class DeclaringType: IEquatable<DeclaringType>, IComparable<DeclaringTy
         public DocXml Documentation => documentation?.Value ?? DocXml.Empty;
 
 
-        private DeclaringType(string name, int level,  Func<DocXml> documentationFactoryMethod = null)
+        private DeclaringType(string name, int inheritanceLevel, Func<DocXml> documentationFactoryMethod = null)
         {
             Name = name;
-            InheritanceLevel = level;
+            InheritanceLevel = inheritanceLevel;
             if (documentationFactoryMethod != null)
             {
                 documentation = new Lazy<DocXml>(documentationFactoryMethod);

sources/RevitDBExplorer/Domain/DataModel/Members/Base/MemberKind.cs

@@ -2,5 +2,13 @@
 
 namespace RevitDBExplorer.Domain.DataModel.Members.Base
 {
-    internal enum MemberKind { Property, Method, StaticMethod, Extra, AsArgument, None }
+    internal enum MemberKind 
+    {
+        Property,
+        Method,
+        StaticMethod, 
+        Extra,
+        AsArgument,
+        None
+    }
 }

sources/RevitDBExplorer/Domain/DataModel/Members/Base/MemberOverride.cs

@@ -0,0 +1,37 @@
+using System;
+using System.Linq.Expressions;
+using Autodesk.Revit.DB;
+using RevitDBExplorer.Domain.DataModel.Accessors;
+using RevitDBExplorer.Domain.DataModel.Members.Accessors;
+
+// (c) Revit Database Explorer https://github.com/NeVeSpl/RevitDBExplorer/blob/main/license.md
+
+namespace RevitDBExplorer.Domain.DataModel.Members.Base
+{
+    internal interface IMemberOverride
+    {
+        public string UniqueId { get; }
+        public Func<IAccessor> MemberAccessorFactory { get; init; }
+    }
+
+
+
+    internal class MemberOverride<TForType> : IMemberOverride
+    {
+        public string UniqueId { get; init; }
+        public Func<IAccessor> MemberAccessorFactory { get; init; }
+                
+
+        public static IMemberOverride ByFunc<TReturnType>(Expression<Func<Document, TForType, TReturnType>> getter)
+        {
+            var compiledGetter = getter.Compile();
+            var uniqueId = getter.GetUniqueId();
+
+            return new MemberOverride<TForType>()
+            {
+                UniqueId = uniqueId,
+                MemberAccessorFactory = () => new MemberAccessorByFunc<TForType, TReturnType>(compiledGetter)
+            };            
+        }
+    }
+}

sources/RevitDBExplorer/Domain/DataModel/Members/Base/MemberTemplate.cs

@@ -0,0 +1,51 @@
+using System;
+using System.Linq.Expressions;
+using Autodesk.Revit.DB;
+using RevitDBExplorer.Domain.DataModel.Accessors;
+using RevitDBExplorer.Domain.DataModel.Members.Accessors;
+
+// (c) Revit Database Explorer https://github.com/NeVeSpl/RevitDBExplorer/blob/main/license.md
+
+namespace RevitDBExplorer.Domain.DataModel.Members.Base
+{
+    internal interface ISnoopableMemberTemplate
+    {
+        bool CanBeUsedWith(object @object);
+        MemberDescriptor Descriptor { get; }
+    }
+
+
+    internal sealed class MemberTemplate<TForType> : ISnoopableMemberTemplate
+    {
+        private Func<TForType, bool> CanBeUsedTyped { get; init; }
+        public MemberDescriptor Descriptor { get; init; }
+
+        public bool CanBeUsedWith(object @object)
+        {
+            if (CanBeUsedTyped != null)
+            {
+                Guard.IsAssignableToType<TForType>(@object);
+                return CanBeUsedTyped((TForType)@object);
+            }
+            return true;
+        }
+
+
+        public static ISnoopableMemberTemplate Create<TReturnType>(Expression<Func<Document, TForType, TReturnType>> getter, Func<TForType, bool> canBeUsed = null, MemberKind kind = MemberKind.StaticMethod)
+        {
+            var compiledGetter = getter.Compile();
+            var methodCallExpression = getter.Body as MethodCallExpression;
+            var memberAccessor = new MemberAccessorByFunc<TForType, TReturnType>(compiledGetter);
+
+            return Create(methodCallExpression.Method.DeclaringType, methodCallExpression.Method.Name, memberAccessor, canBeUsed, kind, () => RevitDocumentationReader.GetMethodComments(methodCallExpression.Method));
+        }
+        public static ISnoopableMemberTemplate Create(Type declaringType, string memberName, IAccessor memberAccessor, Func<TForType, bool> canBeUsed = null, MemberKind kind = MemberKind.StaticMethod, Func<DocXml> documentationFactoryMethod = null)
+        {
+            return new MemberTemplate<TForType>()
+            {
+                Descriptor = new MemberDescriptor(typeof(TForType), kind, memberName, declaringType, memberAccessor, documentationFactoryMethod),
+                CanBeUsedTyped = canBeUsed,
+            };
+        }
+    }
+}

sources/RevitDBExplorer/Domain/DataModel/Members/MemberAccessorFactory.cs

@@ -5,6 +5,7 @@
 using System.Reflection;
 using RevitDBExplorer.Domain.DataModel.Accessors;
 using RevitDBExplorer.Domain.DataModel.Members.Accessors;
+using RevitDBExplorer.Domain.DataModel.Members.Base;
 using RevitDBExplorer.Domain.DataModel.Members.Internals;
 
 
@@ -15,7 +16,7 @@ namespace RevitDBExplorer.Domain.DataModel.Members
     internal static class MemberAccessorFactory
     {
         private static readonly Dictionary<string, Func<IAccessor>> memberAccessorOverrides = new();
-
+        
 
         public static void Init()
         {
@@ -32,6 +33,16 @@ static MemberAccessorFactory()
                     memberAccessorOverrides[memberId] = accessor.GetType().CompileFactoryMethod<IAccessor>();
                 }
             }
+
+            var overridesCollections = GetAllInstancesThatImplement<IHaveMembersOverrides>();
+
+            foreach (var collection in overridesCollections)
+            {
+                foreach (var memberOverride in collection.GetOverrides())
+                {
+                    memberAccessorOverrides[memberOverride.UniqueId] = memberOverride.MemberAccessorFactory;
+                }
+            }
         }
         private static IEnumerable<T> GetAllInstancesThatImplement<T>() where T : class
         {
@@ -46,8 +57,8 @@ private static IEnumerable<T> GetAllInstancesThatImplement<T>() where T : class
         public static IAccessor CreateMemberAccessor(MethodInfo getMethod, MethodInfo setMethod)
         {
             var memberAccessor = CreateMemberAccessor(getMethod);
-            memberAccessor.UniqueId = getMethod.GetUniqueId();
 
+            memberAccessor.UniqueId = getMethod.GetUniqueId();
             if (string.IsNullOrEmpty(memberAccessor.DefaultInvocation.Syntax))
             {
                 memberAccessor.DefaultInvocation.Syntax = getMethod.GenerateInvocation();
@@ -61,7 +72,7 @@ private static IAccessor CreateMemberAccessor(MethodInfo getMethod)
             if (memberAccessorOverrides.TryGetValue(getMethod.GetUniqueId(), out Func<IAccessor> factory))
             {
                 return factory();
-            }
+            }            
 
             if (getMethod.IsStatic)
             {
@@ -102,6 +113,11 @@ private static IAccessor CreateMemberAccessor(MethodInfo getMethod)
 
     internal interface ICanCreateMemberAccessor
     {
-        IEnumerable<LambdaExpression> GetHandledMembers();
+        IEnumerable<LambdaExpression> GetHandledMembers();       
+    }
+
+    internal interface IHaveMembersOverrides
+    {
+        IEnumerable<IMemberOverride> GetOverrides();
     }
 }

sources/RevitDBExplorer/Domain/DataModel/Members/MemberStreamer.cs

@@ -33,14 +33,14 @@ public static IEnumerable<MemberDescriptor> StreamDescriptors(SnoopableContext c
             }
 
             var type = snoopableObject.GetType();
-            var cachableDescriptors = Cache_Descriptors.GetOrCreate(type, _ => StreamDescriptorsForPropsAndMethods(snoopableObject).ToArray());
+            var cachableDescriptors = Cache_DescriptorsForPropsAndMethods.GetOrCreate(type, _ => StreamDescriptorsForPropsAndMethods(snoopableObject).ToArray());
 
             foreach (var member in cachableDescriptors)
             {
                 yield return member;
             }
         }
-        private static readonly Dictionary<Type, IReadOnlyList<MemberDescriptor>> Cache_Descriptors = new();
+        private static readonly Dictionary<Type, IReadOnlyList<MemberDescriptor>> Cache_DescriptorsForPropsAndMethods = new();
 
         private static IEnumerable<MemberDescriptor> StreamDescriptorsForPropsAndMethods(object snoopableObject)
         {

sources/RevitDBExplorer/Domain/DataModel/Members/MemberStreamerForTemplates.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using RevitDBExplorer.Domain.DataModel.MembersTemplates.Base;
 using RevitDBExplorer.Domain.DataModel.Members.Base;
 
 // (c) Revit Database Explorer https://github.com/NeVeSpl/RevitDBExplorer/blob/main/license.md

sources/RevitDBExplorer/Domain/DataModel/MembersOverrides/Element/Element.cs

@@ -0,0 +1,17 @@
+using System.Collections.Generic;
+using Autodesk.Revit.DB;
+using RevitDBExplorer.Domain.DataModel.Members;
+using RevitDBExplorer.Domain.DataModel.Members.Base;
+
+// (c) Revit Database Explorer https://github.com/NeVeSpl/RevitDBExplorer/blob/main/license.md
+
+namespace RevitDBExplorer.Domain.DataModel.MembersOverrides
+{
+    internal class Element_Overrides : IHaveMembersOverrides
+    {
+        public IEnumerable<IMemberOverride> GetOverrides() =>
+        [
+            MemberOverride<Element>.ByFunc((document, element) => element.GetDependentElements(null)),
+        ];
+    }
+}