add unit tests for ValueContainers

Author: NeVeSpl

sources/RevitDBExplorer/Domain/DataModel/SnoopableObject.cs

@@ -138,7 +138,7 @@ public IEnumerable<DrawingVisual> GetVisualization()
         {
             if (Object is not null)
             {
-                var typeHandler = ValueContainerFactory.SelectTypeHandler(Object.GetType());  
+                var typeHandler = ValueContainerFactory.SelectTypeHandlerFor(Object.GetType());  
                 return typeHandler.GetVisualization(this.Context, Object);                
             }
             return Enumerable.Empty<DrawingVisual>();

sources/RevitDBExplorer/Domain/DataModel/ValueContainers/Base/ValueContainer.cs

@@ -8,11 +8,11 @@ namespace RevitDBExplorer.Domain.DataModel.ValueContainers.Base
 {
     internal sealed class ValueContainer<T> : IValueContainer
     {       
-        private static readonly ITypeHandler<T> typeHandler;
-        private Type nativeType;
+        private static readonly ITypeHandler<T> typeHandler;       
         private SnoopableContext context;
         private T value;
 
+
         public Type TypeHandlerType => typeHandler.GetType();
         public Type Type => typeHandler.Type;
         public T Value => value;       
@@ -21,15 +21,15 @@ public string TypeName
             get
             {
                 var typeHandlerName = typeHandler.GetTypeHandlerName(value);
-                string TypeName = typeHandlerName != "Object" ? typeHandlerName : $"Object : {nativeType?.GetCSharpName()}";
-                return TypeName;                
+                string typeName = typeHandlerName != "Object" ? typeHandlerName : $"Object : unknown";
+                return typeName;                
              }
         }
 
 
         static ValueContainer()
         {
-            typeHandler ??= ValueContainerFactory.SelectTypeHandler(typeof(T)) as ITypeHandler<T>;
+            typeHandler ??= ValueContainerFactory.SelectTypeHandlerFor(typeof(T)) as ITypeHandler<T>;
         }
         public ValueContainer()
         {

sources/RevitDBExplorer/Domain/DataModel/ValueContainers/Base/ValueContainerFactory.cs

@@ -7,9 +7,7 @@
 namespace RevitDBExplorer.Domain.DataModel.ValueContainers.Base
 {
     internal static class ValueContainerFactory
-    {        
-        //private static readonly bool RunStaticConstructorASAP = true;
-
+    {   
         private static readonly List<(Type type, Func<IValueContainer> factory)> FactoryMethodsForValueContainers = new List<(Type, Func<IValueContainer>)>();
         private static readonly ITypeHandler[] TypeHandlers = new ITypeHandler[]
         {
@@ -117,7 +115,7 @@ private static Func<IValueContainer> SelectValueContainerFactory(Type type)
 
 
         private static readonly Dictionary<Type, ITypeHandler> Cache_TypeHandlers = new();
-        public static ITypeHandler SelectTypeHandler(Type type)
+        public static ITypeHandler SelectTypeHandlerFor(Type type)
         {
             var typeHandler = Cache_TypeHandlers.GetOrCreate(type, SelectTypeHandlerInternal);         
             return typeHandler;

sources/RevitDBExplorer/Domain/Labeler.cs

@@ -15,7 +15,7 @@ public static string GetLabelForObject(object @object, SnoopableContext context)
         }
         public static string GetLabelForObject(Type type, object @object, SnoopableContext context)
         {
-            var valueType = ValueContainerFactory.SelectTypeHandler(type);          
+            var valueType = ValueContainerFactory.SelectTypeHandlerFor(type);          
             return valueType.ToLabel(context, @object);
         }
 

sources/RevitDBExplorer/RevitDBExplorer.csproj

@@ -2,7 +2,7 @@
 	<PropertyGroup>	
 		<TargetFramework>net48</TargetFramework>
 		<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
-		<LangVersion>11.0</LangVersion>
+		<LangVersion>latest</LangVersion>
 		<RevitYear>2024</RevitYear>
 		<AssemblyTitle>Revit database explorer</AssemblyTitle>
 		<Company>https://github.com/NeVeSpl/RevitDBExplorer</Company>

tests/RevitDBExplorer.Tests.csproj

@@ -7,11 +7,11 @@
   <ItemGroup>
 
     <Reference Include="RevitAPI">
-      <HintPath>..\binaries\revit\2023\RevitAPI.dll</HintPath>
+      <HintPath>..\binaries\revit\2025\RevitAPI.dll</HintPath>
       <Private>False</Private>
     </Reference>
     <Reference Include="RevitAPIUI">
-      <HintPath>..\binaries\revit\2023\RevitAPIUI.dll</HintPath>
+      <HintPath>..\binaries\revit\2025\RevitAPIUI.dll</HintPath>
       <Private>False</Private>
     </Reference>
   </ItemGroup>

tests/ValueContainersTests.cs

@@ -0,0 +1,67 @@
+using System;
+using System.IO;
+using Autodesk.Revit.DB;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+using RevitDBExplorer.Domain.DataModel;
+using RevitDBExplorer.Domain.DataModel.ValueContainers;
+using RevitDBExplorer.Domain.DataModel.ValueContainers.Base;
+using RevitTestLibrary;
+
+namespace RevitDBExplorer.Tests
+{
+    [TestClass]
+    public class ValueContainersTests
+    {
+        [RevitTestMethod]       
+        public void SelectTypeHandlerFor_BuiltInParameter(RevitContext revitContext)
+        {
+            var type = typeof(BuiltInParameter);
+            var typeHandler = ValueContainerFactory.SelectTypeHandlerFor(type);
+
+            Assert.AreEqual(typeof(EnumHandler<BuiltInParameter>), typeHandler.GetType());
+            Assert.AreEqual(typeof(BuiltInParameter), typeHandler.Type);
+        }
+
+        [RevitTestMethod]
+        public void SelectTypeHandlerFor_Long(RevitContext revitContext)
+        {
+            var type = typeof(long);
+            var typeHandler = ValueContainerFactory.SelectTypeHandlerFor(type);
+
+            Assert.AreEqual(typeof(ValueTypeHandler<long>), typeHandler.GetType());
+            Assert.AreEqual(typeof(long), typeHandler.Type);
+        }
+
+
+        [RevitTestMethod]
+        public void CreateValueContainerFor_BuiltInParameter(RevitContext revitContext)
+        {           
+            var document = OpenRevitFile(revitContext);
+
+            var type = typeof(BuiltInParameter);
+            var valueContainer = ValueContainerFactory.Create(type);
+            valueContainer.SetValue(new SnoopableContext() { Document = document }, BuiltInParameter.FUNCTION_PARAM);
+
+            Assert.AreEqual(typeof(ValueContainer<System.Enum>), valueContainer.GetType());
+            Assert.AreEqual(typeof(EnumHandler<System.Enum>), valueContainer.TypeHandlerType);
+            Assert.AreEqual(typeof(System.Enum), valueContainer.Type);
+           
+            Assert.AreEqual("Enum : BuiltInParameter", valueContainer.TypeName);
+            Assert.AreEqual("BuiltInParameter.FUNCTION_PARAM", valueContainer.ValueAsString);
+
+            
+
+            document.Close(false);
+        }
+
+
+
+
+        private Document OpenRevitFile(RevitContext revitContext)
+        {
+            var path = Path.Combine(revitContext.TestAssemblyLocation, @"..\..\..\assets\testmodel_rdq.rvt");
+            var document = revitContext.UIApplication.Application.OpenDocumentFile(path);
+            return document;
+        }
+    }
+}