refactoring

Author: NeVeSpl

sources/RevitDBExplorer/Application.cs

@@ -112,7 +112,7 @@ public static string GetMouseStatus()
         {
             var uiView = Application.UIView;
             var view = Application.View;
-            if ((uiView != null) && (view != null) && (view.IsValidObject) && (uiView.IsValidObject))
+            if ((uiView != null) && (view != null) && (view.IsValidObject) && (uiView.IsValidObject) && (view.DetailLevel != ViewDetailLevel.Undefined))
             {
                 // source : https://thebuildingcoder.typepad.com/blog/2012/10/uiview-windows-coordinates-referenceintersector-and-my-own-tooltip.html
 
@@ -148,7 +148,18 @@ public static string GetMouseStatus()
                         return "(,,?)";
                     }
 
-                    return $"({q.X:f3}, {q.Y:f3}, {q.Z:f3})";
+                    if (view.ViewDirection.IsParallelTo(XYZ.BasisX))
+                    {
+                        return $"(-,--, {q.Y:f3}, {q.Z:f3})";
+                    }
+                    if (view.ViewDirection.IsParallelTo(XYZ.BasisY))
+                    {
+                        return $"({q.X:f3}, -,--, {q.Z:f3})";
+                    }
+                    if (view.ViewDirection.IsParallelTo(XYZ.BasisZ))
+                    {
+                        return $"({q.X:f3}, {q.Y:f3}, -,--)";
+                    }
                 }
                 catch
                 {

sources/RevitDBExplorer/Domain/DataModel/ValueContainers/ElementHandler.cs

@@ -40,7 +40,7 @@ protected override IEnumerable<DrawingVisual> GetVisualization(SnoopableContext
         {            
             var bb = element.get_BoundingBox(null);
 
-            if ((bb != null) && (bb.IsSet))
+            if (bb != null && (bb.Max != null) && (bb.Min != null))
             {
                 yield return new BoundingBox(bb.Min, bb.Max);
             }            

sources/RevitDBExplorer/Domain/RevitDatabaseView/Cell.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Net.Http;
 using System.Net.Http.Json;
+using System.Reflection;
 using System.Threading.Tasks;
 
 // (c) Revit Database Explorer https://github.com/NeVeSpl/RevitDBExplorer/blob/main/license.md
@@ -9,10 +10,11 @@ namespace RevitDBExplorer.Domain
 {
     internal static class VersionChecker
     {
-        public async static Task<(bool, string)> Check(Version ver)
+        public async static Task<(bool, string)> CheckIfNewVersionIsAvailable()
         {
             try
             {
+                var ver = Assembly.GetExecutingAssembly().GetName().Version;
                 var curentVer = ver.ToGitHubTag();
 
                 var httpClient = new HttpClient();

sources/RevitDBExplorer/Domain/RevitDatabaseView/Column.cs

@@ -0,0 +1,26 @@
+using System;
+
+// (c) Revit Database Explorer https://github.com/NeVeSpl/RevitDBExplorer/blob/main/license.md
+
+namespace Autodesk.Revit.DB
+{
+    public static class XYZExtensions
+    {
+        public static bool IsParallelTo(this XYZ first, XYZ second)
+        {
+            return first.CrossProduct(second).IsZeroLength();
+        }
+
+        public static bool IsPerpendicularTo(this XYZ first, XYZ second)
+        {
+            return Math.Abs(first.DotProduct(second)) < 1e-6;
+        }
+
+        public static bool IsCodirectionalTo(this XYZ first, XYZ second)
+        {
+            var dotProduct = first.Normalize().DotProduct(second.Normalize());
+
+            return Math.Abs(dotProduct - 1.0) < 1e-6;
+        }
+    }
+}

sources/RevitDBExplorer/Domain/RevitDatabaseView/Row.cs

@@ -26,6 +26,7 @@
 using RevitDBExplorer.UIComponents.Trees.Base.Items;
 using RevitDBExplorer.UIComponents.Trees.Explorer;
 using RevitDBExplorer.UIComponents.Trees.Utility;
+using RevitDBExplorer.Utils;
 using RevitDBExplorer.WPF;
 using RevitDBExplorer.WPF.Controls;
 using RDQCommand = RevitDBExplorer.Domain.RevitDatabaseQuery.Parser.Command;
@@ -210,25 +211,29 @@ public MainWindow()
             listVM = new ListVM(this, this);
 
             InitializeComponent();
+            InitializeAsync().Forget();
+
             this.DataContext = this;
             rdscriptingVM = new RDScriptingVM();
             breadcrumbs = new BreadcrumbsVM();
 
-            var ver = GetType().Assembly.GetName().Version;
-            var revit_ver = typeof(Autodesk.Revit.DB.Element).Assembly.GetName().Version;
-            Title += $" 20{revit_ver.Major} - {ver.ToGitHubTag()}";
+            Title = WindowTitleGenerator.Get();
 
-            isRevitBusyDispatcher = new DispatcherTimer(TimeSpan.FromMilliseconds(500), DispatcherPriority.Background, IsRevitBusyDispatcher_Tick, Dispatcher.CurrentDispatcher);           
-            CheckIfNewVersionIsAvailable(ver).Forget();
+            isRevitBusyDispatcher = new DispatcherTimer(TimeSpan.FromMilliseconds(500), DispatcherPriority.Background, IsRevitBusyDispatcher_Tick, Dispatcher.CurrentDispatcher); 
 
             ExplorerTree.SelectedItemChanged += Tree_SelectedItemChanged;
-            ExplorerTree.ScriptForRDSHasChanged += RDSOpenWithCommand;
+            ExplorerTree.ScriptWasGenerated += RDSOpenWithCommand;
             UtilityTree.SelectedItemChanged += Tree_SelectedItemChanged;
-            UtilityTree.ScriptForRDSHasChanged += RDSOpenWithCommand;
+            UtilityTree.ScriptWasGenerated += RDSOpenWithCommand;
+
             OpenScriptingWithQueryCommand = new RelayCommand(RDSOpenWithQuery);
             SaveQueryAsFavoriteCommand = new RelayCommand(SaveQueryAsFavorite, x => !string.IsNullOrEmpty(DatabaseQuery) );
             rdvController = RevitDatabaseVisualizationFactory.CreateController();
         }
+        private async Task InitializeAsync()
+        {
+            (IsNewVerAvailable, NewVersionLink) = await VersionChecker.CheckIfNewVersionIsAvailable();
+        }
 
 
         private void IsRevitBusyDispatcher_Tick(object sender, EventArgs e)
@@ -251,14 +256,7 @@ private void Dispatcher_UnhandledException(object sender, DispatcherUnhandledExc
             e.Exception.ShowErrorMsg("MainWindow::UnhandledException");
             e.Handled = true;
         }
-        private async Task CheckIfNewVersionIsAvailable(Version ver)
-        {
-            (IsNewVerAvailable, var link) = await VersionChecker.Check(ver);
-            if (IsNewVerAvailable)
-            {
-                NewVersionLink = link;
-            }
-        }
+       
         private async void SelectorButton_Click(object sender, RoutedEventArgs e)
         {
             ExplorerTree.ClearItems();            
@@ -430,9 +428,9 @@ private void Window_Closed(object sender, EventArgs e)
             Dispatcher.UnhandledException -= Dispatcher_UnhandledException;           
             isRevitBusyDispatcher.Tick -= IsRevitBusyDispatcher_Tick;
             ExplorerTree.SelectedItemChanged -= Tree_SelectedItemChanged;
-            ExplorerTree.ScriptForRDSHasChanged -= RDSOpenWithCommand;
+            ExplorerTree.ScriptWasGenerated -= RDSOpenWithCommand;
             UtilityTree.SelectedItemChanged -= Tree_SelectedItemChanged;
-            UtilityTree.ScriptForRDSHasChanged -= RDSOpenWithCommand;
+            UtilityTree.ScriptWasGenerated -= RDSOpenWithCommand;
         }
         private void Window_Closing(object sender, EventArgs e)
         {