refactor: MemberAccessors continue the journey to a new home

Author: NeVeSpl

sources/RevitDBExplorer/Application.cs

@@ -9,7 +9,6 @@
 using Autodesk.Revit.UI;
 using RevitDBExplorer.Domain;
 using RevitDBExplorer.Domain.DataModel;
-using RevitDBExplorer.Domain.DataModel.MemberAccessors;
 using RevitDBExplorer.Domain.DataModel.Members;
 using RevitDBExplorer.Domain.DataModel.ValueContainers.Base;
 using RevitDBExplorer.Domain.RevitDatabaseQuery;

sources/RevitDBExplorer/Domain/DataModel/Accessors/IAccessor.cs

@@ -8,6 +8,7 @@ internal interface IAccessor
     {
         IValueViewModel CreatePresenter(SnoopableContext context, object @object);
         string UniqueId { get; set; }
-        string DefaultInvocation { get; set; }
+
+        Invocation DefaultInvocation { get; }      
     }
 }

sources/RevitDBExplorer/Domain/DataModel/Accessors/Invocation.cs

@@ -0,0 +1,12 @@
+using System.Collections.Generic;
+
+// (c) Revit Database Explorer https://github.com/NeVeSpl/RevitDBExplorer/blob/main/license.md
+
+namespace RevitDBExplorer.Domain.DataModel.Accessors
+{
+    internal class Invocation
+    {
+        public string Syntax { get; set; }
+        public Dictionary<string, string> Arguments { get; set; }
+    }
+}

sources/RevitDBExplorer/Domain/DataModel/Accessors/ReadResult.cs

@@ -5,10 +5,10 @@
 
 namespace RevitDBExplorer.Domain.DataModel.Accessors
 {
-    internal readonly ref struct ReadResult
+    internal ref struct ReadResult
     {
         public required string Label { get; init; }
-        public string AccessorName { get; init; }
+        public string AccessorName { get; set; }
         public required bool CanBeSnooped { get; init; } = false;
         public bool CanBeVisualized { get; init; } = false;
         public IValueContainer State { get; init; }
@@ -17,20 +17,10 @@ internal readonly ref struct ReadResult
         public ReadResult()
         {
 
-        }
-
+        }   
 
         [SetsRequiredMembers]
-        public ReadResult(string label, string accessorName, bool canBeSnooped, IValueContainer state = null)
-        {
-            Label = label;
-            AccessorName = accessorName;
-            CanBeSnooped = canBeSnooped;
-            State = state;
-        }
-
-        [SetsRequiredMembers]
-        public ReadResult(string label, string accessorName, bool canBeSnooped = false, bool canBeVisualized = false, IValueContainer state = null)
+        public ReadResult(string label, string accessorName = null, bool canBeSnooped = false, bool canBeVisualized = false, IValueContainer state = null)
         {
             Label = label;
             AccessorName = accessorName;
@@ -39,6 +29,7 @@ public ReadResult(string label, string accessorName, bool canBeSnooped = false,
             State = state;
         }
 
-        public static ReadResult Forbidden => new ReadResult("<access denied / forbidden>", null, false, null);
+
+        public static ReadResult Forbidden => new ReadResult("<access denied / forbidden>");
     }
 }

sources/RevitDBExplorer/Domain/DataModel/MemberAccessors/AssetProperties/AssetProperties_Item.cs

@@ -2,6 +2,7 @@
 using System.Linq.Expressions;
 using Autodesk.Revit.DB.Visual;
 using RevitDBExplorer.Domain.DataModel.Accessors;
+using RevitDBExplorer.Domain.DataModel.Members;
 using RevitDBExplorer.Domain.DataModel.Members.Accessors;
 
 // (c) Revit Database Explorer https://github.com/NeVeSpl/RevitDBExplorer/blob/main/license.md
@@ -13,12 +14,13 @@ internal class AssetProperties_Item : MemberAccessorByType<AssetProperties>, ICa
         IEnumerable<LambdaExpression> ICanCreateMemberAccessor.GetHandledMembers() => [ (AssetProperties x) => x[0] ];
 
 
-        public override ReadResult Read(SnoopableContext context, AssetProperties assetProperties) => new()
+        protected override ReadResult Read(SnoopableContext context, AssetProperties assetProperties) => new()
         {
             Label = Labeler.GetLabelForCollection(nameof(AssetProperty), assetProperties.Size),
             CanBeSnooped = assetProperties.Size > 0
         };
 
+
         protected override IEnumerable<SnoopableObject> Snoop(SnoopableContext context, AssetProperties assetProperties)
         {            
             for (int i = 0; i < assetProperties.Size; i++)

sources/RevitDBExplorer/Domain/DataModel/MemberAccessors/CurtainGrid/CurtainGrid_GetCell.cs

@@ -2,6 +2,7 @@
 using System.Linq.Expressions;
 using Autodesk.Revit.DB;
 using RevitDBExplorer.Domain.DataModel.Accessors;
+using RevitDBExplorer.Domain.DataModel.Members;
 using RevitDBExplorer.Domain.DataModel.Members.Accessors;
 
 // (c) Revit Database Explorer https://github.com/NeVeSpl/RevitDBExplorer/blob/main/license.md
@@ -13,13 +14,13 @@ internal class CurtainGrid_GetCell : MemberAccessorByType<CurtainGrid>, ICanCrea
         IEnumerable<LambdaExpression> ICanCreateMemberAccessor.GetHandledMembers() => [ (CurtainGrid x) => x.GetCell(ElementId.InvalidElementId, ElementId.InvalidElementId) ];
 
 
-        public override ReadResult Read(SnoopableContext context, CurtainGrid grid) => new()
+        protected override ReadResult Read(SnoopableContext context, CurtainGrid grid) => new()
         {
             Label = Labeler.GetLabelForCollection(nameof(CurtainCell), null),
             CanBeSnooped = true
         };
 
-       
+
         protected override IEnumerable<SnoopableObject> Snoop(SnoopableContext context, CurtainGrid grid)
         {
             var uLineIds = grid.GetUGridLineIds();

sources/RevitDBExplorer/Domain/DataModel/MemberAccessors/CurtainGrid/CurtainGrid_GetPanel.cs

@@ -2,6 +2,7 @@
 using System.Linq.Expressions;
 using Autodesk.Revit.DB;
 using RevitDBExplorer.Domain.DataModel.Accessors;
+using RevitDBExplorer.Domain.DataModel.Members;
 using RevitDBExplorer.Domain.DataModel.Members.Accessors;
 
 // (c) Revit Database Explorer https://github.com/NeVeSpl/RevitDBExplorer/blob/main/license.md
@@ -13,7 +14,7 @@ internal class CurtainGrid_GetPanel : MemberAccessorByType<CurtainGrid>, ICanCre
         IEnumerable<LambdaExpression> ICanCreateMemberAccessor.GetHandledMembers() => [ (CurtainGrid x) => x.GetPanel(ElementId.InvalidElementId, ElementId.InvalidElementId) ];
 
 
-        public override ReadResult Read(SnoopableContext context, CurtainGrid grid) => new()
+        protected override ReadResult Read(SnoopableContext context, CurtainGrid grid) => new()
         {
             Label = Labeler.GetLabelForCollection(nameof(Panel), null),
             CanBeSnooped = true

sources/RevitDBExplorer/Domain/DataModel/MemberAccessors/Curve/Curve_GetEndPoint.cs

@@ -2,6 +2,7 @@
 using System.Linq.Expressions;
 using Autodesk.Revit.DB;
 using RevitDBExplorer.Domain.DataModel.Accessors;
+using RevitDBExplorer.Domain.DataModel.Members;
 using RevitDBExplorer.Domain.DataModel.Members.Accessors;
 
 // (c) Revit Database Explorer https://github.com/NeVeSpl/RevitDBExplorer/blob/main/license.md
@@ -13,12 +14,12 @@ internal class Curve_GetEndPoint : MemberAccessorByType<Curve>, ICanCreateMember
         IEnumerable<LambdaExpression> ICanCreateMemberAccessor.GetHandledMembers() => [ (Curve x) => x.GetEndPoint(0) ];
 
 
-        public override ReadResult Read(SnoopableContext context, Curve curve) => new()
+        protected override ReadResult Read(SnoopableContext context, Curve curve) => new()
         {
             Label = GetLabel(curve),
             CanBeSnooped = curve.IsBound
         };        
-        private string GetLabel(Curve curve)
+        private static string GetLabel(Curve curve)
         {
             var p0 = curve.GetEndPoint(0);
             var p1 = curve.GetEndPoint(1);

sources/RevitDBExplorer/Domain/DataModel/MemberAccessors/DialogBoxShowingEventArgs/DialogBoxShowingEventArgs_OverrideResult.cs

@@ -2,6 +2,7 @@
 using System.Linq.Expressions;
 using Autodesk.Revit.UI.Events;
 using RevitDBExplorer.Domain.DataModel.Accessors;
+using RevitDBExplorer.Domain.DataModel.Members;
 using RevitDBExplorer.Domain.DataModel.Members.Accessors;
 
 // (c) Revit Database Explorer https://github.com/NeVeSpl/RevitDBExplorer/blob/main/license.md
@@ -13,7 +14,7 @@ internal class DialogBoxShowingEventArgs_OverrideResult : MemberAccessorByType<D
         IEnumerable<LambdaExpression> ICanCreateMemberAccessor.GetHandledMembers() => [ (DialogBoxShowingEventArgs x) => x.OverrideResult(0) ];
 
 
-        public override ReadResult Read(SnoopableContext context, DialogBoxShowingEventArgs value) => ReadResult.Forbidden;
+        protected override ReadResult Read(SnoopableContext context, DialogBoxShowingEventArgs value) => ReadResult.Forbidden;
 
     }
 }

sources/RevitDBExplorer/Domain/DataModel/MemberAccessors/Document/Document_Close.cs

@@ -2,6 +2,7 @@
 using System.Linq.Expressions;
 using Autodesk.Revit.DB;
 using RevitDBExplorer.Domain.DataModel.Accessors;
+using RevitDBExplorer.Domain.DataModel.Members;
 using RevitDBExplorer.Domain.DataModel.Members.Accessors;
 
 // (c) Revit Database Explorer https://github.com/NeVeSpl/RevitDBExplorer/blob/main/license.md
@@ -13,6 +14,6 @@ internal class Document_Close : MemberAccessorByType<Document>, ICanCreateMember
         IEnumerable<LambdaExpression> ICanCreateMemberAccessor.GetHandledMembers() => [ (Document x) => x.Close(), (Document x) => x.Close(true) ];
 
 
-        public override ReadResult Read(SnoopableContext context, Document value) => ReadResult.Forbidden;
+        protected override ReadResult Read(SnoopableContext context, Document value) => ReadResult.Forbidden;
     }
 }