Updating Cynosure branch to compile on current Neb dev.

Work on getting the Cynosure map to playable state. This is a squash of multiple commits, important changes are listed below:
- Fixes roundstart power, and in general improves the power system by using a code-defined SMES presets for each function. Modifies SMES code to not include an extra coil in every SMES.
- Fixes networking/telecommunications. Currently has a form of small room next to the Site Administrator's office (where SA's private bathroom was) with all the necessary equipment. This may be relocated to a more permanent place in the future. Also maps in bunch of relays all around the station (these are like WiFi antennas for pretty much everything)
- Copies over telecommunication channels from the Exodus map (may be modified in the future, if needed). Radios now work.
- Removes the telecommunications satellite Z level altogether, as it is completely incompatible with the new networking and radio system.
- Fixes inability to late-join by mapping in Arrivals landmarks. Currently not using the original moving shuttle, instead you spawn next to the airlock where the shuttle docked.
- Reactor cold loop is no longer 'accidentally' connected to the station's distribution loop via a misplaced valve. While this was indeed a very innovative and effective central heating solution, staff has complained of 1000°C air coming out of vents.
- Drops outdoor temperature to -5°C
- Refactors all on-station areas to follow a common naming scheme - /area/cynosure/(type/department)/(floor)/(area name)
- Replace substation scrubber valves with open variants
- Fix leaking pipes in Research, which tripped the shutoff valves
- Fix probably all airlocks on the station
- Fix/Setup the Cargo, Emergency and Escape Pod shuttles.

Area permissions, new areas icons (#2)

* Fixed secure access for all departments, added new access operator: Opion to unsecure areas inside secure areas
* Added missing new icon file
* fixed access for jobs, added job overrides for cynosure
* fixed access merge
* fixed prison access
* Merged job overrides to one file

Ore box + Unloader fix
- Fix unloader not updating ore box on-examine contents when removing ores
- Tweak ore box examine to skip ores that have 0 pieces contained in the box.

Assorted cynosure map fixes
- Fix miners not having access to their own locker room
- Remapped refinery room to use the new machines
- Added assorted circuit boards to tech storage
- Fix atmospherics holding tank computers as well as the supermatter computer not being linked to their vents/injectors/sensors.

Fixed signs and lights (#3)

Shutter and button fixes (#4)

* Fixed signs and lights

* Shutter fixes, directional signs fixes, surgery holosign fixes, blast door button fixes

Updating Cynosure to compile on current Neb.

Co-authored-by: Atlantis <git@stepanekjakub.cz>
Co-authored-by: woody41 <26313915+woody41@users.noreply.github.com>

Author: 3 people

.github/workflows/test.yml

@@ -100,7 +100,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        map_path: [example, tradeship, exodus, ministation, shaded_hills, away_sites_testing, modpack_testing, planets_testing]
+        map_path: [example, tradeship, exodus, ministation, shaded_hills, cynosure, away_sites_testing, modpack_testing, planets_testing]
     steps:
       - uses: actions/checkout@v3
       - name: Setup Cache

code/__defines/definition_helpers.dm

@@ -1,4 +1,72 @@
 /**Define a poster's decl and its mapper type */
 #define DEFINE_POSTER(TYPENAME, ICONSTATE, NAME, DESC)\
 /decl/poster_design/##TYPENAME{name = NAME; desc = DESC; icon_state = ICONSTATE;};\
-/obj/structure/sign/poster/##TYPENAME{poster_design = /decl/poster_design/##TYPENAME; name = NAME; icon_state = ICONSTATE;};
+/obj/structure/sign/poster/##TYPENAME{poster_design = /decl/poster_design/##TYPENAME; name = NAME; icon_state = ICONSTATE;};
+
+// Defines an escape pod shuttle datum and all relevant landmarks.
+#define DEFINE_ESCAPE_POD(NAME, ID) \
+/datum/shuttle/autodock/ferry/escape_pod/pod_##ID { \
+	shuttle_area = /area/shuttle/escape_pod_##ID; \
+	name = "Escape Pod " + #NAME; \
+	dock_target = "escape_pod_" + #ID; \
+	arming_controller = "escape_pod_"+ #ID +"_berth"; \
+	waypoint_station = "escape_pod_"+ #ID +"_start"; \
+	landmark_transition = "escape_pod_"+ #ID +"_transit"; \
+	waypoint_offsite = "escape_pod_"+ #ID +"_out"; \
+} \
+/obj/effect/shuttle_landmark/escape_pod/start/pod_##ID { \
+	landmark_tag = "escape_pod_"+ #ID +"_start"; \
+	docking_controller = "escape_pod_"+ #ID +"_berth"; \
+} \
+/obj/effect/shuttle_landmark/escape_pod/transit/pod_##ID { \
+	landmark_tag = "escape_pod_"+ #ID +"_transit"; \
+} \
+/obj/effect/shuttle_landmark/escape_pod/out/pod_##ID { \
+	landmark_tag = "escape_pod_"+ #ID +"_out"; \
+} \
+/area/shuttle/escape_pod_##ID { \
+	name = "Escape Pod " + #NAME; \
+	area_flags = AREA_FLAG_RAD_SHIELDED | AREA_FLAG_ION_SHIELDED | AREA_FLAG_IS_NOT_PERSISTENT; \
+}
+
+#define DEFINE_STACK_SUBTYPES(MAT_ID, MAT_NAME, MAT_TYPE, STACK_TYPE, REINF_TYPE) \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID {                    \
+	name = "1 " + MAT_NAME;                                                \
+	material = /decl/material/MAT_TYPE;                                    \
+	reinf_material = REINF_TYPE;                                           \
+	amount = 1;                                                            \
+	is_spawnable_type = TRUE;                                              \
+	color = parent_type::paint_color || /decl/material/MAT_TYPE::color;    \
+}                                                                          \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID/five {               \
+	name = "5 " + MAT_NAME;                                                \
+	amount = 5;                                                            \
+}                                                                          \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID/ten {                \
+	name = "10 " + MAT_NAME;                                               \
+	amount = 10;                                                           \
+}                                                                          \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID/fifteen {            \
+	name = "15 " + MAT_NAME;                                               \
+	amount = 15;                                                           \
+}                                                                          \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID/twenty {             \
+	name = "20 " + MAT_NAME;                                               \
+	amount = 20;                                                           \
+}                                                                          \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID/twentyfive {         \
+	name = "25 " + MAT_NAME;                                               \
+	amount = 25;                                                           \
+}                                                                          \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID/thirty {             \
+	name = "30 " + MAT_NAME;                                               \
+	amount = 30;                                                           \
+}                                                                          \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID/forty {              \
+	name = "40 " + MAT_NAME;                                               \
+	amount = 40;                                                           \
+}                                                                          \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID/fifty {              \
+	name = "50 " + MAT_NAME;                                               \
+	amount = 50;                                                           \
+}

code/__defines/guns.dm

@@ -24,7 +24,6 @@
 #define SPEEDLOADER 	2	//Transfers casings from the mag to the gun when used.
 #define MAGAZINE 		4	//The magazine item itself goes inside the gun
 
-
 #define GUN_BULK_RIFLE  5
 
 #define BULLET_IMPACT_NONE  "none"

code/controllers/evacuation/evacuation.dm

@@ -91,9 +91,8 @@
 				A.readyalert()
 		if(!skip_announce)
 			global.using_map.emergency_shuttle_called_announcement()
-	else
-		if(!skip_announce)
-			priority_announcement.Announce(replacetext(replacetext(global.using_map.shuttle_called_message, "%dock_name%", "[global.using_map.dock_name]"),  "%ETA%", "[round(get_eta()/60)] minute\s"))
+	else if(!skip_announce && global.using_map.shuttle_called_message)
+		priority_announcement.Announce(replacetext(replacetext(global.using_map.shuttle_called_message, "%dock_name%", "[global.using_map.dock_name]"),  "%ETA%", "[round(get_eta()/60)] minute\s"))
 
 	return 1
 
@@ -113,12 +112,13 @@
 	auto_recall_time =  null
 
 	if(emergency_evacuation)
-		evac_recalled.Announce(global.using_map.emergency_shuttle_recall_message)
+		if(global.using_map.emergency_shuttle_recall_message)
+			evac_recalled.Announce(global.using_map.emergency_shuttle_recall_message)
 		for(var/area/A in global.areas)
 			if(istype(A) && (A.area_flags & AREA_FLAG_HALLWAY))
 				A.readyreset()
 		emergency_evacuation = 0
-	else
+	else if(global.using_map.shuttle_recall_message)
 		priority_announcement.Announce(global.using_map.shuttle_recall_message)
 
 	return 1

code/controllers/evacuation/evacuation_lifepods.dm

@@ -17,7 +17,9 @@
 	if(waiting_to_leave())
 		return
 	state = EVAC_IN_TRANSIT
-	priority_announcement.Announce(replacetext(replacetext(global.using_map.emergency_shuttle_leaving_dock, "%dock_name%", "[global.using_map.dock_name]"),  "%ETA%", "[round(get_eta()/60,1)] minute\s"))
+	var/msg = global.using_map.emergency_shuttle_leaving_dock
+	if(msg)
+		priority_announcement.Announce(replacetext(replacetext(msg, "%dock_name%", "[global.using_map.dock_name]"),  "%ETA%", "[round(get_eta()/60,1)] minute\s"))
 	return 1
 
 /datum/evacuation_controller/lifepods/available_evac_options()

code/game/area/area_access.dm

@@ -1,6 +1,7 @@
 /area
 	var/list/req_access = list()
 	var/secure = FALSE    // unsecure areas will have doors between them use access diff; secure ones use union.
+	var/override_unlock = FALSE // TRUE will override area and will be always unlocked. This is e.g. for restrooms inside secure areas, surgery observation room etc.
 
 // Given two areas, find the minimal req_access needed such that (return value) + (area access) >= (other area access) and vice versa
 /proc/req_access_diff(area/first, area/second)

code/game/jobs/access_datum.dm

@@ -58,6 +58,12 @@ var/global/const/access_tox_storage = "ACCESS_TOX_STORAGE" //8
 	desc = "Toxins Lab"
 	region = ACCESS_REGION_RESEARCH
 
+var/global/const/access_warden = "ACCESS_WARDEN" //9
+/datum/access/warden
+	id = access_warden
+	desc = "Warden Office"
+	region = ACCESS_REGION_SECURITY
+
 var/global/const/access_engine = "ACCESS_ENGINEERING" //10
 /datum/access/engine
 	id = access_engine
@@ -268,12 +274,6 @@ var/global/const/access_research = "ACCESS_RESEARCH" //47
 	desc = "Science"
 	region = ACCESS_REGION_RESEARCH
 
-var/global/const/access_explorer = "ACCESS_EXPLORER"
-/datum/access/explorer
-	id = access_explorer
-	desc = "Explorer"
-	region = ACCESS_REGION_GENERAL
-
 var/global/const/access_mining = "ACCESS_MINING" //48
 /datum/access/mining
 	id = access_mining
@@ -310,12 +310,6 @@ var/global/const/access_xenobiology = "ACCESS_XENOBIO" //55
 	desc = "Xenobiology Lab"
 	region = ACCESS_REGION_RESEARCH
 
-var/global/const/access_xenofauna = "ACCESS_XENOFAUNA"
-/datum/access/xenofauna
-	id = access_xenofauna
-	desc = "Xenfauna Lab"
-	region = ACCESS_REGION_RESEARCH
-
 var/global/const/access_ce = "ACCESS_CHIEF_ENGINEER" //56
 /datum/access/ce
 	id = access_ce

code/game/jobs/job/_job.dm

@@ -67,6 +67,12 @@
 
 /datum/job/New()
 
+	for(var/title in alt_titles)
+		if(ispath(title, /decl/alt_title))
+			var/decl/alt_title/title_data = GET_DECL(title)
+			alt_titles -= title
+			alt_titles[title_data.name] = title_data.outfit
+
 	if(type == /datum/job && global.using_map.default_job_type == type)
 		title = "Debug Job"
 		hud_icon_state = "hudblank"

code/game/machinery/alarm.dm

@@ -1123,3 +1123,15 @@ FIRE ALARM
 
 	if(. == TOPIC_REFRESH)
 		interact(user)
+
+/obj/machinery/alarm/outside/Initialize(mapload, dir)
+	..()
+	return INITIALIZE_HINT_LATELOAD
+
+// TODO: Automatically set to expected exterior conditions.
+/*
+/obj/machinery/alarm/outside/LateInitialize()
+	. = ..()
+	if(isatom(loc) && loc.z)
+		var/datum/level_data/level = SSmapping.levels_by_z[loc.z]
+*/

code/game/machinery/atmoalter/canister.dm

@@ -82,10 +82,11 @@
 	start_gas      = /decl/material/gas/hydrogen
 
 /obj/machinery/portable_atmospherics/canister/phoron
-	name = "\improper Canister \[Phoron\]"
-	icon_state = "orange"
-	canister_color = "orange"
-	can_label = 0
+	name           = "phoron canister"
+	icon_state     = "purple"
+	canister_color = "purple"
+	can_label      = FALSE
+	start_gas      = /decl/material/solid/phoron
 
 /obj/machinery/portable_atmospherics/canister/carbon_dioxide
 	name           = "\improper CO2 canister"