Make gases use alist

Author: out-of-phaze

code/__defines/_byond_version_compat.dm

@@ -1,5 +1,5 @@
-#define REQUIRED_DM_VERSION 515
+#define REQUIRED_DM_VERSION 516
 
 #if DM_VERSION < REQUIRED_DM_VERSION
-#warn Nebula is not tested on BYOND versions older than 515. The code may not compile, and if it does compile it may have severe problems.
+#warn Nebula is not tested on BYOND versions older than 516. The code may not compile, and if it does compile it may have severe problems.
 #endif

code/__defines/math_physics.dm

@@ -27,7 +27,7 @@
 #define ATM *ONE_ATMOSPHERE
 
 #define ATMOS_PRECISION 0.0001
-#define QUANTIZE(variable) (round(variable, ATMOS_PRECISION))
+#define QUANTIZE(variable) (NONUNIT_FLOOR(variable, ATMOS_PRECISION))
 
 #define INFINITY	1.#INF
 

code/_helpers/lists.dm

@@ -272,6 +272,13 @@ Checks if a list has the same entries and values as an element of big.
 		else
 			.[key] = call(merge_method)(.[key], b_value)
 
+// Picks a key in an alist. This is awful but hey, what can you do?
+/proc/apick(alist/target_alist)
+	var/index = rand(1, length(target_alist))
+	for(var/key in target_alist)
+		if(--index == 0)
+			return key
+
 //Pretends to pick an element based on its weight but really just seems to pick a random element.
 /proc/pickweight(list/target_list)
 	var/total = 0

code/game/machinery/air_sensor.dm

@@ -46,9 +46,9 @@
 	if(total_moles <= 0)
 		return
 	. = list()
-	for(var/gas in air_sample.gas)
-		var/decl/material/mat = GET_DECL(gas)
-		var/gaspercent = round(air_sample.gas[gas]*100/total_moles,0.01)
+	for(var/gas_type, gas_amount in air_sample.gas)
+		var/decl/material/mat = GET_DECL(gas_type)
+		var/gaspercent = round(gas_amount*100/total_moles,0.01)
 		var/gas_list = list("symbol" = mat.gas_symbol_html, "percent" = gaspercent)
 		. += list(gas_list)
 

code/game/machinery/atmoalter/portable_atmospherics.dm

@@ -12,9 +12,9 @@
 
 /obj/machinery/portable_atmospherics/get_single_monetary_worth()
 	. = ..()
-	for(var/gas in air_contents?.gas)
-		var/decl/material/gas_data = GET_DECL(gas)
-		. += gas_data.get_value() * air_contents.gas[gas] * GAS_WORTH_MULTIPLIER
+	for(var/gas_type, gas_amount in air_contents?.gas)
+		var/decl/material/gas_data = GET_DECL(gas_type)
+		. += gas_data.get_value() * gas_amount * GAS_WORTH_MULTIPLIER
 	. = max(1, round(.))
 
 /obj/machinery/portable_atmospherics/Initialize()

code/game/objects/effects/spawners/bombspawner.dm

@@ -75,15 +75,15 @@
 	OT.master = V
 
 	PT.valve_welded = TRUE
-	PT.air_contents.gas = list()
+	PT.air_contents.gas = alist()
 	PT.air_contents.gas[accelerant_type] = accelerant_amount
 	PT.air_contents.gas[filler_type] = filler_amount
 	PT.air_contents.total_moles = accelerant_amount + filler_amount
 	PT.air_contents.temperature = FLAMMABLE_GAS_MINIMUM_BURN_TEMPERATURE+1
 	PT.air_contents.update_values()
 
 	OT.valve_welded = TRUE
-	OT.air_contents.gas = list()
+	OT.air_contents.gas = alist()
 	OT.air_contents.gas[oxidizer_type] = oxidizer_amount
 	OT.air_contents.total_moles = oxidizer_amount
 	OT.air_contents.temperature = FLAMMABLE_GAS_MINIMUM_BURN_TEMPERATURE+1

code/game/objects/items/weapons/tanks/tanks.dm

@@ -80,9 +80,9 @@ var/global/list/global/tank_gauge_cache = list()
 
 /obj/item/tank/get_single_monetary_worth()
 	. = ..()
-	for(var/gas in air_contents?.gas)
-		var/decl/material/gas_data = GET_DECL(gas)
-		. += gas_data.get_value() * air_contents.gas[gas] * GAS_WORTH_MULTIPLIER
+	for(var/gas_type, gas_amount in air_contents?.gas)
+		var/decl/material/gas_data = GET_DECL(gas_type)
+		. += gas_data.get_value() * gas_amount * GAS_WORTH_MULTIPLIER
 	. = max(1, round(.))
 
 /obj/item/tank/get_examine_strings(mob/user, distance, infix, suffix)

code/game/objects/structures/fires.dm

@@ -151,8 +151,8 @@
 
 /obj/structure/fire_source/proc/check_atmos()
 	var/datum/gas_mixture/GM = loc?.return_air()
-	for(var/g in GM?.gas)
-		var/decl/material/oxidizer = GET_DECL(g)
+	for(var/gas_type in GM?.gas)
+		var/decl/material/oxidizer = GET_DECL(gas_type)
 		if(oxidizer.gas_flags & XGM_GAS_OXIDIZER)
 			return TRUE
 

code/game/turfs/floors/subtypes/floor_circuit.dm

@@ -25,7 +25,7 @@
 	temperature = TCMB
 
 /turf/floor/greengrid/nitrogen
-	initial_gas = list(/decl/material/gas/nitrogen = MOLES_N2STANDARD)
+	initial_gas = alist(/decl/material/gas/nitrogen = MOLES_N2STANDARD)
 
 /turf/floor/blackgrid
 	name        = "mainframe floor"

code/game/turfs/floors/subtypes/floor_reinforced.dm

@@ -8,32 +8,32 @@
 	initial_gas = null
 
 /turf/floor/reinforced/airmix
-	initial_gas = list(
+	initial_gas = alist(
 		/decl/material/gas/oxygen = MOLES_O2ATMOS,
 		/decl/material/gas/nitrogen = MOLES_N2ATMOS
 	)
 
 /turf/floor/reinforced/nitrogen
-	initial_gas = list(/decl/material/gas/nitrogen = ATMOSTANK_NITROGEN)
+	initial_gas = alist(/decl/material/gas/nitrogen = ATMOSTANK_NITROGEN)
 
 /turf/floor/reinforced/hydrogen
-	initial_gas = list(/decl/material/gas/hydrogen = ATMOSTANK_HYDROGEN)
+	initial_gas = alist(/decl/material/gas/hydrogen = ATMOSTANK_HYDROGEN)
 
 /turf/floor/reinforced/oxygen
-	initial_gas = list(/decl/material/gas/oxygen = ATMOSTANK_OXYGEN)
+	initial_gas = alist(/decl/material/gas/oxygen = ATMOSTANK_OXYGEN)
 
 /turf/floor/reinforced/nitrogen/engine
 	name        = "engine floor"
-	initial_gas = list(/decl/material/gas/nitrogen = MOLES_N2STANDARD)
+	initial_gas = alist(/decl/material/gas/nitrogen = MOLES_N2STANDARD)
 
 /turf/floor/reinforced/hydrogen/fuel
-	initial_gas = list(/decl/material/gas/hydrogen = ATMOSTANK_HYDROGEN_FUEL)
+	initial_gas = alist(/decl/material/gas/hydrogen = ATMOSTANK_HYDROGEN_FUEL)
 
 /turf/floor/reinforced/carbon_dioxide
-	initial_gas = list(/decl/material/gas/carbon_dioxide = ATMOSTANK_CO2)
+	initial_gas = alist(/decl/material/gas/carbon_dioxide = ATMOSTANK_CO2)
 
 /turf/floor/reinforced/n20
-	initial_gas = list(/decl/material/gas/nitrous_oxide = ATMOSTANK_NITROUSOXIDE)
+	initial_gas = alist(/decl/material/gas/nitrous_oxide = ATMOSTANK_NITROUSOXIDE)
 
 /turf/floor/reinforced/airless
 	name        = "vacuum floor"