Updating Cynosure branch to compile on current Neb dev.

Work on getting the Cynosure map to playable state. This is a squash of multiple commits, important changes are listed below:
- Fixes roundstart power, and in general improves the power system by using a code-defined SMES presets for each function. Modifies SMES code to not include an extra coil in every SMES.
- Fixes networking/telecommunications. Currently has a form of small room next to the Site Administrator's office (where SA's private bathroom was) with all the necessary equipment. This may be relocated to a more permanent place in the future. Also maps in bunch of relays all around the station (these are like WiFi antennas for pretty much everything)
- Copies over telecommunication channels from the Exodus map (may be modified in the future, if needed). Radios now work.
- Removes the telecommunications satellite Z level altogether, as it is completely incompatible with the new networking and radio system.
- Fixes inability to late-join by mapping in Arrivals landmarks. Currently not using the original moving shuttle, instead you spawn next to the airlock where the shuttle docked.
- Reactor cold loop is no longer 'accidentally' connected to the station's distribution loop via a misplaced valve. While this was indeed a very innovative and effective central heating solution, staff has complained of 1000°C air coming out of vents.
- Drops outdoor temperature to -5°C
- Refactors all on-station areas to follow a common naming scheme - /area/cynosure/(type/department)/(floor)/(area name)
- Replace substation scrubber valves with open variants
- Fix leaking pipes in Research, which tripped the shutoff valves
- Fix probably all airlocks on the station
- Fix/Setup the Cargo, Emergency and Escape Pod shuttles.

Area permissions, new areas icons (#2)

* Fixed secure access for all departments, added new access operator: Opion to unsecure areas inside secure areas
* Added missing new icon file
* fixed access for jobs, added job overrides for cynosure
* fixed access merge
* fixed prison access
* Merged job overrides to one file

Ore box + Unloader fix
- Fix unloader not updating ore box on-examine contents when removing ores
- Tweak ore box examine to skip ores that have 0 pieces contained in the box.

Assorted cynosure map fixes
- Fix miners not having access to their own locker room
- Remapped refinery room to use the new machines
- Added assorted circuit boards to tech storage
- Fix atmospherics holding tank computers as well as the supermatter computer not being linked to their vents/injectors/sensors.

Fixed signs and lights (#3)

Shutter and button fixes (#4)

* Fixed signs and lights

* Shutter fixes, directional signs fixes, surgery holosign fixes, blast door button fixes

Updating Cynosure to compile on current Neb.

Co-authored-by: Atlantis <git@stepanekjakub.cz>
Co-authored-by: woody41 <26313915+woody41@users.noreply.github.com>

Author: 3 people

.github/workflows/test.yml

@@ -100,7 +100,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        map_path: [example, tradeship, exodus, ministation, shaded_hills, away_sites_testing, modpack_testing, planets_testing]
+        map_path: [example, tradeship, exodus, ministation, shaded_hills, cynosure, away_sites_testing, modpack_testing, planets_testing]
     steps:
       - uses: actions/checkout@v3
       - name: Setup Cache

code/__defines/definition_helpers.dm

@@ -1,4 +1,72 @@
 /**Define a poster's decl and its mapper type */
 #define DEFINE_POSTER(TYPENAME, ICONSTATE, NAME, DESC)\
 /decl/poster_design/##TYPENAME{name = NAME; desc = DESC; icon_state = ICONSTATE;};\
-/obj/structure/sign/poster/##TYPENAME{poster_design = /decl/poster_design/##TYPENAME; name = NAME; icon_state = ICONSTATE;};
+/obj/structure/sign/poster/##TYPENAME{poster_design = /decl/poster_design/##TYPENAME; name = NAME; icon_state = ICONSTATE;};
+
+// Defines an escape pod shuttle datum and all relevant landmarks.
+#define DEFINE_ESCAPE_POD(NAME, ID) \
+/datum/shuttle/autodock/ferry/escape_pod/pod_##ID { \
+	shuttle_area = /area/shuttle/escape_pod_##ID; \
+	name = "Escape Pod " + #NAME; \
+	dock_target = "escape_pod_" + #ID; \
+	arming_controller = "escape_pod_"+ #ID +"_berth"; \
+	waypoint_station = "escape_pod_"+ #ID +"_start"; \
+	landmark_transition = "escape_pod_"+ #ID +"_transit"; \
+	waypoint_offsite = "escape_pod_"+ #ID +"_out"; \
+} \
+/obj/effect/shuttle_landmark/escape_pod/start/pod_##ID { \
+	landmark_tag = "escape_pod_"+ #ID +"_start"; \
+	docking_controller = "escape_pod_"+ #ID +"_berth"; \
+} \
+/obj/effect/shuttle_landmark/escape_pod/transit/pod_##ID { \
+	landmark_tag = "escape_pod_"+ #ID +"_transit"; \
+} \
+/obj/effect/shuttle_landmark/escape_pod/out/pod_##ID { \
+	landmark_tag = "escape_pod_"+ #ID +"_out"; \
+} \
+/area/shuttle/escape_pod_##ID { \
+	name = "Escape Pod " + #NAME; \
+	area_flags = AREA_FLAG_RAD_SHIELDED | AREA_FLAG_ION_SHIELDED | AREA_FLAG_IS_NOT_PERSISTENT; \
+}
+
+#define DEFINE_STACK_SUBTYPES(MAT_ID, MAT_NAME, MAT_TYPE, STACK_TYPE, REINF_TYPE) \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID {                    \
+	name = "1 " + MAT_NAME;                                                \
+	material = /decl/material/MAT_TYPE;                                    \
+	reinf_material = REINF_TYPE;                                           \
+	amount = 1;                                                            \
+	is_spawnable_type = TRUE;                                              \
+	color = parent_type::paint_color || /decl/material/MAT_TYPE::color;    \
+}                                                                          \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID/five {               \
+	name = "5 " + MAT_NAME;                                                \
+	amount = 5;                                                            \
+}                                                                          \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID/ten {                \
+	name = "10 " + MAT_NAME;                                               \
+	amount = 10;                                                           \
+}                                                                          \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID/fifteen {            \
+	name = "15 " + MAT_NAME;                                               \
+	amount = 15;                                                           \
+}                                                                          \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID/twenty {             \
+	name = "20 " + MAT_NAME;                                               \
+	amount = 20;                                                           \
+}                                                                          \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID/twentyfive {         \
+	name = "25 " + MAT_NAME;                                               \
+	amount = 25;                                                           \
+}                                                                          \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID/thirty {             \
+	name = "30 " + MAT_NAME;                                               \
+	amount = 30;                                                           \
+}                                                                          \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID/forty {              \
+	name = "40 " + MAT_NAME;                                               \
+	amount = 40;                                                           \
+}                                                                          \
+/obj/item/stack/material/##STACK_TYPE/mapped/##MAT_ID/fifty {              \
+	name = "50 " + MAT_NAME;                                               \
+	amount = 50;                                                           \
+}

code/__defines/guns.dm

@@ -24,7 +24,6 @@
 #define SPEEDLOADER 	2	//Transfers casings from the mag to the gun when used.
 #define MAGAZINE 		4	//The magazine item itself goes inside the gun
 
-
 #define GUN_BULK_RIFLE  5
 
 #define BULLET_IMPACT_NONE  "none"

code/controllers/evacuation/evacuation.dm

@@ -117,7 +117,7 @@
 			if(istype(A) && (A.area_flags & AREA_FLAG_HALLWAY))
 				A.readyreset()
 		emergency_evacuation = 0
-	else if(global.using_map.emergency_shuttle_recall_message)
+	else if(global.using_map.shuttle_recall_message)
 		priority_announcement.Announce(global.using_map.shuttle_recall_message)
 
 	return 1

code/controllers/evacuation/evacuation_lifepods.dm

@@ -17,7 +17,9 @@
 	if(waiting_to_leave())
 		return
 	state = EVAC_IN_TRANSIT
-	priority_announcement.Announce(replacetext(replacetext(global.using_map.emergency_shuttle_leaving_dock, "%dock_name%", "[global.using_map.dock_name]"),  "%ETA%", "[round(get_eta()/60,1)] minute\s"))
+	var/msg = global.using_map.emergency_shuttle_leaving_dock
+	if(msg)
+		priority_announcement.Announce(replacetext(replacetext(msg, "%dock_name%", "[global.using_map.dock_name]"),  "%ETA%", "[round(get_eta()/60,1)] minute\s"))
 	return 1
 
 /datum/evacuation_controller/lifepods/available_evac_options()

code/controllers/subsystems/shuttle.dm

@@ -42,7 +42,7 @@ SUBSYSTEM_DEF(shuttle)
 	while (working_shuttles.len)
 		var/datum/shuttle/shuttle = working_shuttles[working_shuttles.len]
 		working_shuttles.len--
-		if(shuttle.process_state && (shuttle.Process(wait, times_fired, src) == PROCESS_KILL))
+		if((shuttle.always_process || shuttle.process_state) && (shuttle.Process(wait, times_fired, src) == PROCESS_KILL) && !shuttle.always_process)
 			process_shuttles -= shuttle
 
 		if (MC_TICK_CHECK)

code/game/jobs/access_datum.dm

@@ -58,6 +58,12 @@ var/global/const/access_tox_storage = "ACCESS_TOX_STORAGE" //8
 	desc = "Toxins Lab"
 	region = ACCESS_REGION_RESEARCH
 
+var/global/const/access_warden = "ACCESS_WARDEN" //9
+/datum/access/warden
+	id = access_warden
+	desc = "Warden Office"
+	region = ACCESS_REGION_SECURITY
+
 var/global/const/access_engine = "ACCESS_ENGINEERING" //10
 /datum/access/engine
 	id = access_engine
@@ -268,12 +274,6 @@ var/global/const/access_research = "ACCESS_RESEARCH" //47
 	desc = "Science"
 	region = ACCESS_REGION_RESEARCH
 
-var/global/const/access_explorer = "ACCESS_EXPLORER"
-/datum/access/explorer
-	id = access_explorer
-	desc = "Explorer"
-	region = ACCESS_REGION_GENERAL
-
 var/global/const/access_mining = "ACCESS_MINING" //48
 /datum/access/mining
 	id = access_mining
@@ -310,12 +310,6 @@ var/global/const/access_xenobiology = "ACCESS_XENOBIO" //55
 	desc = "Xenobiology Lab"
 	region = ACCESS_REGION_RESEARCH
 
-var/global/const/access_xenofauna = "ACCESS_XENOFAUNA"
-/datum/access/xenofauna
-	id = access_xenofauna
-	desc = "Xenfauna Lab"
-	region = ACCESS_REGION_RESEARCH
-
 var/global/const/access_ce = "ACCESS_CHIEF_ENGINEER" //56
 /datum/access/ce
 	id = access_ce

code/game/machinery/alarm.dm

@@ -1123,3 +1123,15 @@ FIRE ALARM
 
 	if(. == TOPIC_REFRESH)
 		interact(user)
+
+/obj/machinery/alarm/outside/Initialize(mapload, dir)
+	..()
+	return INITIALIZE_HINT_LATELOAD
+
+// TODO: Automatically set to expected exterior conditions.
+/*
+/obj/machinery/alarm/outside/LateInitialize()
+	. = ..()
+	if(isatom(loc) && loc.z)
+		var/datum/level_data/level = SSmapping.levels_by_z[loc.z]
+*/

code/game/machinery/atmoalter/canister.dm

@@ -82,10 +82,11 @@
 	start_gas      = /decl/material/gas/hydrogen
 
 /obj/machinery/portable_atmospherics/canister/phoron
-	name = "\improper Canister \[Phoron\]"
-	icon_state = "orange"
-	canister_color = "orange"
-	can_label = 0
+	name           = "phoron canister"
+	icon_state     = "purple"
+	canister_color = "purple"
+	can_label      = FALSE
+	start_gas      = /decl/material/solid/phoron
 
 /obj/machinery/portable_atmospherics/canister/carbon_dioxide
 	name           = "\improper CO2 canister"

code/game/machinery/cryopod.dm

@@ -32,7 +32,7 @@
 
 	var/storage_desc = "crewmembers"
 	var/storage_name = "Cryogenic Oversight Control"
-	var/allow_items = 1
+	var/allow_items = TRUE
 
 /obj/machinery/computer/cryopod/Destroy()
 	QDEL_NULL_LIST(frozen_items)
@@ -46,7 +46,14 @@
 
 	storage_desc = "cyborgs"
 	storage_name = "Robotic Storage Control"
-	allow_items = 0
+	allow_items = FALSE
+
+/obj/machinery/computer/cryopod/checkpoint
+	name = "travel oversight console"
+	desc = "An interface between visitors and the checkpoint systems tasked with keeping track of all visitors who enter or exit from the area."
+
+	storage_desc = "visitors"
+	storage_name = "Travel Oversight Control"
 
 /obj/machinery/computer/cryopod/interface_interact(mob/user)
 	interact(user)
@@ -133,6 +140,11 @@
 	build_path = /obj/machinery/computer/cryopod/robot
 	origin_tech = @'{"programming":3}'
 
+/obj/item/stock_parts/circuitboard/checkpointcontrol
+	name = "circuit board (Checkpoint Console)"
+	build_path = /obj/machinery/computer/cryopod/checkpoint
+	origin_tech = @'{"programming":3}'
+
 //Decorative structures to go alongside cryopods.
 /obj/structure/cryofeed
 
@@ -190,31 +202,6 @@
 	disallow_occupant_types = list(/mob/living/silicon/robot/drone)
 	applies_stasis = 0
 
-// Cryo
-/obj/machinery/cryopod/robot/door
-	//This inherits from the robot cryo, so synths can be properly cryo'd.  If a non-synth enters and is cryo'd, ..() is called and it'll still work.
-	abstract_type = /obj/machinery/cryopod/robot/door
-	name = "Airlock of Wonders"
-	desc = "An airlock that isn't an airlock, and shouldn't exist.  Yell at a coder/mapper."
-	icon = 'icons/obj/machines/tramdoors.dmi'
-	icon_state = "door_closed"
-	base_icon_state = "door_closed"
-	occupied_icon_state = "door_locked"
-	on_enter_visible_message = "$USER$ steps into $TARGET$."
-
-	time_till_despawn = 1 MINUTE //We want to be much faster then normal cryo, since waiting in an elevator for half an hour is a special kind of hell.
-
-	allow_occupant_types = list(/mob/living/silicon/robot,/mob/living/human)
-	disallow_occupant_types = list(/mob/living/silicon/robot/drone)
-
-/obj/machinery/cryopod/robot/door/dorms
-	name = "Residential District Elevator"
-	desc = "A small elevator that goes down to the deeper section of the colony."
-	on_store_message = "has departed for the residential district."
-	on_store_name = "Residential Oversight"
-	on_enter_occupant_message = "The elevator door closes slowly, ready to bring you down to the residential district."
-	on_store_visible_message = "$TARGET$ makes a ding as it moves $USER$ to the residential district."
-
 /obj/machinery/cryopod/lifepod
 	name = "life pod"
 	desc = "A man-sized pod for entering suspended animation. Dubbed 'cryocoffin' by more cynical spacers, it is pretty barebone, counting on stasis system to keep the victim alive rather than packing extended supply of food or air. Can be ordered with symbols of common religious denominations to be used in space funerals too."
@@ -600,3 +587,12 @@
 	on_store_name = "Residential Oversight"
 	on_enter_occupant_message = "The elevator door closes slowly, ready to bring you down to the residential district."
 	on_store_visible_message = "$TARGET$ makes a ding as it moves $USER$ to the residential district."
+
+/obj/machinery/cryopod/robot/door/checkpoint
+	name = "automated checkpoint"
+	desc = "A reinforced, automated checkpoint tracking arrivals and departures from the outpost. Beyond this vault is a small airstrip, then nothing but untamed wilderness."
+	on_store_message = "has departed from the colony."
+	on_store_name = "Travel Oversight"
+	on_enter_occupant_message = "The checkpoint unseals and grinds open, and you step through."
+	on_store_visible_message = "The checkpoint grinds closed after $TARGET$ passes through it."
+	time_till_despawn = 1 SECOND