-
Notifications
You must be signed in to change notification settings - Fork 162
Failing to rewrite In iFrames #55
Description
What the issue?
It seems that the Service Worker. Unregisters itself I am using the default SW included in the static files but that's not a problem neccesarilly. Whenever you run or create dynamic in a iframe. It will fail to rewrite the entire HTML page.
Fixes
It seems for me atleast that the NPM package version has fixed alot of issues. But this is a 50/50 chance of working
How to somewhat replicate
just run it in a iFrame. (Both redirecting from a HTML page inside of the iframe and Registering it from the main page work).
Possible Fixes (possibly bad on performance)
-
Make sure that the SW is always being registered correctly somewhat like UV where if its not complete it will register it for you
-
Add A checker that makes sure that the site is completely rewrittern (ik its difficult but its a suggestion)
Conclusion
Just use the NPM package version. and run your proxy and copy your dist files.
Related issues
#65
#14 (Not the issue itself since its fixed but the last comment)