Fix error the terraform output -json command is being called incorrectly

Author: NeckerFree

.github/workflows/terraform.yml

@@ -201,36 +201,38 @@ jobs:
         run: |
           cd infra
           
-          # Get raw JSON output (with error handling)
-          if ! terraform output -json > outputs.json; then
-            echo "::error::Terraform output command failed"
+          # Get the full path to terraform binary
+          TF_PATH=$(which terraform)
+          echo "Using Terraform at: $TF_PATH"
+          
+          # Execute terraform output properly
+          $TF_PATH output -json > outputs.json
+          
+          # Verify JSON file exists and is valid
+          if [[ ! -f outputs.json ]]; then
+            echo "::error::Terraform failed to create outputs.json"
             exit 1
           fi
           
-          # Verify JSON is valid
           if ! jq empty outputs.json; then
-            echo "::error::Invalid JSON output from Terraform"
+            echo "::error::Invalid JSON in outputs.json"
             cat outputs.json
             exit 1
           fi
           
-          # Extract values with strict validation
-          APP_NAME=$(jq -r '.app_service_name.value // empty' outputs.json)
-          RG_NAME=$(jq -r '.resource_group_name.value // empty' outputs.json)
-          API_URL=$(jq -r '.lb_api_url.value // empty' outputs.json)
+          # Extract values safely
+          APP_NAME=$(jq -r '.app_service_name.value' outputs.json)
+          RG_NAME=$(jq -r '.resource_group_name.value' outputs.json)
+          API_URL=$(jq -r '.lb_api_url.value' outputs.json)
           
-          # Verify all values exist
+          # Verify values
           if [[ -z "$APP_NAME" || -z "$RG_NAME" || -z "$API_URL" ]]; then
-            echo "::error::Missing required outputs from Terraform"
+            echo "::error::Missing required values in outputs"
             jq . outputs.json
             exit 1
           fi
           
-          # Sanitize values (remove any special characters)
-          APP_NAME=$(echo "$APP_NAME" | tr -cd '[:alnum:]-_')
-          RG_NAME=$(echo "$RG_NAME" | tr -cd '[:alnum:]-_')
-          API_URL=$(echo "$API_URL" | tr -cd '[:alnum:]:/.')
-          
+          # Set outputs
           echo "webapp_name=${APP_NAME}" >> $GITHUB_OUTPUT
           echo "resource_group=${RG_NAME}" >> $GITHUB_OUTPUT
           echo "api_url=${API_URL}" >> $GITHUB_OUTPUT

ansible/deploy-frontend.yml

@@ -3,23 +3,17 @@
   hosts: localhost
   connection: local
   vars:
-    app_service_name: "{{ lookup('env', 'APP_SERVICE_NAME') }}"
-    resource_group_name: "{{ lookup('env', 'RESOURCE_GROUP_NAME') }}"
-    lb_api_url: "{{ lookup('env', 'LB_API_URL') }}"
     node_version: "16-lts"
 
   tasks:
-    - name: Validate environment variables
-      fail:
-        msg: |
-          Missing required environment variables!
-          - APP_SERVICE_NAME: {{ lookup('env', 'APP_SERVICE_NAME') }}
-          - RESOURCE_GROUP_NAME: {{ lookup('env', 'RESOURCE_GROUP_NAME') }}
-          - LB_API_URL: {{ lookup('env', 'LB_API_URL') }}
-      when: >
-        not lookup('env', 'APP_SERVICE_NAME') or
-        not lookup('env', 'RESOURCE_GROUP_NAME') or
-        not lookup('env', 'LB_API_URL')
+    - name: Validate required variables
+      assert:
+        that:
+          - app_service_name is defined
+          - resource_group_name is defined
+          - lb_api_url is defined
+        fail_msg: "Missing required variables from GitHub Actions"
+        success_msg: "All required variables present"
 
     - name: Show deployment configuration
       debug: